From lev@ftp.translate.ru  Thu Aug 22 00:10:37 2002
Return-Path: <lev@ftp.translate.ru>
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 204BF37B400
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 22 Aug 2002 00:10:37 -0700 (PDT)
Received: from ftp.translate.ru (ftp.translate.ru [195.131.4.140])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 32E2543E3B
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 22 Aug 2002 00:10:36 -0700 (PDT)
	(envelope-from lev@ftp.translate.ru)
Received: from ftp.translate.ru (localhost [127.0.0.1])
	by ftp.translate.ru (8.12.5/8.12.5) with ESMTP id g7M7ANiO062085
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 22 Aug 2002 11:10:23 +0400 (MSD)
	(envelope-from lev@ftp.translate.ru)
Received: (from lev@localhost)
	by ftp.translate.ru (8.12.5/8.12.5/Submit) id g7M7AIO1062084;
	Thu, 22 Aug 2002 11:10:18 +0400 (MSD)
Message-Id: <200208220710.g7M7AIO1062084@ftp.translate.ru>
Date: Thu, 22 Aug 2002 11:10:18 +0400 (MSD)
From: "Lev A. Serebryakov" <lev@serebryakov.spb.ru>
Reply-To: "Lev A. Serebryakov" <lev@serebryakov.spb.ru>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: ng_device was not MFCed for 2 months
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         41881
>Category:       kern
>Synopsis:       ng_device was not MFCed for 2 months
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    glebius
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Aug 22 00:20:01 PDT 2002
>Closed-Date:    Thu Nov 11 09:44:35 GMT 2004
>Last-Modified:  Thu Nov 11 09:44:35 GMT 2004
>Originator:     Lev A. Serebryakov <lev@serebryakov.spb.ru>
>Release:        FreeBSD 4.6-STABLE i386
>Organization:
>Environment:

FreeBSD freebsd.sereb.net 4.6-STABLE FreeBSD 4.6-STABLE #0: Thu Aug  8 20:06:13 MSD 2002     root@freebsd.sereb.net:/usr/obj/usr/src/sys/LEVMAIL  i386

>Description:

  CVS commit log for src/sys/netgraph/ng_device.c contains:

  MFC after:	3 weeks

  And it was 2 months ago.

>How-To-Repeat:
	
>Fix:

   Please, MFC this ng type to STABLE.
>Release-Note:
>Audit-Trail:

From: Magnus B{ckstr|m <b@etek.chalmers.se>
To: "Lev A. Serebryakov" <lev@serebryakov.spb.ru>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: kern/41881: ng_device was not MFCed for 2 months
Date: Thu, 22 Aug 2002 11:07:14 +0200 (CEST)

 On Thu, 22 Aug 2002, Lev A. Serebryakov wrote:
 > Subject: kern/41881: ng_device was not MFCed for 2 months
 > >Synopsis:       ng_device was not MFCed for 2 months
 
 >   CVS commit log for src/sys/netgraph/ng_device.c contains:
 >
 >   MFC after:	3 weeks
 >
 >   And it was 2 months ago.
 
 >    Please, MFC this ng type to STABLE.
 
 Isn't ng_device a work-in-progress still, rather than ready to be MFCd?
 When it first showed up I noted that A) it doesn't get built by default,
 and B) it has some problems:
 
 #include "ng_device.h"
 rather than
 #include <netgraph/ng_device.h>
 which makes it not compile when doing a make in sys/modules/netgraph/device,
 
 and the following passage (track what happens to `buffer'):
 
 	buffer = malloc(sizeof(char)*m->m_len, M_DEVBUF, M_NOWAIT | M_ZERO);
 	if(buffer == NULL) {
 		printf("%s(): ERROR: buffer malloc failed\n",__func__);
 		return(-1);
 	}
 
 	buffer = mtod(m,char *);
 
 	if( (connection->loc+m->m_len) < NGD_QUEUE_SIZE) {
 	        memcpy(connection->readq+connection->loc, buffer, m->m_len);
 		connection->loc += m->m_len;
 	} else
 		printf("%s(): queue full, first read out a bit\n",__func__);
 
 	free(buffer,M_DEVBUF);
 
 I assumed somebody was working on the file and thus didn't supply
 a patch PR; apparently though it is orphaned.
 
 bmb
 
 
Responsible-Changed-From-To: freebsd-bugs->julian 
Responsible-Changed-By: johan 
Responsible-Changed-When: Thu Aug 22 19:23:11 PDT 2002 
Responsible-Changed-Why:  
Over to Julian who committed the file in question. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=41881 
Responsible-Changed-From-To: julian->glebius 
Responsible-Changed-By: glebius 
Responsible-Changed-When: Tue Jul 20 09:08:55 GMT 2004 
Responsible-Changed-Why:  
I do not promise MFC yet, but I'm going to fix problems mentioned in Audit-Trail. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=41881 
State-Changed-From-To: open->closed 
State-Changed-By: glebius 
State-Changed-When: Thu Nov 11 09:43:37 GMT 2004 
State-Changed-Why:  
Problems described in PR are fixed. The new node have 
been MFC'ed to RELENG_5. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=41881 
>Unformatted:
