From itojun@itojun.org  Fri Jul 18 12:06:08 1997
Received: from coconut.itojun.org (itojun@coconut.itojun.org [133.138.201.163])
          by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id MAA10414
          for <FreeBSD-gnats-submit@freebsd.org>; Fri, 18 Jul 1997 12:06:06 -0700 (PDT)
Received: (from itojun@localhost) by coconut.itojun.org (8.8.5/3.5Wpl7) id EAA05566; Sat, 19 Jul 1997 04:06:02 +0900 (JST)
Message-Id: <199707181906.EAA05566@coconut.itojun.org>
Date: Sat, 19 Jul 1997 04:06:02 +0900 (JST)
From: Jun-ichiro ITOH <itojun@itojun.org>
Reply-To: itojun@itojun.org
To: FreeBSD-gnats-submit@freebsd.org
Cc: itojun@csl.sony.co.jp
Subject: if_spppsubr.c: problem talking with cisco via cisco hdlc
X-Send-Pr-Version: 3.2

>Number:         4117
>Category:       kern
>Synopsis:       if_spppsubr.c: problem talking with cisco via cisco hdlc
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    itojun
>State:          closed
>Quarter:
>Keywords:
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jul 18 12:10:03 PDT 1997
>Closed-Date:    Tue Aug 5 18:39:57 PDT 1997
>Last-Modified:  Tue Aug  5 18:59:32 PDT 1997
>Originator:     Jun-ichiro ITOH
>Release:        FreeBSD 2.2.1-RELEASE i386
>Organization:
Sony CSL Inc., Tokyo, Japan
>Environment:

FreeBSD coconut.itojun.org 2.2.1-RELEASE FreeBSD 2.2.1-RELEASE #3: Sun Apr 20 14:28:44 JST 1997     root@coconut.itojun.org:/usr/src/sys/compile/COCONUT  i386

	the bug still remains in the FreeBSD-current.

>Description:

	(this is a resend. sorry if duplicated)
	FreeBSD+riscom box can't talk with cisco router via cisco hdlc.

>How-To-Repeat:

	try to connect FreeBSD+riscom with cisco.

>Fix:

	If nobody objects it, i can commit it myself.
	
--- if_spppsubr.c-dist	Fri Jul 18 13:29:11 1997
+++ if_spppsubr.c	Fri Jul 18 13:32:37 1997
@@ -920,7 +920,7 @@
 	struct ifaddr *ifa;
 	struct ifnet *ifp = &sp->pp_if;
 
-	if (m->m_pkthdr.len != CISCO_PACKET_LEN) {
+	if (m->m_pkthdr.len < CISCO_PACKET_LEN) {
 		if (ifp->if_flags & IFF_DEBUG)
 			printf ("%s%d: invalid cisco packet length: %d bytes\n",
 				ifp->if_name, ifp->if_unit, m->m_pkthdr.len);

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->joerg 
Responsible-Changed-By: joerg 
Responsible-Changed-When: Thu Jul 31 23:20:07 MEST 1997 
Responsible-Changed-Why:  
I've touched sppp last time. 
Anyway, Jun-ichiro, you've got commit privs as well... 

From: Jun-ichiro Itoh <itojun@itojun.org>
To: freebsd-gnats-submit@freebsd.org, itojun@itojun.org
Cc:  Subject: Re: kern/4117: if_spppsubr.c: problem talking with cisco via cisco hdlc
Date: Tue, 05 Aug 1997 21:45:20 +0900

 yes I have, however, most people seems to say that "patch should be
 reviewed". (maybe I'm paranoid)
 it is okey to proceed by myself, I'm happy to handle.....
State-Changed-From-To: open->closed 
State-Changed-By: itojun 
State-Changed-When: Tue Aug 5 18:39:57 PDT 1997 
State-Changed-Why:  

grabbed by itojun. 
committed. (ishii@csl.sony.co.jp and kjc@csl.sony.co.jp 
have checked with FreeBSD+Riscom - cisco4500 configuration) 


Responsible-Changed-From-To: joerg->itojun 
Responsible-Changed-By: itojun 
Responsible-Changed-When: Tue Aug 5 18:39:57 PDT 1997 
Responsible-Changed-Why:  
grabbed by itojun since I commit it. 
>Unformatted:
