From jin@adsl-63-198-35-122.dsl.snfc21.pacbell.net  Fri Jul 12 22:22:31 2002
Return-Path: <jin@adsl-63-198-35-122.dsl.snfc21.pacbell.net>
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3AF4237B400
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 12 Jul 2002 22:22:31 -0700 (PDT)
Received: from adsl-63-198-35-122.dsl.snfc21.pacbell.net (adsl-63-198-35-122.dsl.snfc21.pacbell.net [63.198.35.122])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9BC4E43E6D
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 12 Jul 2002 22:22:30 -0700 (PDT)
	(envelope-from jin@adsl-63-198-35-122.dsl.snfc21.pacbell.net)
Received: (from jin@localhost)
	by adsl-63-198-35-122.dsl.snfc21.pacbell.net (8.11.6/8.11.6) id g6D5NVO00484;
	Fri, 12 Jul 2002 22:23:31 -0700 (PDT)
	(envelope-from jin)
Message-Id: <200207130523.g6D5NVO00484@adsl-63-198-35-122.dsl.snfc21.pacbell.net>
Date: Fri, 12 Jul 2002 22:23:31 -0700 (PDT)
From: "Jin Guojun[VFF]" <jin@adsl-63-198-35-122.dsl.snfc21.pacbell.net>
Reply-To: j_guojun@lbl.gov
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: ti driver has no buadrate set
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         40516
>Category:       kern
>Synopsis:       [ti] [patch] ti driver has no baudrate set
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    remko
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jul 12 22:30:00 PDT 2002
>Closed-Date:    Tue Feb 26 19:29:47 UTC 2008
>Last-Modified:  Tue Feb 26 19:30:04 UTC 2008
>Originator:     Jin Guojun[VFF]
>Release:        FreeBSD 4.x-RELEASE i386
>Organization:
>Environment:


	/sys/pci/if_ti.c

>Description:
	Network driver if_ti does not set the baudrate. It causes inquery
	to return 10,000,000 baudrate instead of 1,000,000,000.

119 /sys/pci: nic-info
NIC     fxp0    baudrate        100000000 type 0x06 (06) srt 0
NIC      lp0    baudrate                0 type 0x22 (34) srt 0
NIC      ti0    baudrate         10000000 type 0x06 (06) srt 0
NIC      sk0    baudrate       1000000000 type 0x06 (06) srt 0
NIC      lo0    baudrate                0 type 0x18 (24) srt 0
NIC     ppp0    baudrate                0 type 0x17 (23) srt 0
NIC      sl0    baudrate                0 type 0x1c (28) srt 0
NIC   faith0    baudrate                0 type 0x38 (56) srt 0

>How-To-Repeat:
	
>Fix:

	apply the following patch to 4.6-RELEASE /sys/pci/if_ti.c:

*** /sys/pci/if_ti.c	Thu Feb 14 20:20:20 2002
--- if_ti.c	Fri Jul 12 22:12:56 2002
***************
*** 1721,1726 ****
--- 1721,1727 ----
  	ifp->if_start = ti_start;
  	ifp->if_watchdog = ti_watchdog;
  	ifp->if_init = ti_init;
+ 	ifp->if_baudrate = 1000000000;
  	ifp->if_mtu = ETHERMTU;
  	ifp->if_snd.ifq_maxlen = TI_TX_RING_CNT - 1;
  
>Release-Note:
>Audit-Trail:

From: Gavin Atkinson <gavin@FreeBSD.org>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/40516: [ti] [patch] ti driver has no baudrate set
Date: Tue, 12 Jun 2007 13:34:15 +0100

 This is still a problem, and the patch looks valid to me.  All other NIC
 drivers I've looked at do the same.  1000000000 could perhaps be better
 written as IF_Gbps(1) - although most other drivers seem to use the full
 number.
 
 Gavin
Responsible-Changed-From-To: freebsd-bugs->remko 
Responsible-Changed-By: remko 
Responsible-Changed-When: Tue Feb 12 10:52:29 UTC 2008 
Responsible-Changed-Why:  
After reading Mark's periodic interesting PR's grab this one to handle. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=40516 
State-Changed-From-To: open->patched 
State-Changed-By: remko 
State-Changed-When: Tue Feb 19 20:55:09 UTC 2008 
State-Changed-Why:  
Patched in -CURRENT, MFC reminder 

http://www.freebsd.org/cgi/query-pr.cgi?pr=40516 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/40516: commit references a PR
Date: Tue, 19 Feb 2008 20:54:51 +0000 (UTC)

 remko       2008-02-19 20:54:42 UTC
 
   FreeBSD src repository
 
   Modified files:
     sys/dev/ti           if_ti.c 
   Log:
   Set the baudrate for if_ti.
   
   PR:             kern/40516
   Submitted by:   "Jin Guojun[VFF]" <jin at adsl-63-198-35-122 dot dsl dot snfc21 dot pacbell dot net>
   Approved by:    imp (mentor, implicit for minor changes)
   MFC After:      1 week
   
   Revision  Changes    Path
   1.131     +1 -0      src/sys/dev/ti/if_ti.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: remko 
State-Changed-When: Tue Feb 26 19:29:46 UTC 2008 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=40516 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/40516: commit references a PR
Date: Tue, 26 Feb 2008 19:28:39 +0000 (UTC)

 remko       2008-02-26 19:28:34 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_6)
     sys/pci              if_ti.c 
   Log:
   MFC rev 1.131 if_ti.c
   
   Set the baudrate for if_ti.
   
     PR: kern/40516
     Submitted by: "Jin Guojun[VFF]" <jin at adsl-63-198-35-122 dot dsl dot snfc21 dot pacbell dot net>
     Approved by: imp (mentor, implicit for minor changes)
     MFC After: 1 week
   
   Approved by:    imp (mentor, implicit)
   
   Revision   Changes    Path
   1.107.2.6  +1 -0      src/sys/pci/if_ti.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/40516: commit references a PR
Date: Tue, 26 Feb 2008 19:29:42 +0000 (UTC)

 remko       2008-02-26 19:29:32 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_7)
     sys/dev/ti           if_ti.c 
   Log:
   MFC rev 1.131 if_ti.c
   
     Set the baudrate for if_ti.
   
     PR: kern/40516
     Submitted by: "Jin Guojun[VFF]" <jin at adsl-63-198-35-122 dot dsl dot snfc21 dot pacbell dot net>
     Approved by: imp (mentor, implicit for minor changes)
     MFC After: 1 week
   
   Approved by:    imp (mentor, implicit)
   
   Revision   Changes    Path
   1.128.2.1  +1 -0      src/sys/dev/ti/if_ti.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
