From nobody@www.freebsd.org  Tue Jun 18 05:06:27 2002
Return-Path: <nobody@www.freebsd.org>
Received: from nwww.freebsd.org (www.FreeBSD.org [216.136.204.117])
	by hub.freebsd.org (Postfix) with ESMTP id EC15937B403
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 18 Jun 2002 05:06:26 -0700 (PDT)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by nwww.freebsd.org (8.12.2/8.12.2) with ESMTP id g5IC6QhG059207
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 18 Jun 2002 05:06:26 -0700 (PDT)
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.12.2/8.12.2/Submit) id g5IC6Qbr059206;
	Tue, 18 Jun 2002 05:06:26 -0700 (PDT)
Message-Id: <200206181206.g5IC6Qbr059206@www.freebsd.org>
Date: Tue, 18 Jun 2002 05:06:26 -0700 (PDT)
From: Greg Quinlan <gwq_uk@yahoo.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Duplicate function in /usr/src/sys/netgraph/ng_pppoe.c
X-Send-Pr-Version: www-1.0

>Number:         39464
>Category:       kern
>Synopsis:       Duplicate function in /usr/src/sys/netgraph/ng_pppoe.c
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jun 18 05:10:01 PDT 2002
>Closed-Date:    Tue Jun 18 08:58:01 PDT 2002
>Last-Modified:  Tue Jun 18 08:58:01 PDT 2002
>Originator:     Greg Quinlan
>Release:        4.6-Stable
>Organization:
>Environment:
4.6-Stable      
>Description:
/usr/src/sys/netgraph/ng_pppoe.c has a repeated function, called "send_sessionid". 
>How-To-Repeat:
compile the kernel.
>Fix:
Delete the second repeated procedure! 
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: roam 
State-Changed-When: Tue Jun 18 08:49:17 PDT 2002 
State-Changed-Why:  

Thanks for the alert; however, there are two points that you might want 
to consider about it :) 

First, there is a mailing list specifically dealing with problems and 
peculiarities of the FreeBSD -STABLE branch: freebsd-stable@FreeBSD.org. 
If you are having a problem which seems to stem from something done to 
the -STABLE branch recently, like a commit that breaks the build, as 
opposed to some architectural change, unsupported hardware, or other 
large-scale time-consuming problem, the freebsd-stable list is the first 
place you should search for a solution, and the first place you should 
report the problem itself. 

Second, even in the cases that merit sending a GNATS PR, there is 
sometimes a lot to be gained by searching the GNATS database for others 
who have reported the same (or similar) problem.  At the URL 
http://www.FreeBSD.org/cgi?query-pr-summary.cgi?query 
there is a web interface that lets you easily search for related problem 
reports.  Right now, a search for PR's containing 'ng_pppoe' in the 
single-line fields (like the Subject or the Synopsis lines are) would 
not return many matches; however, if you check the 'closed PR's too' 
box, it will quickly become apparent that others have indeed reported 
this problem already, *and* that it has already been solved :) 

Still, thanks for your efforts in improving FreeBSD! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=39464 
>Unformatted:
