From nobody@nwww.freebsd.org  Mon May  6 04:16:14 2002
Return-Path: <nobody@nwww.freebsd.org>
Received: from nwww.freebsd.org (nwww.FreeBSD.org [216.136.204.117])
	by hub.freebsd.org (Postfix) with ESMTP id 077E037B400
	for <freebsd-gnats-submit@FreeBSD.org>; Mon,  6 May 2002 04:16:14 -0700 (PDT)
Received: from nwww.freebsd.org (localhost [127.0.0.1])
	by nwww.freebsd.org (8.12.2/8.12.2) with ESMTP id g46BHahG053481
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 6 May 2002 04:17:36 -0700 (PDT)
	(envelope-from nobody@nwww.freebsd.org)
Received: (from nobody@localhost)
	by nwww.freebsd.org (8.12.2/8.12.2/Submit) id g46BHajx053480;
	Mon, 6 May 2002 04:17:36 -0700 (PDT)
Message-Id: <200205061117.g46BHajx053480@nwww.freebsd.org>
Date: Mon, 6 May 2002 04:17:36 -0700 (PDT)
From: Ari Suutari <ari.suutari@syncrontech.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: spppcontrol fails if kernel is not compiled with INET6
X-Send-Pr-Version: www-1.0

>Number:         37786
>Category:       kern
>Synopsis:       spppcontrol fails if kernel is not compiled with INET6
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon May 06 04:20:06 PDT 2002
>Closed-Date:    Fri May 10 14:50:06 MEST 2002
>Last-Modified:  Fri May 10 14:50:06 MEST 2002
>Originator:     Ari Suutari
>Release:        RELENG_4 6.5.2002
>Organization:
Syncron Tech Oy
>Environment:
FreeBSD test.syncrontech.com 4.6-PRERELEASE FreeBSD 4.6-PRERELEASE #0: Mon May  6 13:37:16 EEST 2002     root@test.syncrontech.com:/usr/src/sys/compile/ESPRESSO  i386

>Description:
Using spppcontrol to change authentication parameters with ISDN fails
always with "spppcontrol: SIOCSIFGENERIC(SPPPIOSDEFS): Invalid argument".
This is caused by break statement in if_spppsubr.c being inside
#ifdef INET6 (see line 5174).
>How-To-Repeat:
Compile a kernel without INET6 and try to use spppcontrol.
>Fix:
Move break statement in if_spppsubr.c, line 5174 outside #ifdef INET6.
>Release-Note:
>Audit-Trail:

From: David Malone <dwmalone@maths.tcd.ie>
To: Ari Suutari <ari.suutari@syncrontech.com>
Cc: freebsd-gnats-submit@FreeBSD.org, joerg@FreeBSD.org
Subject: Re: kern/37786: spppcontrol fails if kernel is not compiled with INET6
Date: Mon, 6 May 2002 19:40:05 +0100

 On Mon, May 06, 2002 at 04:17:36AM -0700, Ari Suutari wrote:
 > Using spppcontrol to change authentication parameters with ISDN fails
 > always with "spppcontrol: SIOCSIFGENERIC(SPPPIOSDEFS): Invalid argument".
 > This is caused by break statement in if_spppsubr.c being inside
 > #ifdef INET6 (see line 5174).
 
 It looks reasonably obvious to me that this patch is correct, but
 Joerg added it, so maybe he can confirm that for me.
 
 	David.
 
 Index: if_spppsubr.c
 ===================================================================
 RCS file: /cvs/FreeBSD-CVS/src/sys/net/if_spppsubr.c,v
 retrieving revision 1.93
 diff -u -r1.93 if_spppsubr.c
 --- if_spppsubr.c       1 May 2002 04:18:36 -0000       1.93
 +++ if_spppsubr.c       6 May 2002 18:34:16 -0000
 @@ -5145,8 +5145,8 @@
                         sp->confflags |= CONF_ENABLE_IPV6;
                 else
                         sp->confflags &= ~CONF_ENABLE_IPV6;
 -               break;
  #endif
 +               break;
  
         default:
                 rv = EINVAL;
 

From: Joerg Wunsch <j@uriah.heep.sax.de>
To: David Malone <dwmalone@maths.tcd.ie>
Cc: Ari Suutari <ari.suutari@syncrontech.com>,
	freebsd-gnats-submit@FreeBSD.org
Subject: Re: kern/37786: spppcontrol fails if kernel is not compiled with INET6
Date: Tue, 7 May 2002 14:32:23 +0200

 As David Malone wrote:
 
 > It looks reasonably obvious to me that this patch is correct, but
 > Joerg added it, so maybe he can confirm that for me.
 
 Thanks for the submission!  I've got reports about that problem,
 but won't have the time to test-install before Thursday.  I'll
 verify it all again then, and most likely commit your fix.  Thanks,
 David!
 -- 
 cheers, J"org               .-.-.   --... ...--   -.. .  DL8DTL
 
 http://www.sax.de/~joerg/                        NIC: JW11-RIPE
 Never trust an operating system you don't have sources for. ;-)
State-Changed-From-To: open->closed 
State-Changed-By: joerg 
State-Changed-When: Fri May 10 14:49:10 MEST 2002 
State-Changed-Why:  
Suggested patch applied, thanks! 

(MFC into RELENG_4 is now only a matter of RE's approval.) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=37786 
>Unformatted:
