From nobody@FreeBSD.org  Thu Mar 28 18:58:33 2002
Return-Path: <nobody@FreeBSD.org>
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 1E9CD37B405
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 28 Mar 2002 18:58:32 -0800 (PST)
Received: (from nobody@localhost)
	by freefall.freebsd.org (8.11.6/8.11.6) id g2T2wWr74981;
	Thu, 28 Mar 2002 18:58:32 -0800 (PST)
	(envelope-from nobody)
Message-Id: <200203290258.g2T2wWr74981@freefall.freebsd.org>
Date: Thu, 28 Mar 2002 18:58:32 -0800 (PST)
From: Hijiri Umemoto <hijiri@umemoto.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: (sys/dev/bktr) Japan IF frequency is incorrect
X-Send-Pr-Version: www-1.0

>Number:         36451
>Category:       kern
>Synopsis:       [bktr] [patch] Japan IF frequency is incorrect
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Mar 28 19:00:01 PST 2002
>Closed-Date:    
>Last-Modified:  Sun Jul 01 16:10:34 UTC 2012
>Originator:     Hijiri Umemoto
>Release:        4.5-STABLE
>Organization:
>Environment:
FreeBSD sarah.umemoto.org 4.5-STABLE FreeBSD 4.5-STABLE #13: Thu Mar 28 23:31:40 JST 2002     root@sarah.umemoto.org:/usr/src/sys/compile/VIDEO  i386
>Description:
The "bktr" driver (/usr/src/sys/dev/bktr) doesn't work fine on some TV tuners, video/audio is not exactly tuned on Japanese TV/cable bands. (drifts about 2ch higher.) 

>How-To-Repeat:
Use Japanese domestic model of TV tuner card (such as IO-DATA's GV-BCTV4/PCI), and run "fxtv" (by "jpnbcst" and "NTSC-J" option enabled).
Then, select channel 3, you'll see poor quality of channel 1's picture. 


>Fix:
In the file "bktr_tuner.c", definitions of IF_FREQ (IF frequency) on "jpnbcst" and "jpncable" section is incorrect.

(Japanese TV system uses 58.75MHz as the video carrier frequency.  Many video capture cards for international market deploy multi IF (45.75 for US, 58.75 for Japan, etc.) capable tuners, so they work well even in Japan with original bktr driver.  But my video capture card doesn't do so because it's for Japanese-market-only model which uses single picture IF, 58.75MHz.)

Here below is a patch.

*** bktr_tuner.c.orig   Thu Oct 19 16:33:28 2000
--- bktr_tuner.c        Fri Mar 29 09:39:32 2002
***************
*** 543,554 ****
   *  8: 193.25MHz - 12: 217.25MHz  (VHF)
   * 13: 471.25MHz - 62: 765.25MHz  (UHF)
   *
-  * IF freq: 45.75 mHz
-  *  OR
   * IF freq: 58.75 mHz
   */
  #define OFFSET  6.00
! #define IF_FREQ 45.75
  static int jpnbcst[] = {
        62,     (int)(IF_FREQ * FREQFACTOR),    0,
        13,     (int)(471.25 * FREQFACTOR),     (int)(OFFSET * FREQFACTOR),
--- 543,552 ----
   *  8: 193.25MHz - 12: 217.25MHz  (VHF)
   * 13: 471.25MHz - 62: 765.25MHz  (UHF)
   *
   * IF freq: 58.75 mHz
   */
  #define OFFSET  6.00
! #define IF_FREQ 58.75
  static int jpnbcst[] = {
        62,     (int)(IF_FREQ * FREQFACTOR),    0,
        13,     (int)(471.25 * FREQFACTOR),     (int)(OFFSET * FREQFACTOR),
***************
*** 570,579 ****
   * 22: 165.25MHz
   * 23: 223.25MHz - 63: 463.25MHz
   *
!  * IF freq: 45.75 mHz
   */
  #define OFFSET  6.00
! #define IF_FREQ 45.75
  static int jpncable[] = {
        63,     (int)(IF_FREQ * FREQFACTOR),    0,
        23,     (int)(223.25 * FREQFACTOR),     (int)(OFFSET * FREQFACTOR),
--- 568,577 ----
   * 22: 165.25MHz
   * 23: 223.25MHz - 63: 463.25MHz
   *
!  * IF freq: 58.75 mHz
   */
  #define OFFSET  6.00
! #define IF_FREQ 58.75
  static int jpncable[] = {
        63,     (int)(IF_FREQ * FREQFACTOR),    0,
        23,     (int)(223.25 * FREQFACTOR),     (int)(OFFSET * FREQFACTOR),



>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->roger 
Responsible-Changed-By: asmodai 
Responsible-Changed-When: Sun Apr 7 06:10:22 PDT 2002 
Responsible-Changed-Why:  
Roger, 
I assume you can take care of this?  If it can just be committed, let me 
know and I'll take care of it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=36451 
State-Changed-From-To: open->analyzed 
State-Changed-By: asmodai 
State-Changed-When: Sun Apr 7 06:11:06 PDT 2002 
State-Changed-Why:  
The bktr code is maintained by Roger Hardiman. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=36451 
Responsible-Changed-From-To: roger->freebsd-bugs 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Thu Nov 4 08:21:10 GMT 2004 
Responsible-Changed-Why:  
Assignee is currently away from doing FreeBSD work at the moment, so 
at his request, return this one to the pool. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=36451 
State-Changed-From-To: analyzed->open 
State-Changed-By: eadler 
State-Changed-When: Sun Jul 1 16:10:31 UTC 2012 
State-Changed-Why:  
unowned PRs must not be in analyzed state 

http://www.freebsd.org/cgi/query-pr.cgi?pr=36451 
>Unformatted:
