From nobody@FreeBSD.org  Sat Mar 16 19:34:19 2002
Return-Path: <nobody@FreeBSD.org>
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 2F81B37B405
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 16 Mar 2002 19:34:19 -0800 (PST)
Received: (from nobody@localhost)
	by freefall.freebsd.org (8.11.6/8.11.6) id g2H3YJd35155;
	Sat, 16 Mar 2002 19:34:19 -0800 (PST)
	(envelope-from nobody)
Message-Id: <200203170334.g2H3YJd35155@freefall.freebsd.org>
Date: Sat, 16 Mar 2002 19:34:19 -0800 (PST)
From: Jeff Kletsky <jeff+freebsd@spotlife.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: sys/dev/amr/amr.c - Compiler warnings under 5.0-CURRENT
X-Send-Pr-Version: www-1.0

>Number:         35993
>Category:       kern
>Synopsis:       sys/dev/amr/amr.c - Compiler warnings under 5.0-CURRENT
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    murray
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Mar 16 19:40:01 PST 2002
>Closed-Date:    Sat Apr 26 00:15:32 PDT 2003
>Last-Modified:  Sat Apr 26 00:15:32 PDT 2003
>Originator:     Jeff Kletsky
>Release:        5.0-CURRENT 2002/03/16
>Organization:
SpotLife
>Environment:
FreeBSD .pn.wagsky.com 5.0-20020311-CURRENT FreeBSD 
5.0-20020311-CURRENT #0: Mon Mar 11 12:07:33 GMT 2002     
root@usw2.freebsd.org:/usr/src/sys/i386/compile/GENERIC  i386

>Description:
While compiling GENERIC after cvsup of today 16:13 PST and again at
18:23, there appears to be a problem with the type of 

sc->amr_drive[driveno].al_size not being an unsigned int in amr.c:

if ((bio->bio_pblkno + blkcount) > sc->amr_drive[driveno].al_size)
    device_printf(sc->amr_dev, "I/O beyond end of unit (%u,%d > %u)\n", 
                  bio->bio_pblkno, blkcount, sc->amr_drive[driveno].al_size)
;


(Sorry, couldn't track down where struct sc was declared)

***** Resolved with -DNO_WERROR


cc -c -O -pipe -Wall -Wredundant-decls -Wnested-externs
-Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline
-Wcast-qual -fformat-extensions -ansi -g -nostdinc -I-
-I. -I/usr/src/sys -I/usr/src/sys/dev
-I/usr/src/sys/contrib/dev/acpica -I/usr/src/sys/contrib/ipfilter
-I/usr/src/sys/../include -D_KERNEL -ffreestanding -include
opt_global.h -fno-common -elf -mpreferred-stack-boundary=2 -Werror
/usr/src/sys/dev/amr/amr.c

cc1: warnings being treated as errors
/usr/src/sys/dev/amr/amr.c: In function `amr_bio_command':
/usr/src/sys/dev/amr/amr.c:817: warning: unsigned int format,
different type arg (arg 3)
*** Error code 1

Stop in /usr/obj/usr/src/sys/GENERIC.

>How-To-Repeat:
cvsup the sources
make kernel
>Fix:
Workaround:

make -DNO_WERROR kernel
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->murray 
Responsible-Changed-By: murray 
Responsible-Changed-When: Thu Mar 28 02:34:33 PST 2002 
Responsible-Changed-Why:  
I will look into this.  I'm pretty sure it was fixed on the 18th. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=35993 
State-Changed-From-To: open->closed 
State-Changed-By: murray 
State-Changed-When: Sat Apr 26 00:15:10 PDT 2003 
State-Changed-Why:  
This was fixed a long time ago.  Sorry I neglected to close this PR at 
that time. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=35993 
>Unformatted:
