From thomas@cuivre.fr.eu.org  Thu Mar  7 10:13:10 2002
Return-Path: <thomas@cuivre.fr.eu.org>
Received: from melchior.cuivre.fr.eu.org (melchior.enst.fr [137.194.161.6])
	by hub.freebsd.org (Postfix) with ESMTP id 0623837B404
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  7 Mar 2002 10:13:09 -0800 (PST)
Received: from melusine.cuivre.fr.eu.org (melusine.enst.fr [137.194.160.34])
	by melchior.cuivre.fr.eu.org (Postfix) with ESMTP id 80F258571
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  7 Mar 2002 19:13:07 +0100 (CET)
Received: by melusine.cuivre.fr.eu.org (Postfix, from userid 1000)
	id BC4DF2C3D1; Thu,  7 Mar 2002 19:13:06 +0100 (CET)
Message-Id: <20020307181306.BC4DF2C3D1@melusine.cuivre.fr.eu.org>
Date: Thu,  7 Mar 2002 19:13:06 +0100 (CET)
From: Thomas Quinot <thomas@cuivre.fr.eu.org>
Reply-To: Thomas Quinot <thomas@cuivre.fr.eu.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [patch] missing dep in libiconv prevents parallel build
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         35635
>Category:       kern
>Synopsis:       [libiconv] [patch] missing dep in libiconv prevents parallel build
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Mar 07 10:20:01 PST 2002
>Closed-Date:    Fri Aug 11 23:56:44 GMT 2006
>Last-Modified:  Fri Aug 11 23:56:44 GMT 2006
>Originator:     Thomas Quinot
>Release:        FreeBSD 4.5-STABLE i386
>Organization:
>Environment:
System: FreeBSD melusine.cuivre.fr.eu.org 4.5-STABLE FreeBSD 4.5-STABLE #5: Mon Mar 4 23:09:53 CET 2002 root@melusine.cuivre.fr.eu.org:/usr2/obj/usr2/src/sys/MELUSINE i386


	
>Description:
	The latest -STABLE kernel won't build with -jN (N > 1);
	the build dies with the following messages:

===> libiconv
perl @/kern/makeobjops.pl -c @/libkern/iconv_converter_if.m
perl @/kern/makeobjops.pl -h @/libkern/iconv_converter_if.m
@ -> /usr/src/sys
Can't open perl script "@/kern/makeobjops.pl": No such file or directory
*** Error code 2

	(note the @ symlink is made /after/ the perl invocations.)
>How-To-Repeat:
	cvsup a fresh -STABLE
	make -j5 buildkernel
>Fix:

--- sys/modules/libiconv/Makefile.dist	Thu Mar  7 18:34:52 2002
+++ sys/modules/libiconv/Makefile	Thu Mar  7 18:34:59 2002
@@ -9,10 +9,10 @@
 SRCS+=	iconv_converter_if.c iconv_converter_if.h
 NOMAN=	true
 
-iconv_converter_if.h:
+iconv_converter_if.h: @
 	perl @/kern/makeobjops.pl -h @/libkern/iconv_converter_if.m
 
-iconv_converter_if.c:
+iconv_converter_if.c: @
 	perl @/kern/makeobjops.pl -c @/libkern/iconv_converter_if.m
 
 .include <bsd.kmod.mk>

>Release-Note:
>Audit-Trail:

From: Thomas Quinot <thomas@cuivre.fr.eu.org>
To: Bruce Evans <bde@zeta.org.au>
Cc: bug-followup@freebsd.org
Subject: Re: kern/35635: [patch] missing dep in libiconv prevents parallel build
Date: Fri, 8 Mar 2002 17:56:17 +0100

 Le 2002-03-08, Bruce Evans crivait :
 
 > The ugly explicit rules are required because the default rules use
 > @/kern/makeops.pl which generates slightly different files.  Perhaps
 > this should be fixed instead.
 
 Well, if I read makeops.pl correctly, all it does is check whether
 the file named on its command line contains the string KOBJ on the first
 line, and then call either makeobjops or makedevops depending on that.
 
 If '# KOBJ' is added as the first line of iconv_converter_if.m, then
 calling makeops produces exactly the same output as makeobjops,
 and therefore the explicit rules can be removed. Unfortunately,
 I do not know what other side effects that change to
 iconv_converter_if.m could have.
 
 Thomas.
 
 -- 
     Thomas.Quinot@Cuivre.FR.EU.ORG

From: Thomas Quinot <thomas@cuivre.fr.eu.org>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: kern/35635 revised patch (for -STABLE)
Date: Fri, 29 Mar 2002 09:30:15 +0100

 The following may be a better solution. Please review.
 
 diff -u sys/modules/libiconv/Makefile.dist sys/modules/libiconv/Makefile
 --- sys/modules/libiconv/Makefile.dist	Thu Mar  7 18:34:52 2002
 +++ sys/modules/libiconv/Makefile	Fri Mar 29 09:25:50 2002
 @@ -9,10 +9,4 @@
  SRCS+=	iconv_converter_if.c iconv_converter_if.h
  NOMAN=	true
  
 -iconv_converter_if.h:
 -	perl @/kern/makeobjops.pl -h @/libkern/iconv_converter_if.m
 -
 -iconv_converter_if.c:
 -	perl @/kern/makeobjops.pl -c @/libkern/iconv_converter_if.m
 -
  .include <bsd.kmod.mk>
 diff -u sys/libkern/iconv_converter_if.m.dist sys/libkern/iconv_converter_if.m
 --- sys/libkern/iconv_converter_if.m.dist	Fri Mar 29 09:26:10 2002
 +++ sys/libkern/iconv_converter_if.m	Fri Mar 29 09:26:58 2002
 @@ -1,3 +1,4 @@
 +# KOBJ
  #
  # Copyright (c) 2000-2001, Boris Popov
  # All rights reserved.
 
 -- 
     Thomas.Quinot@Cuivre.FR.EU.ORG
Responsible-Changed-From-To: freebsd-bugs->sheldonh 
Responsible-Changed-By: johan 
Responsible-Changed-When: Tue Apr 23 18:26:25 PDT 2002 
Responsible-Changed-Why:  
Over to Sheldon, who introduced the code. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=35635 

From: Sheldon Hearn <sheldonh@starjuice.net>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: kern/35635: [patch] missing dep in libiconv prevents parallel build 
Date: Fri, 10 May 2002 19:35:26 +0200

 On Tue, 23 Apr 2002 18:27:33 MST, johan@FreeBSD.org wrote:
 
 > Synopsis: [patch] missing dep in libiconv prevents parallel build
 > 
 > Responsible-Changed-From-To: freebsd-bugs->sheldonh
 > Responsible-Changed-By: johan
 > Responsible-Changed-When: Tue Apr 23 18:26:25 PDT 2002
 > Responsible-Changed-Why: 
 > 	Over to Sheldon, who introduced the code.
 
 I wasn't aware that parallel kernel builds are supposed to work.  Could
 someone confirm?
 
 Ciao,
 Sheldon.
Responsible-Changed-From-To: sheldonh->freebsd-bugs 
Responsible-Changed-By: sheldonh 
Responsible-Changed-When: Tue Feb 17 03:19:07 PST 2004 
Responsible-Changed-Why:  
Release. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=3170 
Responsible-Changed-From-To: sheldonh->freebsd-bugs 
Responsible-Changed-By: sheldonh 
Responsible-Changed-When: Tue Feb 17 03:19:07 PST 2004 
Responsible-Changed-Why:  
Release. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=26869 
Responsible-Changed-From-To: sheldonh->freebsd-bugs 
Responsible-Changed-By: sheldonh 
Responsible-Changed-When: Tue Feb 17 03:19:07 PST 2004 
Responsible-Changed-Why:  
Release. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=33672 
Responsible-Changed-From-To: sheldonh->freebsd-bugs 
Responsible-Changed-By: sheldonh 
Responsible-Changed-When: Tue Feb 17 03:19:07 PST 2004 
Responsible-Changed-Why:  
Release. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=23912 
Responsible-Changed-From-To: sheldonh->freebsd-bugs 
Responsible-Changed-By: sheldonh 
Responsible-Changed-When: Tue Feb 17 03:19:07 PST 2004 
Responsible-Changed-Why:  
Release. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=34316 
Responsible-Changed-From-To: sheldonh->freebsd-bugs 
Responsible-Changed-By: sheldonh 
Responsible-Changed-When: Tue Feb 17 03:19:07 PST 2004 
Responsible-Changed-Why:  
Release. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=34729 
Responsible-Changed-From-To: sheldonh->freebsd-bugs 
Responsible-Changed-By: sheldonh 
Responsible-Changed-When: Tue Feb 17 03:19:07 PST 2004 
Responsible-Changed-Why:  
Release. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=35635 
State-Changed-From-To: open->closed 
State-Changed-By: thomas 
State-Changed-When: Fri Aug 11 23:55:31 UTC 2006 
State-Changed-Why:  
It appears that the initially suggested fix was committed to RELENG_4: 
sys/modules/libiconv/Makefile       29 Jul 2002 07:24:19 -0000      1.1.2.2 

http://www.freebsd.org/cgi/query-pr.cgi?pr=35635 
>Unformatted:
