From lowell@be-well.no-ip.com  Tue Feb  5 04:59:48 2002
Return-Path: <lowell@be-well.no-ip.com>
Received: from chmls18.ne.ipsvc.net (chmls18.ne.ipsvc.net [24.147.1.153])
	by hub.freebsd.org (Postfix) with ESMTP id 398D637B421
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  5 Feb 2002 04:59:47 -0800 (PST)
Received: from be-well.ilk.org (lowellg.ne.mediaone.net [24.147.188.158])
	by chmls18.ne.ipsvc.net (8.11.6/8.11.6) with ESMTP id g15CxYG21717
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 5 Feb 2002 07:59:34 -0500 (EST)
Received: (from lowell@localhost)
	by be-well.ilk.org (8.11.6/8.11.4) id g15CxZS06254;
	Tue, 5 Feb 2002 07:59:35 -0500 (EST)
	(envelope-from lowell)
Message-Id: <200202051259.g15CxZS06254@be-well.ilk.org>
Date: Tue, 5 Feb 2002 07:59:35 -0500 (EST)
From: Lowell@world.std.com
Reply-To: Lowell@world.std.com
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: LINT is wrong -- NMBCLUSTERS doesn't auto-size if 0
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         34637
>Category:       kern
>Synopsis:       LINT is wrong -- NMBCLUSTERS doesn't auto-size if 0
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Feb 05 05:00:01 PST 2002
>Closed-Date:    Tue Oct 29 04:28:24 PST 2002
>Last-Modified:  Tue Oct 29 04:28:24 PST 2002
>Originator:     Lowell Gilbert
>Release:        FreeBSD 4.5-STABLE i386
>Organization:
>Environment:
System: FreeBSD lowellg.ne.mediaone.net 4.5-STABLE FreeBSD 4.5-STABLE #0: Tue Feb 5 02:06:02 EST 2002 root@lowellg.ne.mediaone.net:/usr/obj/usr/src/sys/BE-WELL i386



>Description:

LINT says that NMBCLUSTERS will autosize if set to zero.  It doesn't;
it only autosizes if not defined.

>How-To-Repeat:

[see LINT, compare to /sys/kern/uipc_mbuf.c]

	
>Fix:
[including a typo repair...]

*** LINT~	Tue Feb  5 07:40:44 2002
--- LINT	Tue Feb  5 07:41:07 2002
***************
*** 2376,2382 ****
  
  # Set the size of the mbuf KVM reservation, in clusters.  This is scaled
  # by approximately 2048 bytes.  The system will auto-size the mbuf area
! # if this options is not specified or set to 0.
  #
  options 	NMBCLUSTERS=1024
  
--- 2376,2382 ----
  
  # Set the size of the mbuf KVM reservation, in clusters.  This is scaled
  # by approximately 2048 bytes.  The system will auto-size the mbuf area
! # if this option is not specified.
  #
  options 	NMBCLUSTERS=1024
  



Another alternative would be to change /sys/kern/uipc_mbuf.c so that
it uses "#if !NMBCLUSTERS" instead of "#ifndef NMBCLUSTERS", but I
think the code is fine, and changing LINT to reflect it is the better
way to go.
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: maxim 
State-Changed-When: Tue Oct 29 04:27:02 PST 2002 
State-Changed-Why:  
Fixed in rev. 1.749.2.98 src/sys/i386/conf/LINT in -STABLE. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=34637 
>Unformatted:
