From michaelb@demon.net  Mon Feb  4 09:02:52 2002
Return-Path: <michaelb@demon.net>
Received: from internal.mail.demon.net (internal.mail.demon.net [193.195.224.3])
	by hub.freebsd.org (Postfix) with ESMTP id 233C137B429
	for <freebsd-gnats-submit@freebsd.org>; Mon,  4 Feb 2002 09:02:50 -0800 (PST)
Received: from singsing.eng.demon.net (singsing.eng.demon.net [194.217.90.11])
	by internal.mail.demon.net with ESMTP id g14H2jp11463;
	Mon, 4 Feb 2002 17:02:46 GMT
Received: from [194.217.90.12] (helo=[194.217.90.12])
	by singsing.eng.demon.net with esmtp (Exim 3.34 #1)
	id 16XmVx-0007d6-00; Mon, 04 Feb 2002 17:02:45 +0000
Message-Id: <B8846F38.27F6%michaelb@demon.net>
Date: Mon, 04 Feb 2002 17:02:46 +0000
From: Mike Bristow <michaelb@demon.net>
To: Archie Cobbs <archie@dellroad.org>,
	<freebsd-gnats-submit@freebsd.org>, <michaelb@thus.net>
In-Reply-To: <200202031903.g13J34L02548@arch20m.dellroad.org>
Subject: Re: Better patch

>Number:         34615
>Category:       kern
>Synopsis:       Re: Better patch
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    gnats-admin
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Feb 04 09:10:00 PST 2002
>Closed-Date:    Mon Feb 4 14:15:59 PST 2002
>Last-Modified:  Thu Oct 07 18:20:31 GMT 2004
>Originator:     
>Release:        
>Organization:
>Environment:
>Description:
 > This message is in MIME format. Since your mail reader does not understand
 this format, some or all of this message may not be legible.
 
 --B_3095686968_2834597
 Content-type: text/plain; charset="US-ASCII"
 Content-transfer-encoding: 7bit
 
 On 3/2/02 7:03 pm, "Archie Cobbs" <archie@dellroad.org> wrote:
 > Oops, the previous patch was completely bogus. Try this
 > one instead. Note: this is a patch against -current; the
 > -stable patch is similar.
 
 I thought of hardware checksumming when I spotted the capabilities change to
 ifconfig; I've just hacked out hwchecksum from if_xl.c and my problems have
 disappeared. 
 
 I'm now rebuilding with my evil hacks removed, and (I think) a -stable
 equivalent of your patch (attached; also at
 http://www.urgle.com/~mike/ng_ether.patch).  I'll let you know if my
 problems reappear with this patch.
 
 -- 
 Mike Bristow
 
 
 Sent using the Entourage X Test Drive.
 
 
 --B_3095686968_2834597
 Content-type: application/octet-stream; name="diff.out"
 Content-disposition: attachment
 Content-transfer-encoding: base64
 
 SW5kZXg6IG5nX2V0aGVyLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL3Vwc3RyZWFtLXJl
 cG9zaXRvcmllcy9mcmVlYnNkLm9yZy9zcmMvc3lzL25ldGdyYXBoL25nX2V0aGVyLmMsdgpy
 ZXRyaWV2aW5nIHJldmlzaW9uIDEuMi4yLjEwCmRpZmYgLXUgLXIxLjIuMi4xMCBuZ19ldGhl
 ci5jCi0tLSBuZ19ldGhlci5jCTIwMDEvMDkvMDEgMDg6MjI6MjkJMS4yLjIuMTAKKysrIG5n
 X2V0aGVyLmMJMjAwMi8wMi8wNCAxNjo1NTowNQpAQCAtNzUsNiArNzUsNyBAQAogCXVfY2hh
 cgkJbG93ZXJPcnBoYW47CS8qIHdoZXRoZXIgbG93ZXIgaXMgbG93ZXIgb3Igb3JwaGFuICov
 CiAJdV9jaGFyCQlhdXRvU3JjQWRkcjsJLyogYWx3YXlzIG92ZXJ3cml0ZSBzb3VyY2UgYWRk
 cmVzcyAqLwogCXVfY2hhcgkJcHJvbWlzYzsJLyogcHJvbWlzY3VvdXMgbW9kZSBlbmFibGVk
 ICovCisJdV9jaGFyCQlod2Fzc2lzdDsgICAgICAgLyogaGFyZHdhcmUgY2hlY2tzdW0gY2Fw
 YWJpbGl0aWVzICovCiB9OwogdHlwZWRlZiBzdHJ1Y3QgcHJpdmF0ZSAqcHJpdl9wOwogCkBA
 IC0zMTksNiArMzIwLDcgQEAKIAlwcml2LT5pZnAgPSBpZnA7CiAJSUZQMk5HKGlmcCkgPSBu
 b2RlOwogCXByaXYtPmF1dG9TcmNBZGRyID0gMTsKKwlwcml2LT5od2Fzc2lzdCA9IGlmcC0+
 aWZfaHdhc3Npc3Q7CiAKIAkvKiBUcnkgdG8gZ2l2ZSB0aGUgbm9kZSB0aGUgc2FtZSBuYW1l
 IGFzIHRoZSBpbnRlcmZhY2UgKi8KIAlpZiAobmdfbmFtZV9ub2RlKG5vZGUsIG5hbWUpICE9
 IDApIHsKQEAgLTQ3MCw2ICs0NzIsMTAgQEAKIAlpZiAoKmhvb2twdHIgIT0gTlVMTCkKIAkJ
 cmV0dXJuIChFSVNDT05OKTsKIAorCS8qIERpc2FibGUgaGFyZHdhcmUgY2hlY2tzdW1zIHdo
 aWxlICd1cHBlcicgaG9vayBpcyBjb25uZWN0ZWQgKi8KKwlpZiAoaG9va3B0ciA9PSAmcHJp
 di0+dXBwZXIpCisJCXByaXYtPmlmcC0+aWZfaHdhc3Npc3QgPSAwOworCiAJLyogT0sgKi8K
 IAkqaG9va3B0ciA9IGhvb2s7CiAJcHJpdi0+bG93ZXJPcnBoYW4gPSBvcnBoYW47CkBAIC02
 ODUsOSArNjkxLDEwIEBACiB7CiAJY29uc3QgcHJpdl9wIHByaXYgPSBob29rLT5ub2RlLT5w
 cml2YXRlOwogCi0JaWYgKGhvb2sgPT0gcHJpdi0+dXBwZXIpCisJaWYgKGhvb2sgPT0gcHJp
 di0+dXBwZXIpIHsKIAkJcHJpdi0+dXBwZXIgPSBOVUxMOwotCWVsc2UgaWYgKGhvb2sgPT0g
 cHJpdi0+bG93ZXIpIHsKKwkJcHJpdi0+aWZwLT5pZl9od2Fzc2lzdCA9IHByaXYtPmh3YXNz
 aXN0OworCX0gZWxzZSBpZiAoaG9vayA9PSBwcml2LT5sb3dlcikgewogCQlwcml2LT5sb3dl
 ciA9IE5VTEw7CiAJCXByaXYtPmxvd2VyT3JwaGFuID0gMDsKIAl9IGVsc2UK
 
 --B_3095686968_2834597--
 
 
>How-To-Repeat:
>Fix:
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: keramida 
State-Changed-When: Mon Feb 4 14:15:59 PST 2002 
State-Changed-Why:  
Misfiled PR.  This seems to be a followup to an existing PR, but I 
can't find which PR that could be.  Can you please post again, paying 
attention to add to the beginning of your "Subject:" header a 
reference to the PR you'r replying to?  Examples of valid references 
could be: 

Re: kern/23456: My subject goes here 
Re: docs/19359: Here is the fix. 


http://www.FreeBSD.org/cgi/query-pr.cgi?pr=34615 
>Unformatted:
