From marcus@shumai.marcuscom.com  Sun Jan  6 17:46:50 2002
Return-Path: <marcus@shumai.marcuscom.com>
Received: from shumai.marcuscom.com (rdu57-28-046.nc.rr.com [66.57.28.46])
	by hub.freebsd.org (Postfix) with ESMTP id D019137B402
	for <FreeBSD-gnats-submit@freebsd.org>; Sun,  6 Jan 2002 17:46:45 -0800 (PST)
Received: (from marcus@localhost)
	by shumai.marcuscom.com (8.11.6/8.11.6) id g071kkV07013;
	Sun, 6 Jan 2002 20:46:46 -0500 (EST)
	(envelope-from marcus)
Message-Id: <200201070146.g071kkV07013@shumai.marcuscom.com>
Date: Sun, 6 Jan 2002 20:46:46 -0500 (EST)
From: Joe Marcus Clarke <marcus@marcuscom.com>
Reply-To: Joe Marcus Clarke <marcus@marcuscom.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] Add KMODDEPS to smbfs to load libiconv and libmchain
X-Send-Pr-Version: 3.113
X-GNATS-Notify: ru

>Number:         33625
>Category:       kern
>Synopsis:       [PATCH] Add KMODDEPS to smbfs to load libiconv and libmchain
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    sheldonh
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jan 06 17:50:01 PST 2002
>Closed-Date:    Thu Jan 10 04:19:33 PST 2002
>Last-Modified:  Thu Jan 10 04:20:15 PST 2002
>Originator:     Joe Marcus Clarke
>Release:        FreeBSD 4.5-PRERELEASE i386
>Organization:
MarcusCom, Inc.
>Environment:
System: FreeBSD shumai.marcuscom.com 4.5-PRERELEASE FreeBSD 4.5-PRERELEASE #0: Sun Jan 6 01:07:48 EST 2002 marcus@shumai.marcuscom.com:/usr/obj/usr/src/sys/SHUMAI i386


	
>Description:
	When you kldload smbfs without kldload'ing libconv or libmchain, you get
the error:

Jan  6 18:22:02 shumai /kernel: link_elf: symbol iconv_open undefined

Or something having to do with a missing libmchain symbol.  Users that don't
know that libiconv or libmchain are needed, can get confused.  Instead, 
make smbfs depend on libiconv and libmchain.
>How-To-Repeat:
	# kldload smbfs

Without first loading libiconv or libmchain.
>Fix:
This patch is only really needed on -stable, since KMODDEPS isn't required
for -current(?)

--- sys/modules/smbfs/Makefile.orig	Sun Jan  6 20:41:48 2002
+++ sys/modules/smbfs/Makefile	Sun Jan  6 20:38:55 2002
@@ -7,6 +7,7 @@
 	${.CURDIR}/../../fs/smbfs
 
 KMOD=	smbfs
+KMODDEPS=	libiconv libmchain
 
 SRCS=	vnode_if.h \
 	opt_inet.h opt_ipx.h \

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->sheldonh 
Responsible-Changed-By: sheldonh 
Responsible-Changed-When: Wed Jan 9 03:39:02 PST 2002 
Responsible-Changed-Why:  
I'll take this one.  Looks like it'll fix PR bin/33016, which is 
already closed. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=33625 
State-Changed-From-To: open->analyzed 
State-Changed-By: sheldonh 
State-Changed-When: Wed Jan 9 03:58:24 PST 2002 
State-Changed-Why:  
Nice catch!  I'm waiting for the release engineers to approve 
my request to merge this change onto the RELENG_4 branch in 
time for 4.5-RELEASE. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=33625 

From: Sheldon Hearn <sheldonh@starjuice.net>
To: marcus@marcuscom.com
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: kern/33625: [PATCH] Add KMODDEPS to smbfs to load libiconv and libmchain 
Date: Wed, 09 Jan 2002 14:06:21 +0200

 On Wed, 09 Jan 2002 03:58:57 PST, sheldonh@FreeBSD.org wrote:
 
 > Nice catch!  I'm waiting for the release engineers to approve
 > my request to merge this change onto the RELENG_4 branch in
 > time for 4.5-RELEASE.
 
 The change went into HEAD as rev 1.2 of src/sys/modules/smbfs/Makefile,
 by the way.
 
 Ciao,
 Sheldon.
State-Changed-From-To: analyzed->closed 
State-Changed-By: sheldonh 
State-Changed-When: Thu Jan 10 04:19:33 PST 2002 
State-Changed-Why:  
Merged onto RELENG_4 as rev 1.1.2.3 in time for 4.5-RELEASE. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=33625 
>Unformatted:
