From jose@v-ger.we.lc.ehu.es  Tue Dec 18 16:07:34 2001
Return-Path: <jose@v-ger.we.lc.ehu.es>
Received: from polaris.we.lc.ehu.es (polaris.we.lc.ehu.es [158.227.6.43])
	by hub.freebsd.org (Postfix) with ESMTP id A2D3D37B417
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 18 Dec 2001 16:07:32 -0800 (PST)
Received: from v-ger.we.lc.ehu.es (lxpx236.lx.ehu.es [158.227.26.136])
	by polaris.we.lc.ehu.es (8.11.6/8.11.6) with ESMTP id fBJ07Tb29195
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 19 Dec 2001 01:07:29 +0100 (MET)
Received: (from jose@localhost)
	by v-ger.we.lc.ehu.es (8.11.6/8.11.6) id fBJ07cE05862;
	Wed, 19 Dec 2001 01:07:38 +0100 (CET)
	(envelope-from jose)
Message-Id: <200112190007.fBJ07cE05862@v-ger.we.lc.ehu.es>
Date: Wed, 19 Dec 2001 01:07:38 +0100 (CET)
From: "Jose M. Alcaide" <jose@we.lc.ehu.es>
Reply-To: "Jose M. Alcaide" <jose@we.lc.ehu.es>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: new em(4) driver breaks kernel build when only src-sys is present
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         32993
>Category:       kern
>Synopsis:       new em(4) driver breaks kernel build when only src-sys is present
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Dec 18 16:10:01 PST 2001
>Closed-Date:    Thu Dec 20 11:41:29 PST 2001
>Last-Modified:  Thu Dec 20 11:43:10 PST 2001
>Originator:     Jose M. Alcaide
>Release:        FreeBSD 4.4-STABLE i386
>Organization:
Universidad del Pais Vasco - Dept. de Electricidad y Electronica
>Environment:
FreeBSD haddock.we.lc.ehu.es 4.4-RELEASE FreeBSD 4.4-RELEASE #2: Sat Oct  6 20:43:56 CEST 2001     toor@haddock.we.lc.ehu.es:/usr/obj/usr/src/sys/HADDOCK  i386

>Description:

The recently committed em(4) driver breaks kernel compilation when only the
src-sys collection (AKA "kernel developer" distribution) is installed, since
sys/dev/if_em.h includes stddef.h.

>How-To-Repeat:

On any system with only src-base and src-sys collections installed:

# cd /usr/src
# make buildkernel
...
===> em
@ -> /usr/src/sys
machine -> /usr/src/sys/i386/include
perl @/kern/makeops.pl -h @/kern/device_if.m
perl @/kern/makeops.pl -h @/kern/bus_if.m
perl @/kern/makeops.pl -h @/pci/pci_if.m
touch opt_bdg.h
rm -f .depend
mkdep -f .depend -a   -nostdinc -D_KERNEL -DKLD_MODULE -I- -I. -I@ -I@/../include -I/usr/obj/usr/src/i386/usr/include  /usr/src/sys/modules/em/../../dev/em/if_em.c /usr/src/sys/modules/em/../../dev/em/if_em_fxhw.c /usr/src/sys/modules/em/../../dev/em/if_em_phy.c
In file included from /usr/src/sys/modules/em/../../dev/em/if_em.c:39:
@/dev/em/if_em.h:74: stddef.h: No such file or directory
In file included from @/dev/em/if_em_osdep.h:92,
                 from @/dev/em/if_em_fxhw.h:105,
                 from /usr/src/sys/modules/em/../../dev/em/if_em_fxhw.c:42:
@/dev/em/if_em.h:74: stddef.h: No such file or directory
In file included from @/dev/em/if_em_osdep.h:92,
                 from @/dev/em/if_em_fxhw.h:105,
                 from /usr/src/sys/modules/em/../../dev/em/if_em_phy.c:42:
@/dev/em/if_em.h:74: stddef.h: No such file or directory
mkdep: compile failed
*** Error code 1

Stop in /usr/src/sys/modules/em.

>Fix:

I don't know.
>Release-Note:
>Audit-Trail:

From: Brooks Davis <brooks@one-eyed-alien.net>
To: "Jose M. Alcaide" <jose@we.lc.ehu.es>
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: kern/32993: new em(4) driver breaks kernel build when only src-sys is present
Date: Tue, 18 Dec 2001 16:36:03 -0800

 On Wed, Dec 19, 2001 at 01:07:38AM +0100, Jose M. Alcaide wrote:
 > 
 > >Description:
 > 
 > The recently committed em(4) driver breaks kernel compilation when only the
 > src-sys collection (AKA "kernel developer" distribution) is installed, since
 > sys/dev/if_em.h includes stddef.h.
 > 
 > >Fix:
 > 
 > I don't know.
 
 At least in current just removing the line from if_em.h allows the
 module to compile without warnings which would indicate it's unused so
 just removing it would fix your problem.
 
 -- Brooks
State-Changed-From-To: open->closed 
State-Changed-By: pdeuskar 
State-Changed-When: Thu Dec 20 11:41:29 PST 2001 
State-Changed-Why:  
Removed unused stddef.h file from if_em.h. 
This was causing problems with compilation when only 
src-sys was present on the system. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=32993 
>Unformatted:
