From carl@slackerbsd.org  Sun Dec 16 13:36:37 2001
Return-Path: <carl@slackerbsd.org>
Received: from slackerbsd.org (cn488734-a.wall1.pa.home.com [65.9.18.254])
	by hub.freebsd.org (Postfix) with SMTP id 1F61C37B405
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 16 Dec 2001 13:36:37 -0800 (PST)
Received: (qmail 67948 invoked by uid 1000); 16 Dec 2001 21:36:34 -0000
Message-Id: <20011216213634.67947.qmail@slackerbsd.org>
Date: 16 Dec 2001 21:36:34 -0000
From: carl@slackerbsd.org
Reply-To: Carl Schmidt <carl@slackerbsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: options misssing TCBHASHSIZE
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         32912
>Category:       kern
>Synopsis:       options misssing TCBHASHSIZE
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bms
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Dec 16 13:40:01 PST 2001
>Closed-Date:    Wed Jun 23 09:14:10 GMT 2004
>Last-Modified:  Wed Jun 23 09:14:10 GMT 2004
>Originator:     Carl Schmidt
>Release:        FreeBSD 4.4-STABLE i386
>Organization:
>Environment:
System: FreeBSD Carbon.SlackerBSD.ORG 4.4-STABLE FreeBSD 4.4-STABLE #0: Thu Dec 13 19:42:50 EST 2001 root@Carbon.SlackerBSD.ORG:/usr/obj/usr/src/sys/CARBON i386

>Description:
/sys/conf/options is lacking TCBHASHSIZE and so is LINT.
This isn't really a sw-bug but i don't think misc or doc-bug would really be
appropriate either. Sorry (and correct me) if I'm wrong.

>How-To-Repeat:
grep TCBHASHSIZE /sys/netinet/tcp_subr.c
grep TCBHASHSIZE /sys/conf/options
grep TCBHASHSIZE /sys/i386/conf/LINT

>Fix:
--- options.old	Fri Nov  2 20:41:07 2001
+++ options	Sun Dec 16 16:03:20 2001
@@ -269,6 +269,7 @@
 PPP_FILTER		opt_ppp.h
 RANDOM_IP_ID
 SLIP_IFF_OPTS		opt_slip.h
+TCBHASHSIZE
 TCPDEBUG
 TCP_DROP_SYNFIN		opt_tcp_input.h
 XBONEHACK

--- LINT.old	Fri Dec 14 22:29:03 2001
+++ LINT	Sun Dec 16 16:35:39 2001
@@ -556,6 +556,10 @@
 # packets without touching the ttl).  This can be useful to hide firewalls
 # from traceroute and similar tools.
 #
+# TCBHASHSIZE is the target size of the TCP PCB (process control block) hash
+# tables.  This must be a power of 2.  The default is 512 (2^9). See tcp(4)
+# for more information.
+#
 # TCPDEBUG is undocumented.
 #
 options 	MROUTING		# Multicast routing
@@ -573,6 +577,7 @@
 options 	IPFILTER_LOG		#ipfilter logging
 options		IPFILTER_DEFAULT_BLOCK	#block all packets by default
 options 	IPSTEALTH		#support for stealth forwarding
+options		TCBHASHSIZE=512		#tcp pcb hash table size
 options 	TCPDEBUG
 
 # RANDOM_IP_ID causes the ID field in IP packets to be randomized
>Release-Note:
>Audit-Trail:

From: carl@slackerbsd.org
To: FreeBSD-gnats-submit@freebsd.org
Cc:  
Subject: Re: kern/32912: options misssing TCBHASHSIZE
Date: Sun, 16 Dec 2001 16:50:44 -0500

 On Sun, Dec 16, 2001 at 09:36:34PM -0000, Carl Schmidt wrote:
 > >Number:         32912
 > >Category:       kern
 > >Synopsis:       options misssing TCBHASHSIZE
 > >Confidential:   no
 > >Severity:       non-critical
 > >Priority:       low
 > >Responsible:    freebsd-bugs
 > >State:          open
 > >Quarter:        
 > >Keywords:       
 > >Date-Required:
 > >Class:          sw-bug
 > >Submitter-Id:   current-users
 > >Arrival-Date:   Sun Dec 16 13:40:01 PST 2001
 > >Closed-Date:
 > >Last-Modified:
 > >Originator:     Carl Schmidt
 > >Release:        FreeBSD 4.4-STABLE i386
 > >Organization:
 > >Environment:
 > System: FreeBSD Carbon.SlackerBSD.ORG 4.4-STABLE FreeBSD 4.4-STABLE #0: Thu Dec 13 19:42:50 EST 2001 root@Carbon.SlackerBSD.ORG:/usr/obj/usr/src/sys/CARBON i386
 > 
 > >Description:
 > /sys/conf/options is lacking TCBHASHSIZE and so is LINT.
 > This isn't really a sw-bug but i don't think misc or doc-bug would really be
 > appropriate either. Sorry (and correct me) if I'm wrong.
 > 
 > >How-To-Repeat:
 > grep TCBHASHSIZE /sys/netinet/tcp_subr.c
 > grep TCBHASHSIZE /sys/conf/options
 > grep TCBHASHSIZE /sys/i386/conf/LINT
 > 
 > >Fix:
 > --- options.old	Fri Nov  2 20:41:07 2001
 > +++ options	Sun Dec 16 16:03:20 2001
 > @@ -269,6 +269,7 @@
 >  PPP_FILTER		opt_ppp.h
 >  RANDOM_IP_ID
 >  SLIP_IFF_OPTS		opt_slip.h
 > +TCBHASHSIZE
 >  TCPDEBUG
 >  TCP_DROP_SYNFIN		opt_tcp_input.h
 >  XBONEHACK
 > 
 > --- LINT.old	Fri Dec 14 22:29:03 2001
 > +++ LINT	Sun Dec 16 16:35:39 2001
 > @@ -556,6 +556,10 @@
 >  # packets without touching the ttl).  This can be useful to hide firewalls
 >  # from traceroute and similar tools.
 >  #
 > +# TCBHASHSIZE is the target size of the TCP PCB (process control block) hash
 > +# tables.  This must be a power of 2.  The default is 512 (2^9). See tcp(4)
 > +# for more information.
 > +#
 >  # TCPDEBUG is undocumented.
 >  #
 >  options 	MROUTING		# Multicast routing
 > @@ -573,6 +577,7 @@
 >  options 	IPFILTER_LOG		#ipfilter logging
 >  options		IPFILTER_DEFAULT_BLOCK	#block all packets by default
 >  options 	IPSTEALTH		#support for stealth forwarding
 > +options		TCBHASHSIZE=512		#tcp pcb hash table size
 >  options 	TCPDEBUG
 >  
 >  # RANDOM_IP_ID causes the ID field in IP packets to be randomized
 > >Release-Note:
 > >Audit-Trail:
 > >Unformatted:
 
 Sorry about the formatting mistake and the spelling error in the synopsis.
 
 --- LINT.old	Fri Dec 14 22:29:03 2001
 +++ LINT	Sun Dec 16 16:35:39 2001
 @@ -556,6 +556,10 @@
  # packets without touching the ttl).  This can be useful to hide firewalls
  # from traceroute and similar tools.
  #
 +# TCBHASHSIZE is the target size of the TCP PCB (process control block) hash
 +# tables.  This must be a power of 2.  The default is 512 (2^9). See tcp(4)
 +# for more information.
 +#
  # TCPDEBUG is undocumented.
  #
  options 	MROUTING		# Multicast routing
 @@ -573,6 +577,7 @@
  options 	IPFILTER_LOG		#ipfilter logging
  options	IPFILTER_DEFAULT_BLOCK	#block all packets by default
  options 	IPSTEALTH		#support for stealth forwarding
 +options	TCBHASHSIZE=512		#tcp pcb hash table size
  options 	TCPDEBUG
  
  # RANDOM_IP_ID causes the ID field in IP packets to be randomized
 
 -- 
 Carl Schmidt
Responsible-Changed-From-To: freebsd-bugs->msmith 
Responsible-Changed-By: sheldonh 
Responsible-Changed-When: Sun Dec 30 05:34:47 PST 2001 
Responsible-Changed-Why:  
Mike made TCBHASHSIZE a compile-time tunable. 

Mike, if you don't have time for this, let me know and I'll do it 
myself. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=32912 
State-Changed-From-To: open->patched 
State-Changed-By: mp 
State-Changed-When: Sun Jul 7 19:54:13 PDT 2002 
State-Changed-Why:  
Patched -current and waiting to MFC. 


Responsible-Changed-From-To: msmith->mp 
Responsible-Changed-By: mp 
Responsible-Changed-When: Sun Jul 7 19:54:13 PDT 2002 
Responsible-Changed-Why:  
I'll take care of this one. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=32912 
State-Changed-From-To: patched->closed 
State-Changed-By: bms 
State-Changed-When: Wed Jun 23 09:11:24 GMT 2004 
State-Changed-Why:  
Kernel loader tunable net.inet.tcp.tcbhashsize now exists 


Responsible-Changed-From-To: mp->bms 
Responsible-Changed-By: bms 
Responsible-Changed-When: Wed Jun 23 09:11:24 GMT 2004 
Responsible-Changed-Why:  
I'll take this 

http://www.freebsd.org/cgi/query-pr.cgi?pr=32912 
>Unformatted:
