From marka@drugs.dv.isc.org  Sun Dec  2 14:41:51 2001
Return-Path: <marka@drugs.dv.isc.org>
Received: from drugs.dv.isc.org (drugs.dv.isc.org [130.155.191.236])
	by hub.freebsd.org (Postfix) with ESMTP id BC78637B41C
	for <FreeBSD-gnats-submit@freebsd.org>; Sun,  2 Dec 2001 14:41:48 -0800 (PST)
Received: (from root@localhost)
	by drugs.dv.isc.org (8.11.6/8.11.2) id fB2Mee134230;
	Mon, 3 Dec 2001 09:40:40 +1100 (EST)
	(envelope-from marka)
Message-Id: <200112022240.fB2Mee134230@drugs.dv.isc.org>
Date: Mon, 3 Dec 2001 09:40:40 +1100 (EST)
From: Mark Andrews <mark.andrews@isc.org>
Reply-To: Mark Andrews <mark.andrews@isc.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: redundant casts
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         32446
>Category:       kern
>Synopsis:       redundant casts
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    sumikawa
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Dec 02 14:50:01 PST 2001
>Closed-Date:    Tue Dec 25 14:22:46 JST 2001
>Last-Modified:  Tue Dec 25 14:23:36 JST 2001
>Originator:     Mark Andrews
>Release:        FreeBSD 4.4-STABLE i386
>Organization:
Internet Software Consortium
>Environment:
System: FreeBSD drugs.dv.isc.org 4.4-STABLE FreeBSD 4.4-STABLE #0: Tue Nov 13 19:04:45 EST 2001 marka@drugs.dv.isc.org:/usr/obj/usr/src/sys/DRUGS i386


>Description:
	redundant casts in sys/netinet6/in6.h
>How-To-Repeat:
	By inspection.
>Fix:

Index: sys/netinet6/in6.h
===================================================================
RCS file: /home/ncvs/src/sys/netinet6/in6.h,v
retrieving revision 1.7.2.4
diff -u -r1.7.2.4 in6.h
--- sys/netinet6/in6.h	2001/07/04 09:45:23	1.7.2.4
+++ sys/netinet6/in6.h	2001/12/02 22:33:53
@@ -250,37 +250,37 @@
  * Unspecified
  */
 #define IN6_IS_ADDR_UNSPECIFIED(a)	\
-	((*(const u_int32_t *)(const void *)(&(a)->s6_addr[0]) == 0) &&	\
-	 (*(const u_int32_t *)(const void *)(&(a)->s6_addr[4]) == 0) &&	\
-	 (*(const u_int32_t *)(const void *)(&(a)->s6_addr[8]) == 0) &&	\
-	 (*(const u_int32_t *)(const void *)(&(a)->s6_addr[12]) == 0))
+	((*(const u_int32_t *)(&(a)->s6_addr[0]) == 0) &&	\
+	 (*(const u_int32_t *)(&(a)->s6_addr[4]) == 0) &&	\
+	 (*(const u_int32_t *)(&(a)->s6_addr[8]) == 0) &&	\
+	 (*(const u_int32_t *)(&(a)->s6_addr[12]) == 0))
 
 /*
  * Loopback
  */
 #define IN6_IS_ADDR_LOOPBACK(a)		\
-	((*(const u_int32_t *)(const void *)(&(a)->s6_addr[0]) == 0) &&	\
-	 (*(const u_int32_t *)(const void *)(&(a)->s6_addr[4]) == 0) &&	\
-	 (*(const u_int32_t *)(const void *)(&(a)->s6_addr[8]) == 0) &&	\
-	 (*(const u_int32_t *)(const void *)(&(a)->s6_addr[12]) == ntohl(1)))
+	((*(const u_int32_t *)(&(a)->s6_addr[0]) == 0) &&	\
+	 (*(const u_int32_t *)(&(a)->s6_addr[4]) == 0) &&	\
+	 (*(const u_int32_t *)(&(a)->s6_addr[8]) == 0) &&	\
+	 (*(const u_int32_t *)(&(a)->s6_addr[12]) == ntohl(1)))
 
 /*
  * IPv4 compatible
  */
 #define IN6_IS_ADDR_V4COMPAT(a)		\
-	((*(const u_int32_t *)(const void *)(&(a)->s6_addr[0]) == 0) &&	\
-	 (*(const u_int32_t *)(const void *)(&(a)->s6_addr[4]) == 0) &&	\
-	 (*(const u_int32_t *)(const void *)(&(a)->s6_addr[8]) == 0) &&	\
-	 (*(const u_int32_t *)(const void *)(&(a)->s6_addr[12]) != 0) &&	\
-	 (*(const u_int32_t *)(const void *)(&(a)->s6_addr[12]) != ntohl(1)))
+	((*(const u_int32_t *)(&(a)->s6_addr[0]) == 0) &&	\
+	 (*(const u_int32_t *)(&(a)->s6_addr[4]) == 0) &&	\
+	 (*(const u_int32_t *)(&(a)->s6_addr[8]) == 0) &&	\
+	 (*(const u_int32_t *)(&(a)->s6_addr[12]) != 0) &&	\
+	 (*(const u_int32_t *)(&(a)->s6_addr[12]) != ntohl(1)))
 
 /*
  * Mapped
  */
 #define IN6_IS_ADDR_V4MAPPED(a)		      \
-	((*(const u_int32_t *)(const void *)(&(a)->s6_addr[0]) == 0) &&	\
-	 (*(const u_int32_t *)(const void *)(&(a)->s6_addr[4]) == 0) &&	\
-	 (*(const u_int32_t *)(const void *)(&(a)->s6_addr[8]) == ntohl(0x0000ffff)))
+	((*(const u_int32_t *)(&(a)->s6_addr[0]) == 0) &&	\
+	 (*(const u_int32_t *)(&(a)->s6_addr[4]) == 0) &&	\
+	 (*(const u_int32_t *)(&(a)->s6_addr[8]) == ntohl(0x0000ffff)))
 
 /*
  * KAME Scope Values
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: sumikawa 
State-Changed-When: Tue Dec 18 02:17:48 JST 2001 
State-Changed-Why:  
This is for supressing lint warning.  Could I close this PR? 


Responsible-Changed-From-To: freebsd-bugs->sumikawa 
Responsible-Changed-By: sumikawa 
Responsible-Changed-When: Tue Dec 18 02:17:48 JST 2001 
Responsible-Changed-Why:  
I'll handle this. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=32446 
State-Changed-From-To: feedback->closed 
State-Changed-By: sumikawa 
State-Changed-When: Tue Dec 25 14:22:46 JST 2001 
State-Changed-Why:  
No response from originator. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=32446 
>Unformatted:
