From nobody@FreeBSD.org  Wed Oct 31 13:05:04 2001
Return-Path: <nobody@FreeBSD.org>
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 3D0AD37B403
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 31 Oct 2001 13:05:04 -0800 (PST)
Received: (from nobody@localhost)
	by freefall.freebsd.org (8.11.4/8.11.4) id f9VL54n77082;
	Wed, 31 Oct 2001 13:05:04 -0800 (PST)
	(envelope-from nobody)
Message-Id: <200110312105.f9VL54n77082@freefall.freebsd.org>
Date: Wed, 31 Oct 2001 13:05:04 -0800 (PST)
From: "Aaron D. Gifford" <agifford@infowest.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Build-stopping bug in sys/dev/ata/ata-all.c -STABLE
X-Send-Pr-Version: www-1.0

>Number:         31672
>Category:       kern
>Synopsis:       Build-stopping bug in sys/dev/ata/ata-all.c -STABLE
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Oct 31 13:10:02 PST 2001
>Closed-Date:    Thu Nov 1 01:59:57 PST 2001
>Last-Modified:  Thu Nov 01 02:00:43 PST 2001
>Originator:     Aaron D. Gifford
>Release:        FreeBSD-STABLE as of 24 Oct. 2001 (but the bug applies to -STABLE as of today, 31 Oct. 2001)
>Organization:
>Environment:
FreeBSD my.host 4.4-STABLE FreeBSD 4.4-STABLE #4: Wed Oct 24 08:37:24 MDT 2001 root@my.host:/usr/obj/usr/src/sys/MYCONF i386 --- BUT the bug applies to -STABLE as of today (31 Oct. 2001)
>Description:
In the file /usr/src/sys/dev/ata/ata-all.c at line 259 and line 266, there are duplicate switch/case entries that cause buildkernel to fail.  Here's a snippet from the file (line 258 to 267 - note the identical entries on 259 and 266):

    case 0x71998086:
    case 0x84ca8086:
        return "Intel PIIX4 ATA33 controller";

    case 0x24218086:
        return "Intel ICH0 ATA33 controller";

    case 0x24118086:
    case 0x84ca8086:
        return "Intel ICH ATA66 controller";


>How-To-Repeat:
Try building a -STABLE kernel with ATA support today (31 Oct. 2001).
>Fix:
Remove one of the offending duplicates.  I don't know which one is the correct one and which one is a typo, so I'll leave that to those wise in the realm of ATA drivers.
>Release-Note:
>Audit-Trail:

From: Aaron D.Gifford <agifford@infowest.com>
To: freebsd-gnats-submit@FreeBSD.org, agifford@infowest.com
Cc:  
Subject: Re: kern/31672: Build-stopping bug in sys/dev/ata/ata-all.c -STABLE
Date: Wed, 31 Oct 2001 15:16:21 -0700

 Go ahead and close this PR.  It has been fixed.
 
 From CVS WEB (see 
 http://www.FreeBSD.org/cgi/cvsweb.cgi/src/sys/dev/ata/ata-all.c) I read:
 -----------------------
  Revision 1.50.2.23 / (download) - annotate - [select for diffs], Wed Oct 
 31 18:58:09 2001 UTC (3 hours, 10 minutes ago) by asmodai 
 Branch: RELENG_4 
 Changes since 1.50.2.22: +1 -1 lines
 
 Fix result of pasting wrong buffer, this changes a MFC'd ID to the
 correct one.
 
 Notified of by: Michal Mertl <mime@traveller.cz>
 ---------------------
 
 
 Thank you for catching the typo, Michal Mertl and for fixing it quickly, 
 asmodai!
 
 Aaron Gifford
State-Changed-From-To: open->closed 
State-Changed-By: dwmalone 
State-Changed-When: Thu Nov 1 01:59:57 PST 2001 
State-Changed-Why:  
Fixed by asmodai. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=31672 
>Unformatted:
