From nobody@FreeBSD.org  Sat Oct 13 05:19:21 2001
Return-Path: <nobody@FreeBSD.org>
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id DE5A437B401
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 13 Oct 2001 05:19:20 -0700 (PDT)
Received: (from nobody@localhost)
	by freefall.freebsd.org (8.11.4/8.11.4) id f9DCJKe02942;
	Sat, 13 Oct 2001 05:19:20 -0700 (PDT)
	(envelope-from nobody)
Message-Id: <200110131219.f9DCJKe02942@freefall.freebsd.org>
Date: Sat, 13 Oct 2001 05:19:20 -0700 (PDT)
From: Bryan Liesner <bleez@bellatlantic.net>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Cannot mount an Olympus D-370 camera as a umass device
X-Send-Pr-Version: www-1.0
X-GNATS-Notify: iedowse

>Number:         31250
>Category:       kern
>Synopsis:       Cannot mount an Olympus D-370 camera as a umass device
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    n_hibma
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Oct 13 05:20:01 PDT 2001
>Closed-Date:    Wed Dec 12 10:11:48 PST 2001
>Last-Modified:  Wed Dec 12 10:12:47 PST 2001
>Originator:     Bryan Liesner
>Release:        4.4-stable
>Organization:
>Environment:
FreeBSD gravy.kishka.net 4.4-STABLE FreeBSD 4.4-STABLE #0: Sat Oct 13 07:43:42 EDT 2001     bryan@gravy.kishka.net:/usr/src/sys/compile/GRAVY  i386

>Description:
This applies to an Olympus D-370 digital camera with storage class usb.

After compiling a kernel with scbus, da, pass, and umass support, mount_msdos /dev/da0s1 /mnt gives the following result:
Oct 13 07:50:18 gravy /kernel: (da0:umass-sim0:0:0:0): READ(06). CDB: 8 0 0 0 1
Oct 13 07:50:18 gravy /kernel: (da0:umass-sim0:0:0:0): ILLEGAL REQUEST asc:20,0
Oct 13 07:50:18 gravy /kernel: (da0:umass-sim0:0:0:0): Invalid command operation
Oct 13 07:50:18 gravy /kernel: da0: reading primary partition table: error reading fsbn 0
~



>How-To-Repeat:
Try to mount the camera as described above
>Fix:
Apply this patch:

--- /usr/src/sys/cam/scsi/scsi_da.c Mon Sep 24 11:23:55 2001
+++ scsi_da.c   Sat Oct 13 07:29:06 2001
@@ -243,12 +243,20 @@
         * do not support READ_6 commands, only READ_10.
         */
        {T_DIRECT, SIP_MEDIA_REMOVABLE, "Sony", "Sony DSC", "*"},
        /*quirks*/ DA_Q_NO_6_BYTE|DA_Q_NO_SYNC_CACHE
    },
    {
+       /*
+        * Olympus D series cameras do not support READ_6
+        * commands
+        */
+       {T_DIRECT, SIP_MEDIA_REMOVABLE, "OLYMPUS", "D*", "*"},
+       /*quirks*/ DA_Q_NO_6_BYTE
+   },
+   {
        {T_OPTICAL, SIP_MEDIA_REMOVABLE, "FUJITSU", "MCF3064AP", "*"},
        /*quirks*/ DA_Q_NO_6_BYTE
    }
 };

 static d_open_t    daopen;


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->n_hibma 
Responsible-Changed-By: n_hibma 
Responsible-Changed-When: Tue Oct 23 16:13:32 PDT 2001 
Responsible-Changed-Why:  
USB is my turf. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=31250 
State-Changed-From-To: open->feedback 
State-Changed-By: iedowse 
State-Changed-When: Sun Dec 9 13:38:42 PST 2001 
State-Changed-Why:  

Committed to -CURRENT, thanks! Note that I used a pattern of "D-*" 
instead of the "D*" in your patch, so as to match the other quirks. 
Can you confirm that this pattern is suitable for your camera? You 
didn't include any umass/da probe messages in the bug report. 

I'll merge the change into -stable after I get confirmation from 
you that the D-* pattern is OK. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=31250 
State-Changed-From-To: feedback->closed 
State-Changed-By: iedowse 
State-Changed-When: Wed Dec 12 10:11:48 PST 2001 
State-Changed-Why:  

Fixed in both -current and -stable now. Thanks! 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=31250 
>Unformatted:
