From nobody@FreeBSD.org  Tue Aug  7 15:49:52 2001
Return-Path: <nobody@FreeBSD.org>
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 0F09137B40A
	for <freebsd-gnats-submit@FreeBSD.org>; Tue,  7 Aug 2001 15:49:48 -0700 (PDT)
	(envelope-from nobody@FreeBSD.org)
Received: (from nobody@localhost)
	by freefall.freebsd.org (8.11.4/8.11.4) id f77Mnlu78809;
	Tue, 7 Aug 2001 15:49:47 -0700 (PDT)
	(envelope-from nobody)
Message-Id: <200108072249.f77Mnlu78809@freefall.freebsd.org>
Date: Tue, 7 Aug 2001 15:49:47 -0700 (PDT)
From: Artem Belevich <art@src.cx>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Enable tagged ATA for IBM 60GXP HDD (IC35L0[12346]0AVER07)
X-Send-Pr-Version: www-1.0

>Number:         29520
>Category:       kern
>Synopsis:       Enable tagged ATA for IBM 60GXP HDD (IC35L0[12346]0AVER07)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    sos
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          wish
>Submitter-Id:   current-users
>Arrival-Date:   Tue Aug 07 15:50:01 PDT 2001
>Closed-Date:    Thu Sep 6 01:53:47 PDT 2001
>Last-Modified:  Thu Sep 06 01:54:31 PDT 2001
>Originator:     Artem Belevich
>Release:        4.4-PRERELEASE
>Organization:
>Environment:
FreeBSD ego.yagosys.com 4.4-PRERELEASE FreeBSD 4.4-PRERELEASE #2: Fri Aug  3 12:35:09 PDT 2001     root@ego.yagosys.com:/usr/src/sys/compile/ART  i386

>Description:
According to http://www.storage.ibm.com/hdd/desk/ds60gxp.htm 
IBM 60GXP HDD has support for tagged ATA commands. At this moment FreeBSD only enables tagged ATA commands for IBM-DPTA* and IBM-DTLA* (34GXP,37GP,40GV,75GXP) drives. 60GXP has different IDE model identifier and therefore FreeBSD does not enable tagged ATA support for the drive.


>How-To-Repeat:
/boot/loader.conf: hw.ata.tags="1"
Reboot machine. 
#dmesg | grep ad0
ad0: 39266MB <IC35L040AVER07-0> [79780/16/63] at ata0-master UDMA33

Should be:
ad0: 39266MB <IC35L040AVER07-0> [79780/16/63] at ata0-master tagged UDMA33


>Fix:
dev/ata/ata-disk.c:
static int
ad_tagsupported(struct ad_softc *adp)
{
-    const char *drives[] = {"IBM-DPTA", "IBM-DTLA", NULL};
+    const char *drives[] = {"IBM-DPTA", "IBM-DTLA", "IC35L0", NULL};

    int i = 0;

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->sos 
Responsible-Changed-By: roam 
Responsible-Changed-When: Wed Aug 8 00:43:21 PDT 2001 
Responsible-Changed-Why:  
Over to our ATA codebase maintainer. 
Soren, this one looks both simple and promising :) 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=29520 
State-Changed-From-To: open->closed 
State-Changed-By: sos 
State-Changed-When: Thu Sep 6 01:53:47 PDT 2001 
State-Changed-Why:  
Support for this has been added both to -current and -stable. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=29520 
>Unformatted:
