From ccsanady@nyx.pr.mcs.net  Wed Mar  5 09:24:40 1997
Received: from nyx.pr.mcs.net (nyx.pr.mcs.net [204.95.55.81])
          by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id JAA28248
          for <FreeBSD-gnats-submit@freebsd.org>; Wed, 5 Mar 1997 09:24:38 -0800 (PST)
Received: (from ccsanady@localhost)
          by nyx.pr.mcs.net (8.8.5/8.8.4)
	  id LAA01295; Wed, 5 Mar 1997 11:13:23 -0600 (CST)
Message-Id: <199703051713.LAA01295@nyx.pr.mcs.net>
Date: Wed, 5 Mar 1997 11:13:23 -0600 (CST)
From: Chris Csanady <ccsanady@nyx.pr.mcs.net>
Reply-To: ccsanady@nyx.pr.mcs.net
To: FreeBSD-gnats-submit@freebsd.org
Subject: mbuf leak in multicast code
X-Send-Pr-Version: 3.2

>Number:         2886
>Category:       kern
>Synopsis:       mbuf leak in multicast code
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    fenner
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Mar  5 09:30:01 PST 1997
>Closed-Date:    Mon Jan 18 23:49:37 PST 1999
>Last-Modified:  Mon Jan 18 23:49:53 PST 1999
>Originator:     Chris Csanady
>Release:        FreeBSD 3.0-CURRENT i386
>Organization:
>Environment:

	

>Description:
The function ip_getmoptions() in ip_output.c alocates an mbuf for the
return of options, but does not dealocate it if it does not succeed.
	

>How-To-Repeat:
Call ip_getmoptions() with an invalid option.
	

>Fix:
*** ip_output.c.old	Fri Feb 28 16:36:11 1997
--- ip_output.c	Wed Mar  5 10:53:04 1997
***************
*** 1256,1261 ****
--- 1256,1262 ----
  		return (0);
  
  	default:
+ 		m_freem(*mp);
  		return (EOPNOTSUPP);
  	}
  }
	

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: gnats-admin->freebsd-bugs 
Responsible-Changed-By: gpalmer 
Responsible-Changed-When: Wed Mar 5 10:13:38 PST 1997 
Responsible-Changed-Why:  
Misfiled PR 
Responsible-Changed-From-To: freebsd-bugs->fenner 
Responsible-Changed-By: fenner 
Responsible-Changed-When: Sun Mar 9 08:28:53 PST 1997 
Responsible-Changed-Why:  
fenner is Mr. Multicast 
State-Changed-From-To: open->closed 
State-Changed-By: fenner 
State-Changed-When: Mon Jan 18 23:49:37 PST 1999 
State-Changed-Why:  
Fixed by the new socket option architecture. 
>Unformatted:
