From nobody@FreeBSD.org  Sat Jun  2 23:52:54 2001
Return-Path: <nobody@FreeBSD.org>
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id F0FCD37B424
	for <freebsd-gnats-submit@FreeBSD.org>; Sat,  2 Jun 2001 23:52:52 -0700 (PDT)
	(envelope-from nobody@FreeBSD.org)
Received: (from nobody@localhost)
	by freefall.freebsd.org (8.11.1/8.11.1) id f536qqs21669;
	Sat, 2 Jun 2001 23:52:52 -0700 (PDT)
	(envelope-from nobody)
Message-Id: <200106030652.f536qqs21669@freefall.freebsd.org>
Date: Sat, 2 Jun 2001 23:52:52 -0700 (PDT)
From: horape@compendium.com.ar
To: freebsd-gnats-submit@FreeBSD.org
Subject: gif interfaces don't have IFF_RUNNING flag bit set.
X-Send-Pr-Version: www-1.0

>Number:         27851
>Category:       kern
>Synopsis:       gif interfaces don't have IFF_RUNNING flag bit set.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    yar
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jun 03 00:00:13 PDT 2001
>Closed-Date:    Thu Jun 7 06:09:58 PDT 2001
>Last-Modified:  Thu Jun 07 06:10:48 PDT 2001
>Originator:     Horacio J. Pea
>Release:        4.2-RELEASE
>Organization:
Compendium
>Environment:
FreeBSD ipv6-gw.puntoar.net.ar 4.2-RELEASE FreeBSD 4.2-RELEASE #2: Mon Apr 23 19:11:14 ART 2001     root@ipv6-gw.puntoar.net.ar:/usr/src/sys/compile/IPV6.PUNTOAR.NET.AR  i386
>Description:
gif interfaces don't have IFF_RUNNING flag bit set, it probably should.

net-snmp maps IFF_RUNNING to ifAdminStatus. Since FBSD don't set
IFF_RUNNING on gif interfaces it looks like they're ifconfig'ed down.
>How-To-Repeat:
'ifconfig gifN' on any working gif interface
>Fix:
--- sys/net/if_gif.c.orig       Sun Jun  3 03:50:43 2001
+++ sys/net/if_gif.c    Sun Jun  3 03:50:57 2001
@@ -537,7 +537,7 @@
                bcopy((caddr_t)dst, (caddr_t)sa, size);
                sc->gif_pdst = sa;

-               ifp->if_flags |= IFF_UP;
+               ifp->if_flags |= IFF_UP | IFF_RUNNING;
                if_up(ifp);             /* send up RTM_IFINFO */

                error = 0;
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->analyzed 
State-Changed-By: yar 
State-Changed-When: Sun Jun 3 10:31:36 PDT 2001 
State-Changed-Why:  
Thanx, fixed in -current. 


Responsible-Changed-From-To: freebsd-bugs->yar 
Responsible-Changed-By: yar 
Responsible-Changed-When: Sun Jun 3 10:31:36 PDT 2001 
Responsible-Changed-Why:  
So I won't forget to MFC the fix. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=27851 
State-Changed-From-To: analyzed->closed 
State-Changed-By: yar 
State-Changed-When: Thu Jun 7 06:09:58 PDT 2001 
State-Changed-Why:  
Fixed in -current and -stable, thanx! 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=27851 
>Unformatted:
