From dan@xkulesh.vol.cz  Wed May 23 13:48:34 2001
Return-Path: <dan@xkulesh.vol.cz>
Received: from xkulesh.vol.cz (xkulesh.vol.cz [195.250.154.106])
	by hub.freebsd.org (Postfix) with ESMTP id 3179E37B43E
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 23 May 2001 13:48:31 -0700 (PDT)
	(envelope-from dan@xkulesh.vol.cz)
Received: (from root@localhost)
	by xkulesh.vol.cz (8.11.3/8.11.3) id f4NKmL000775;
	Wed, 23 May 2001 22:48:21 +0200 (CEST)
	(envelope-from dan)
Message-Id: <200105232048.f4NKmL000775@xkulesh.vol.cz>
Date: Wed, 23 May 2001 22:48:21 +0200 (CEST)
From: dan@obluda.cz
Reply-To: dan@obluda.cz
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: SMB complain about SMP
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         27598
>Category:       kern
>Synopsis:       netsmb can't be kldloaded in SMP environment
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed May 23 13:50:01 PDT 2001
>Closed-Date:    Wed May 30 02:07:11 PDT 2001
>Last-Modified:  Wed May 30 02:09:55 PDT 2001
>Originator:     Dan Lukes
>Release:        FreeBSD 4.3-STABLE i386
>Organization:
Obludarium
>Environment:
System: FreeBSD xkulesh.vol.cz 4.3-STABLE FreeBSD 4.3-STABLE #18: Wed May 23 21:18:28 CEST 2001 dan@xkulesh.vol.cz:/usr/src/sys/compile/Dan i386

        SMP hardware, SMP kernel, LIBICONV compiled in kernel,
        kldloaded libmchain

        STABLE CVSUPped od May 22

>Description:
        when I use kldload smbfs, the following messages appear on console:
---------
error: module compiled without SMP support
netsmb_dev: unloaded
module_register_init: MOD_LOAD (dev_netsmb, c0c251a0, 0) error 1
error: module compiled without SMP support
---------

        despite of it, smbfs is loaded

>How-To-Repeat:
	see environment and description
>Fix:

	I'm not sure about correct fix, because I'm not sure if netsmb
and/or smbfs is SMP sensitive and SMP ready.

        sys/netsmb/smb_dev.c call the smb_checksmp() which is implemented
        in sys/netsmb/smb_subr.c
        smb_subr.c use SMP variable (#define), but doesn't #include
opt_global.h where SMP is defined

	No file in sys/netsmb nor sys/fs/smbfs seems to contain a SMP specific
code other than (ever failing) test (there are no code using number of CPU's
nor ifdef-ed with SMP variable).

	So, there are three posibilities:
1. netsmb/smbfs isn't SMP sensitive 
  - lets completelly remove redundant test
2. netsmp/smbfs is SMP sensitive, but not SMP ready 
  - lets change error message to something more true
3. netsmp/smbfs is SMB sensitive and is SMP ready (and I miss something)
  - lets include opt_global.h to (at least) smb_subr.c 
  it give chance to test to work properly

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: bp 
State-Changed-When: Wed May 30 02:07:11 PDT 2001 
State-Changed-Why:  
-stable does not provide mechanims to build SMP safe KLDs. To work with smbfs 
on SMP machine one have to compile it in the kernel. 
Bug in the KLD subsystem is unrelated and will be fixed separately. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=27598 
>Unformatted:
