From thomas@cuivre.fr.eu.org  Tue May  8 13:37:10 2001
Return-Path: <thomas@cuivre.fr.eu.org>
Received: from melusine.cuivre.fr.eu.org (ppp58-net1-idf3-bas1.isdnet.net [195.154.52.58])
	by hub.freebsd.org (Postfix) with ESMTP id 3428F37B422
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  8 May 2001 13:37:06 -0700 (PDT)
	(envelope-from thomas@cuivre.fr.eu.org)
Received: by melusine.cuivre.fr.eu.org (Postfix, from userid 1000)
	id C72C624D03; Tue,  8 May 2001 22:37:03 +0200 (CEST)
Message-Id: <20010508203703.C72C624D03@melusine.cuivre.fr.eu.org>
Date: Tue,  8 May 2001 22:37:03 +0200 (CEST)
From: thomas@cuivre.fr.eu.org
Reply-To: thomas@cuivre.fr.eu.org
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Suspicious variable hiding in acdioctl
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         27213
>Category:       kern
>Synopsis:       Suspicious variable hiding in acdioctl
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    sos
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue May 08 13:40:00 PDT 2001
>Closed-Date:    Wed May 9 05:13:51 PDT 2001
>Last-Modified:  Wed May 09 06:03:28 PDT 2001
>Originator:     Thomas Quinot
>Release:        FreeBSD 4.3-STABLE i386
>Organization:
>Environment:
System: FreeBSD melusine.cuivre.fr.eu.org 4.3-STABLE FreeBSD 4.3-STABLE #2: Tue May 1 20:28:53 CEST 2001 thomas@melusine.cuivre.fr.eu.org:/usr/obj/usr/src/sys/MELUSINE i386


	
>Description:
	In the CDIOCREADAUDIO case of acdioctl, a new variable
	"error" is declared which hides the declaration at the
	top of acdioctl. Consequently, 0 is always returned instead
	of the value set within the case.

>How-To-Repeat:
	
>Fix:

--- sys/dev/ata/atapi-cd.c.dist	Tue May  8 22:32:45 2001
+++ sys/dev/ata/atapi-cd.c	Tue May  8 22:33:09 2001
@@ -836,7 +836,7 @@
 	    int32_t lba;
 	    caddr_t buffer, ubuf = args->buffer;
 	    int8_t ccb[16];
-	    int frames, error = 0;
+	    int frames;
 
 	    if (!cdp->toc.hdr.ending_track) {
 		error = EIO;
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->sos 
Responsible-Changed-By: dwmalone 
Responsible-Changed-When: Wed May 9 03:14:27 PDT 2001 
Responsible-Changed-Why:  
Looks like one for Soren. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=27213 
State-Changed-From-To: open->closed 
State-Changed-By: sos 
State-Changed-When: Wed May 9 05:13:51 PDT 2001 
State-Changed-Why:  

Fixed in -current, MFC will follow later. 

BTW, the CDIOCREADAUDIO ioctl is deprecated, its no longer needed 
for reading oddsector sizes, this can be done via the normal 
read routines. 


http://www.FreeBSD.org/cgi/query-pr.cgi?pr=27213 
>Unformatted:
