From nobody@FreeBSD.org  Mon Mar 19 16:35:50 2001
Return-Path: <nobody@FreeBSD.org>
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 8DF7437B729
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 19 Mar 2001 16:34:26 -0800 (PST)
	(envelope-from nobody@FreeBSD.org)
Received: (from nobody@localhost)
	by freefall.freebsd.org (8.11.1/8.11.1) id f2K0YQU26430;
	Mon, 19 Mar 2001 16:34:26 -0800 (PST)
	(envelope-from nobody)
Message-Id: <200103200034.f2K0YQU26430@freefall.freebsd.org>
Date: Mon, 19 Mar 2001 16:34:26 -0800 (PST)
From: davidx@viasoft.com.cn
To: freebsd-gnats-submit@FreeBSD.org
Subject: possible memory leak in /sys/kern/kern_proc.c
X-Send-Pr-Version: www-1.0

>Number:         25932
>Category:       kern
>Synopsis:       possible memory leak in /sys/kern/kern_proc.c
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    dwmalone
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Mar 19 16:40:01 PST 2001
>Closed-Date:    Tue May 1 08:01:14 PDT 2001
>Last-Modified:  Tue May 01 08:02:12 PDT 2001
>Originator:     David Xu
>Release:        FreeBSD 4.3-BETA
>Organization:
Viasoft
>Environment:
FreeBSD davidbsd.viasoft.com.cn 4.3-BETA FreeBSD 4.3-BETA #0: Mon Mar 19 10:55:5
7 CST 2001     root@davidbsd.viasoft.com.cn:/usr/obj/usr/src/sys/xu  i386
>Description:
a possible memory leak exists in /sys/kern/kern_proc.c, in function 
enterpgrp(), before returns ESRCH, it does not free pre-allocated pgrp,
hope I am not making a mistake.

>How-To-Repeat:

>Fix:
a patch is available:

--- kern_proc.c.orig    Tue Mar 20 08:22:37 2001
+++ kern_proc.c Tue Mar 20 08:22:57 2001
@@ -157,10 +157,10 @@
         */
        KASSERT(p->p_pid == pgid,
            ("enterpgrp: new pgrp and pid != pgid"));
-       MALLOC(pgrp, struct pgrp *, sizeof(struct pgrp), M_PGRP,
-           M_WAITOK);
        if ((np = pfind(savepid)) == NULL || np != p)
            return (ESRCH);
+       MALLOC(pgrp, struct pgrp *, sizeof(struct pgrp), M_PGRP,
+           M_WAITOK);
        if (mksess) {
            register struct session *sess;
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->dwmalone 
Responsible-Changed-By: dwmalone 
Responsible-Changed-When: Fri Mar 23 12:11:02 PST 2001 
Responsible-Changed-Why:  
I'll test the patch in -current and commit it all going well. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=25932 

From: David Malone <dwmalone@maths.tcd.ie>
To: davidx@viasoft.com.cn
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: kern/25932: possible memory leak in /sys/kern/kern_proc.c
Date: Fri, 23 Mar 2001 20:10:34 +0000

 On Mon, Mar 19, 2001 at 04:34:26PM -0800, davidx@viasoft.com.cn wrote:
 
 > --- kern_proc.c.orig    Tue Mar 20 08:22:37 2001
 > +++ kern_proc.c Tue Mar 20 08:22:57 2001
 > @@ -157,10 +157,10 @@
 >          */
 >         KASSERT(p->p_pid == pgid,
 >             ("enterpgrp: new pgrp and pid != pgid"));
 > -       MALLOC(pgrp, struct pgrp *, sizeof(struct pgrp), M_PGRP,
 > -           M_WAITOK);
 >         if ((np = pfind(savepid)) == NULL || np != p)
 >             return (ESRCH);
 > +       MALLOC(pgrp, struct pgrp *, sizeof(struct pgrp), M_PGRP,
 > +           M_WAITOK);
 >         if (mksess) {
 >             register struct session *sess;
 
 A similar bug seems to be present in -current. I'll test your fix
 and then commit it there.
 
 	David.
State-Changed-From-To: open->closed 
State-Changed-By: dwmalone 
State-Changed-When: Tue May 1 08:01:14 PDT 2001 
State-Changed-Why:  
Patch committed to -current and -stable. Thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=25932 
>Unformatted:
