From pa@bigblue.cdg.chalmers.se  Mon Mar 12 03:37:33 2001
Return-Path: <pa@bigblue.cdg.chalmers.se>
Received: from bigblue.cdg.chalmers.se (bigblue.cdg.chalmers.se [129.16.12.19])
	by hub.freebsd.org (Postfix) with ESMTP id 4BEA937B719
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 12 Mar 2001 03:37:32 -0800 (PST)
	(envelope-from pa@bigblue.cdg.chalmers.se)
Received: (from pa@localhost)
	by bigblue.cdg.chalmers.se (8.11.3/8.11.3) id f2CBbNw36522;
	Mon, 12 Mar 2001 12:37:23 +0100 (CET)
	(envelope-from pa)
Message-Id: <200103121137.f2CBbNw36522@bigblue.cdg.chalmers.se>
Date: Mon, 12 Mar 2001 12:37:23 +0100 (CET)
From: pa@cdg.chalmers.se
Reply-To: pa@cdg.chalmers.se
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: smbus error reporting
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         25733
>Category:       kern
>Synopsis:       [intpm] mismatch between error reporting in smbus framework and intpm driver
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    avg
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Mar 12 03:40:00 PST 2001
>Closed-Date:    Wed Apr 25 07:33:02 UTC 2012
>Last-Modified:  Wed Apr 25 07:33:02 UTC 2012
>Originator:     Per Andersson
>Release:        FreeBSD 4.3-BETA i386
>Organization:
Chalmers 
>Environment:
System: FreeBSD bigblue.cdg.chalmers.se 4.3-BETA FreeBSD 4.3-BETA #9: Fri Mar 9 14:42:33 CET 2001 root@bigblue.cdg.chalmers.se:/usr/src/sys/compile/BIGBLUEG i386


>Description:
	smbus_quick, smbus_sendb, smbus_recvb, smbus_writeb, smbus_writew, smbus_readb, smbus_readw, smbus_pcall, smbus_bwrite, smbus_bread expects SMB_E????
	but the intpm counterparts return ordinary E????

>How-To-Repeat:
	Inspect code
>Fix:

>Release-Note:
>Audit-Trail:

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/25733: commit references a PR
Date: Sun,  8 Apr 2012 20:48:48 +0000 (UTC)

 Author: avg
 Date: Sun Apr  8 20:48:39 2012
 New Revision: 234043
 URL: http://svn.freebsd.org/changeset/base/234043
 
 Log:
   intpm: return only SMB bus error codes from SMB methods
   
   PR:		kern/25733
   MFC after:	5 days
 
 Modified:
   head/sys/pci/intpm.c
 
 Modified: head/sys/pci/intpm.c
 ==============================================================================
 --- head/sys/pci/intpm.c	Sun Apr  8 20:44:57 2012	(r234042)
 +++ head/sys/pci/intpm.c	Sun Apr  8 20:48:39 2012	(r234043)
 @@ -272,7 +272,7 @@ intsmb_callback(device_t dev, int index,
  	case SMB_RELEASE_BUS:
  		break;
  	default:
 -		error = EINVAL;
 +		error = SMB_EINVAL;
  	}
  
  	return (error);
 @@ -519,7 +519,7 @@ intsmb_quick(device_t dev, u_char slave,
  		data |= LSB;
  		break;
  	default:
 -		return (EINVAL);
 +		return (SMB_EINVAL);
  	}
  
  	INTSMB_LOCK(sc);
 @@ -774,7 +774,7 @@ intsmb_bread(device_t dev, u_char slave,
  			}
  			*count = nread;
  		} else
 -			error = EIO;
 +			error = SMB_EBUSERR;
  	}
  	INTSMB_UNLOCK(sc);
  	return (error);
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
Responsible-Changed-From-To: freebsd-bugs->avg 
Responsible-Changed-By: avg 
Responsible-Changed-When: Sun Apr 8 20:54:36 UTC 2012 
Responsible-Changed-Why:  
Take. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=25733 
State-Changed-From-To: open->patched 
State-Changed-By: avg 
State-Changed-When: Mon Apr 16 12:08:58 UTC 2012 
State-Changed-Why:  
A patch is committed to head. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=25733 
State-Changed-From-To: patched->closed 
State-Changed-By: avg 
State-Changed-When: Wed Apr 25 07:32:32 UTC 2012 
State-Changed-Why:  
The fix is merged to all supported branches. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=25733 
>Unformatted:
