From nobody@FreeBSD.org  Sun Dec 10 22:40:16 2000
Return-Path: <nobody@FreeBSD.org>
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 4A92E37B699
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 10 Dec 2000 22:40:11 -0800 (PST)
Received: (from nobody@localhost)
	by freefall.freebsd.org (8.11.1/8.11.1) id eBB6eBZ26190;
	Sun, 10 Dec 2000 22:40:11 -0800 (PST)
	(envelope-from nobody)
Message-Id: <200012110640.eBB6eBZ26190@freefall.freebsd.org>
Date: Sun, 10 Dec 2000 22:40:11 -0800 (PST)
From: yasu@mrit.mei.co.jp
Sender: nobody@FreeBSD.org
To: freebsd-gnats-submit@FreeBSD.org
Subject: typeo in kern_sig.c
X-Send-Pr-Version: www-1.0

>Number:         23457
>Category:       kern
>Synopsis:       typeo in kern_sig.c
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    marcel
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Dec 10 22:50:00 PST 2000
>Closed-Date:    Wed Dec 27 23:26:27 PST 2000
>Last-Modified:  Wed Dec 27 23:29:35 PST 2000
>Originator:     Yasuhiko Watanabe
>Release:        4.1-STABLE
>Organization:
Matsushita Research Institute Tokyo, Inc.
>Environment:
>Description:
kern_sig.c was fully rewritten due to new sigset_t types around Sep. 1999. (between rev 1.64 to 1.65) There seems suspicous typo in trapsignal().

-	mask = sigmask(signum);
-	if ((p->p_flag & P_TRACED) == 0 && (p->p_sigcatch & mask) != 0 &&
-	    (p->p_sigmask & mask) == 0) {
+	if ((p->p_flag & P_TRACED) == 0 && SIGISMEMBER(p->p_sigcatch, sig) &&
+	    SIGISMEMBER(p->p_sigmask, sig)) {
 		p->p_stats->p_ru.ru_nsignals++;
I guess the last condition in if statement should be !SIGMEMBER(p->p_sigmask, sig) instead of SIGMEMBER(p->p_sigmask, sig)


>How-To-Repeat:

>Fix:
need a ! before the last SIGMEMBER()


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->marcel 
Responsible-Changed-By: johan 
Responsible-Changed-When: Sat Dec 16 08:09:31 PST 2000 
Responsible-Changed-Why:  
Marcel made the change back in 1999. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=23457 
State-Changed-From-To: open->closed 
State-Changed-By: peter 
State-Changed-When: Wed Dec 27 23:26:27 PST 2000 
State-Changed-Why:  
Fixed in kern_sig.c rev 1.97 and 1.72.2.4 

http://www.freebsd.org/cgi/query-pr.cgi?pr=23457 
>Unformatted:
