From darrenr@FreeBSD.org  Sun Aug 13 01:01:07 2000
Return-Path: <darrenr@FreeBSD.org>
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
	by hub.freebsd.org (Postfix) with ESMTP id 795B937B565
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 13 Aug 2000 01:01:07 -0700 (PDT)
	(envelope-from darrenr@FreeBSD.org)
Received: (from darrenr@localhost)
	by freefall.freebsd.org (8.9.3/8.9.2) id BAA97790;
	Sun, 13 Aug 2000 01:01:07 -0700 (PDT)
	(envelope-from darrenr@FreeBSD.org)
Message-Id: <200008130801.BAA97790@freefall.freebsd.org>
Date: Sun, 13 Aug 2000 01:01:07 -0700 (PDT)
From: <darrenr@FreeBSD.org>
Reply-To: darrenr@FreeBSD.org
To: FreeBSD-gnats-submit@freebsd.org
Subject: options COMPAT_43 is not optional?
X-Send-Pr-Version: 3.2

>Number:         20572
>Category:       kern
>Synopsis:       cannot safely remove COMPAT_43 from the kernel config
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    andre
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Aug 13 01:10:00 PDT 2000
>Closed-Date:    Sat Dec 27 07:21:28 PST 2003
>Last-Modified:  Sat Dec 27 07:21:28 PST 2003
>Originator:     Darren Reed
>Release:        FreeBSD 5.0-CURRENT
>Organization:
FreeBSD
>Environment:


>Description:

	Creating and attempting to build a kernel config without the
COMPAT_43 option present leads to the kernel failling to build when it
reaches /sys/kern/kern_sig.c:
cc -c -O -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes  -Wmissing
-prototypes -Wpointer-arith -Winline -Wcast-qual  -fformat-extensions -ansi  -no
stdinc -I- -I. -I../.. -I/usr/include  -D_KERNEL -include opt_global.h -elf  -mp
referred-stack-boundary=2  ../../kern/kern_sig.c
../../kern/kern_sig.c:359: warning: function declaration isn't a prototype
../../kern/kern_sig.c: In function `osigaction':
../../kern/kern_sig.c:367: dereferencing pointer to incomplete type
../../kern/kern_sig.c:367: dereferencing pointer to incomplete type
../../kern/kern_sig.c:369: dereferencing pointer to incomplete type
../../kern/kern_sig.c:370: dereferencing pointer to incomplete type
../../kern/kern_sig.c:372: dereferencing pointer to incomplete type
../../kern/kern_sig.c:379: dereferencing pointer to incomplete type
../../kern/kern_sig.c:384: dereferencing pointer to incomplete type
../../kern/kern_sig.c: At top level:
../../kern/kern_sig.c:532: warning: function declaration isn't a prototype
../../kern/kern_sig.c: In function `osigprocmask':     
../../kern/kern_sig.c:538: dereferencing pointer to incomplete type
../../kern/kern_sig.c:539: dereferencing pointer to incomplete type
../../kern/kern_sig.c: At top level:
../../kern/kern_sig.c:567: warning: function declaration isn't a prototype      
../../kern/kern_sig.c:721: warning: function declaration isn't a prototype      
../../kern/kern_sig.c: In function `osigsuspend':
../../kern/kern_sig.c:729: dereferencing pointer to incomplete type
*** Error code 1 (continuing)

>How-To-Repeat:

	Generate a kernel config without COMPAT_43 and attempt to compile it.

>Fix:

	


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: sheldonh 
State-Changed-When: Mon Aug 14 03:30:07 PDT 2000 
State-Changed-Why:  
That's why the option is marked with "[KEEP THIS!]" in GENERIC and 
"You probably do NOT want to remove this as much current code still 
relies on the 4.3 emulation." in NOTES. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=20572 
State-Changed-From-To: closed->open 
State-Changed-By: darrenr 
State-Changed-When: Mon Aug 14 03:58:43 PDT 2000 
State-Changed-Why:  
This was prematurely closed by the person answering it as the problem has 
not been fixed.  If "COMPAT_43" is not optional then it needs to no longer 
be an option.  If it is to remain an option then compile problems which 
occur when it is excluded need to be fixed.  Until one of these two routes 
is taken, this PR should remain open. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=20572 

From: Sheldon Hearn <sheldonh@uunet.co.za>
To: Darren Reed <darrenr@reed.wattle.id.au>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: kern/20572: cannot safely remove COMPAT_43 from the kernel config 
Date: Mon, 14 Aug 2000 14:06:04 +0200

 On Mon, 14 Aug 2000 21:56:51 +1000, Darren Reed wrote:
 
 > I think the email from Mike (just recently) explained the situation - there
 > has been a "problem" created by changes to the signal code.
 
 If that's all that's standing in the way of COMPAT_43 becoming
 optional, then you should assign the PR to marcel, who'll probably have
 it sorted out in short order.
 
 I must admit, my impression was that this would take a lot of work to
 fix and that it wasn't a simple case of correcting one area of the
 kernel.
 
 Ciao,
 Sheldon.
 
Responsible-Changed-From-To: freebsd-bugs->marcel 
Responsible-Changed-By: sheldonh 
Responsible-Changed-When: Mon Aug 14 05:29:57 PDT 2000 
Responsible-Changed-Why:  
Marcel, could you take a look at this, now that you're 
"back on board". 
? :-) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=20572 

From: Mike Pritchard <mpp@mppsystems.com>
To: Darren Reed <darrenr@reed.wattle.id.au>
Cc: Sheldon Hearn <sheldonh@uunet.co.za>, darrenr@FreeBSD.ORG,
	freebsd-bugs@FreeBSD.ORG
Subject: Re: kern/20572: cannot safely remove COMPAT_43 from the kernel config
Date: Mon, 14 Aug 2000 07:17:18 -0500

 Since the message I replied to wasn't the one attached to this PR,
 I'll briefly re-state my point, so that it makes it into the PR history:
 
 It used to be possible to compile and run a kernel without having
 COMPAT_43 defined.  The last major signal change broke this.
 Someone was supposed to be working on resolving this, but I think
 it fell through the cracks, since it has been quite a while
 since that signal change.  I can try and dig up more info 
 if anyone wants (I may still have some of the e-mail archived).
 
 -Mike
 
 On Mon, Aug 14, 2000 at 09:56:51PM +1000, Darren Reed wrote:
 > I think the email from Mike (just recently) explained the situation - there
 > has been a "problem" created by changes to the signal code.
 > 
 > In some email I received from Sheldon Hearn, sie wrote:
 > > 
 > > 
 > > On Mon, 14 Aug 2000 04:01:00 MST, darrenr@FreeBSD.ORG wrote:
 > > 
 > > > Until one of these two routes is taken, this PR should remain open.
 > > 
 > > Darren, please decide which of the 3 options I outlined works best for
 > > you.
 > > 
 > > Ciao,
 > > Sheldon.
 -- 
 Mike Pritchard
 mpp@FreeBSD.org or mpp@mppsystems.com
 
 
State-Changed-From-To: open->closed 
State-Changed-By: andre 
State-Changed-When: Sat Dec 27 07:19:57 PST 2003 
State-Changed-Why:  
This PR is idle for too long.  I can compile 5.2RC2-i386 
without COMPAT_43 in the kernel config. 


Responsible-Changed-From-To: marcel->andre 
Responsible-Changed-By: andre 
Responsible-Changed-When: Sat Dec 27 07:19:57 PST 2003 
Responsible-Changed-Why:  
This PR is idle for too long.  I can compile 5.2RC2-i386 
without COMPAT_43 in the kernel config. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=20572 
>Unformatted:
