From andre.albsmeier@mchp.siemens.de  Tue Aug  1 12:11:37 2000
Return-Path: <andre.albsmeier@mchp.siemens.de>
Received: from david.siemens.de (david.siemens.de [192.35.17.14])
	by hub.freebsd.org (Postfix) with ESMTP id A4DC737BA22
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  1 Aug 2000 12:11:36 -0700 (PDT)
	(envelope-from andre.albsmeier@mchp.siemens.de)
Received: from mail1.siemens.de (mail1.siemens.de [139.23.33.14])
	by david.siemens.de (8.10.1/8.10.1) with ESMTP id e71JBZ612214
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 1 Aug 2000 21:11:35 +0200 (MET DST)
Received: from curry.mchp.siemens.de (curry.mchp.siemens.de [139.25.42.7])
	by mail1.siemens.de (8.10.1/8.10.1) with ESMTP id e71JBZ122981
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 1 Aug 2000 21:11:35 +0200 (MET DST)
Received: (from localhost)
	by curry.mchp.siemens.de (8.10.2/8.10.2) id e71JBZa33543
	for FreeBSD-gnats-submit@freebsd.org; Tue, 1 Aug 2000 21:11:35 +0200 (CEST)
Message-Id: <200008011911.e71JBTv00816@curry.mchp.siemens.de>
Date: Tue, 1 Aug 2000 21:11:29 +0200 (CEST)
From: Andre Albsmeier <andre.albsmeier@mchp.siemens.de>
To: FreeBSD-gnats-submit@freebsd.org
Subject: patch for "fd" is usurping "fd" ...
X-Send-Pr-Version: 3.2

>Number:         20348
>Category:       kern
>Synopsis:       patch for "fd" is usurping "fd" ...
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    n_hibma
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Aug 01 12:20:00 PDT 2000
>Closed-Date:    Sun Aug 13 13:29:30 PDT 2000
>Last-Modified:  Sun Aug 13 13:30:01 PDT 2000
>Originator:     Andre Albsmeier
>Release:        FreeBSD 4.1-STABLE i386
>Organization:
>Environment:

FreeBSD 4.1-STABLE

>Description:

When using two floppy drives, dmesg tells us

>How-To-Repeat:

Attach two floppies to a 4.1-STABLE machine and boot.

>Fix:

Thanks to the hint from Poul-Henning Kamp <phk@critter.freebsd.dk>,
 the problem could be solved easily:

--- sys/isa/fd.c.ORI	Mon Jul 31 09:38:59 2000
+++ sys/isa/fd.c	Mon Jul 31 09:41:11 2000
@@ -1048,10 +1048,14 @@
 	int	typemynor;
 	int	typesize;
 #endif
+	static char cdevsw_add_done = 0;
 
 	fd = device_get_softc(dev);
 
-	cdevsw_add(&fd_cdevsw);	/* XXX */
+	if (!cdevsw_add_done) {
+		cdevsw_add(&fd_cdevsw);	/* XXX */
+		cdevsw_add_done++;
+	}
 	make_dev(&fd_cdevsw, (fd->fdu << 6),
 		UID_ROOT, GID_OPERATOR, 0640, "rfd%d", fd->fdu);
 


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->peter 
Responsible-Changed-By: sheldonh 
Responsible-Changed-When: Wed Aug 2 01:17:16 PDT 2000 
Responsible-Changed-Why:  
Peter originally introduced the use of cdevsw_add() here as a 
temporary solution. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=20348 
State-Changed-From-To: open->analyzed 
State-Changed-By: n_hibma 
State-Changed-When: Wed Aug 9 05:45:54 PDT 2000 
State-Changed-Why:  
Remind me to close this patch. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=20348 
Responsible-Changed-From-To: peter->n_hibma 
Responsible-Changed-By: n_hibma 
Responsible-Changed-When: Wed Aug 9 05:46:22 PDT 2000 
Responsible-Changed-Why:  
Remind _me_ to close this PR once its backported.:wq 

http://www.freebsd.org/cgi/query-pr.cgi?pr=20348 
State-Changed-From-To: analyzed->closed 
State-Changed-By: n_hibma 
State-Changed-When: Sun Aug 13 13:29:30 PDT 2000 
State-Changed-Why:  
Fix committed to both stable and current. Thanks!. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=20348 
>Unformatted:
 >WARNING: "fd" is usurping "fd"'s cdevsw[]
 >WARNING: "fd" is usurping "fd"'s bmaj
 
 
