From nobody@FreeBSD.ORG  Sat Jul 29 19:18:14 2000
Return-Path: <nobody@FreeBSD.ORG>
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id EC0DB37B735; Sat, 29 Jul 2000 19:18:14 -0700 (PDT)
Message-Id: <20000730021814.EC0DB37B735@hub.freebsd.org>
Date: Sat, 29 Jul 2000 19:18:14 -0700 (PDT)
From: george.russell@clara.net
Sender: nobody@FreeBSD.ORG
To: freebsd-gnats-submit@FreeBSD.org
Subject: matcd driver is a) not in GENERIC and b) broken
X-Send-Pr-Version: www-1.0

>Number:         20296
>Category:       kern
>Synopsis:       matcd driver is a) not in GENERIC and b) broken
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    sheldonh
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jul 29 19:20:01 PDT 2000
>Closed-Date:    Mon May 28 14:19:44 PDT 2001
>Last-Modified:  Mon May 28 14:19:56 PDT 2001
>Originator:     George Russell
>Release:        4.0
>Organization:
>Environment:
>Description:
The matcd driver for Matsushita CR 562/3 CD roms drives is claimed as 
supported. Two things - you can't install from it - GENERIC does not
support it. The driver is also broken. A fix is available here as a 
gzipped c code file, not a patch. Its from 4.0 Stable, so use patch 
against that. I don't have the unmodified version anymore, so I  
cannot make a patch from it.
>How-To-Repeat:
I note the 4.1 release notes still claims support - I have recieved no update on my
previous pr about the driver.
>Fix:
http://www.george.russell.clara.net/matcd.c.gz is a fixed version of the driver.
Tested on one machine, and works again for audio and data.

>Release-Note:
>Audit-Trail:

From: Bill Fumerola <billf@chimesnet.com>
To: george.russell@clara.net
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: kern/20296: matcd driver is a) not in GENERIC and b) broken
Date: Sun, 30 Jul 2000 02:07:28 -0400

 On Sat, Jul 29, 2000 at 07:18:14PM -0700, george.russell@clara.net wrote:
 > 
 > >Number:         20296
 > >Category:       kern
 > >Synopsis:       matcd driver is a) not in GENERIC and b) broken
 
 The reason it's not in GENERIC is _because_ it is broken.
 
 -- 
 Bill Fumerola - Network Architect, BOFH / Chimes, Inc.
                 billf@chimesnet.com / billf@FreeBSD.org
 
 
 
 

From: GeorgE Russell <george.russell@clara.net>
To: Bill Fumerola <billf@chimesnet.com>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: kern/20296: matcd driver is a) not in GENERIC and b) broken
Date: Sun, 30 Jul 2000 14:32:00 +0100

 Bill Fumerola wrote:
 > 
 > On Sat, Jul 29, 2000 at 07:18:14PM -0700, george.russell@clara.net wrote:
 > >
 > > >Number:         20296
 > > >Category:       kern
 > > >Synopsis:       matcd driver is a) not in GENERIC and b) broken
 > 
 > The reason it's not in GENERIC is _because_ it is broken.
 
 Great. I thought it was removed for space reasons.
 
 Download a fixed version for 4.0 stable from
 http://www.george.russell.clara.net/matcd.c.gz
 
 George Russell
 (does this mean it'll go back into stable, and say in 4.2 I could
 actually install without copying XXXMb of files to a disk partition?
 Good)
 
State-Changed-From-To: open->feedback 
State-Changed-By: sheldonh 
State-Changed-When: Mon Jul 31 05:45:34 PDT 2000 
State-Changed-Why:  
Before anyone looks at your alternative matcd.c, could you 
let us know whether the patch in PR kern/17605 works for you? 
See http://www.ferebsd.org/cgi/query-pr.cgi?17605 . 

http://www.freebsd.org/cgi/query-pr.cgi?pr=20296 

From: Sheldon Hearn <sheldonh@uunet.co.za>
To: GeorgE Russell <george.russell@clara.net>
Cc:  
Subject: Re: kern/20296: matcd driver is a) not in GENERIC and b) broken 
Date: Mon, 14 Aug 2000 14:51:39 +0200

 On Thu, 10 Aug 2000 21:53:57 +0100, GeorgE Russell wrote:
 
 > Not for me it doesn't work, unfortunately.
 > Sorry for taking so long to reply.
 
 No problem.  I'm looking at your patch, and it appears to be against an
 older revision of matcd.c.  Could you produce a patch against rev 1.54
 instead?
 
 Ciao,
 Sheldon.
 

From: Sheldon Hearn <sheldonh@uunet.co.za>
To: GeorgE Russell <george.russell@clara.net>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: kern/20296: matcd driver is a) not in GENERIC and b) broken 
Date: Wed, 16 Aug 2000 16:45:45 +0200

 On Mon, 14 Aug 2000 18:27:02 +0100, GeorgE Russell wrote:
 
 > OTOH, if you could describe the steps needed to get that revision from
 > web cvs and update / patch my version, then I can do that, if you think
 > that revision will work with 4.0
 
 By the way, what does your version actually do, other than replace
 matcdc with matcd?  I tried diffing what you've got with what's in
 CURRENT and that's all I could see, in amongst the noise of the
 COMPAT_ISA shim stuff and the buf -> bio changes.
 
 Ciao,
 Sheldon.
 

From: "Paul A. Scott" <pscott@the-frontier.org>
To: <freebsd-gnats-submit@FreeBSD.org>, <george.russell@clara.net>
Cc:  
Subject: Re: kern/20296: matcd driver is a) not in GENERIC and b) broken
Date: Tue, 22 Aug 2000 22:49:57 -0700

 I tried to install the 4.1 release off CDROM and the fix was still not
 applied. But after installing from the 'Net (thank the deity I have a FAST
 DSL line), I applied the patch, recompiled, and all's right with the world.
 
 The patch from <a
 href="http://www.freebsd.org/cgi/query-pr.cgi?pr=17605">kern/17605</a> also
 works on FreeBSD 4.1 without modification. It's an obvious typo, both in the
 code and the author's comment <20>.
 
 Will someone please put this fix into the 4.x branch? There are still some
 of us who use that antiquated device!
 
 Paul A. Scott
 mailto:pscott@the-frontier.org
 http://www.the-frontier.org/pscott/
 
 
State-Changed-From-To: feedback->open 
State-Changed-By: sheldonh 
State-Changed-When: Wed Aug 23 02:16:31 PDT 2000 
State-Changed-Why:  
Feedback acquired. 


Responsible-Changed-From-To: freebsd-bugs->sheldonh 
Responsible-Changed-By: sheldonh 
Responsible-Changed-When: Wed Aug 23 02:16:31 PDT 2000 
Responsible-Changed-Why:  
I'll take this one. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=20296 
State-Changed-From-To: open->feedback 
State-Changed-By: sheldonh 
State-Changed-When: Wed Aug 23 02:43:42 PDT 2000 
State-Changed-Why:  
Committed to HEAD and merged onto RELENG_4 as rev 1.49.2.1 
of matcd.c. 

Please confirm that this works again. :-) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=20296 

From: "Kristian Hansen" <kristian.hansen@post.tele.dk>
To: <freebsd-gnats-submit@FreeBSD.org>, <george.russell@clara.net>
Cc:  
Subject: Re: kern/20296: matcd driver is a) not in GENERIC and b) broken
Date: Fri, 22 Sep 2000 14:37:26 +0200

 This is a multi-part message in MIME format.
 
 ------=_NextPart_000_0075_01C024A2.A0DACE50
 Content-Type: text/plain;
 	charset="iso-8859-1"
 Content-Transfer-Encoding: quoted-printable
 
 Hi,
 
 I'm using this very old cd drive, and can happily report that I've =
 compiled a 4.0 kernel (from the March 2000 CD set) and a 4.1-release =
 kernel with the modified matcd.c source and it works for data.
 
 There may to be some issues regarding audio cd, but I haven't been able =
 to test that properly yet.
 
 There are some issues regarding the use of the debug options in the code =
 (from options.h) where the compilation will report some warnings.
 
 Also the autohunt code seems not to be working, so it is not possible to =
 specify=20
 device matcd0 port ? irq?
 in the kernel configuration file.
 
 Regards
 
 Kristian Hansen,
 B=E6ktoften 86
 DK-2680 Solr=F8d Strand
 Tlf: +45 5614 9764
 E-Mail: kristian.hansen@post.tele.dk
 
 ------=_NextPart_000_0075_01C024A2.A0DACE50
 Content-Type: text/html;
 	charset="iso-8859-1"
 Content-Transfer-Encoding: quoted-printable
 
 <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
 <HTML><HEAD>
 <META content=3D"text/html; charset=3Diso-8859-1" =
 http-equiv=3DContent-Type>
 <META content=3D"MSHTML 5.00.2919.6307" name=3DGENERATOR>
 <STYLE></STYLE>
 </HEAD>
 <BODY bgColor=3D#ffffff>
 <DIV><FONT size=3D2>Hi,</FONT></DIV>
 <DIV>&nbsp;</DIV>
 <DIV><FONT size=3D2>I'm using this very old cd drive, and can happily =
 report that=20
 I've compiled a 4.0 kernel (from the March 2000 CD set) and a =
 4.1-release kernel=20
 with the modified matcd.c source and it works for data.</FONT></DIV>
 <DIV>&nbsp;</DIV>
 <DIV><FONT size=3D2>There&nbsp;may to be some issues regarding audio cd, =
 but I=20
 haven't been able to test that properly yet.</FONT></DIV>
 <DIV>&nbsp;</DIV>
 <DIV><FONT size=3D2>There are some issues regarding the use of the debug =
 options=20
 in the code (from options.h) where the compilation will report some=20
 warnings.</FONT></DIV>
 <DIV>&nbsp;</DIV>
 <DIV><FONT size=3D2>Also the autohunt code seems not to be working, so =
 it is not=20
 possible to specify </FONT></DIV>
 <DIV><FONT size=3D2>device matcd0 port ? irq?</FONT></DIV>
 <DIV><FONT size=3D2>in the kernel configuration file.</FONT></DIV>
 <DIV><FONT size=3D2></FONT>&nbsp;</DIV>
 <DIV><FONT size=3D2>Regards</FONT></DIV>
 <DIV>&nbsp;</DIV>
 <DIV><FONT size=3D2>Kristian Hansen,<BR>B=E6ktoften 86<BR>DK-2680 =
 Solr=F8d=20
 Strand<BR>Tlf: +45 5614 9764<BR>E-Mail: <A=20
 href=3D"mailto:kristian.hansen@post.tele.dk">kristian.hansen@post.tele.dk=
 </A></FONT></DIV></BODY></HTML>
 
 ------=_NextPart_000_0075_01C024A2.A0DACE50--
 
 
State-Changed-From-To: feedback->closed 
State-Changed-By: sheldonh 
State-Changed-When: Mon May 28 14:19:44 PDT 2001 
State-Changed-Why:  
Resolved ages ago. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=20296 
>Unformatted:
