From jdc@koitsu.org  Wed Apr 16 09:18:16 2014
Return-Path: <jdc@koitsu.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTPS id 70B08DC5
	for <freebsd-gnats-submit@freebsd.org>; Wed, 16 Apr 2014 09:18:16 +0000 (UTC)
Received: from qmta02.emeryville.ca.mail.comcast.net (qmta02.emeryville.ca.mail.comcast.net [IPv6:2001:558:fe2d:43:76:96:30:24])
	by mx1.freebsd.org (Postfix) with ESMTP id 5314E12B4
	for <freebsd-gnats-submit@freebsd.org>; Wed, 16 Apr 2014 09:18:16 +0000 (UTC)
Received: from omta18.emeryville.ca.mail.comcast.net ([76.96.30.74])
	by qmta02.emeryville.ca.mail.comcast.net with comcast
	id qZHL1n0041bwxycA2ZJEqJ; Wed, 16 Apr 2014 09:18:14 +0000
Received: from jdc.koitsu.org ([76.102.14.35])
	by omta18.emeryville.ca.mail.comcast.net with comcast
	id qZJD1n0060lNtxY8eZJDQV; Wed, 16 Apr 2014 09:18:13 +0000
Received: by icarus.home.lan (Postfix, from userid 1000)
	id 1CA4B73A1B; Wed, 16 Apr 2014 02:18:13 -0700 (PDT)
Message-Id: <20140416091813.1CA4B73A1B@icarus.home.lan>
Date: Wed, 16 Apr 2014 02:18:13 -0700 (PDT)
From: Jeremy Chadwick <jdc@koitsu.org>
Reply-To: Jeremy Chadwick <jdc@koitsu.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [cam] QUIRK: Add 4K quirks for WD Red and Black MHDDs
X-Send-Pr-Version: 3.114
X-GNATS-Notify:

>Number:         188685
>Category:       kern
>Synopsis:       [cam] [patch] QUIRK: Add 4K quirks for WD Red and Black MHDDs
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Wed Apr 16 09:20:00 UTC 2014
>Closed-Date:    
>Last-Modified:  Sun May 04 03:07:37 UTC 2014
>Originator:     Jeremy Chadwick
>Release:        FreeBSD 9.2-STABLE amd64
>Organization:
>Environment:
System: FreeBSD icarus.home.lan 9.2-STABLE FreeBSD 9.2-STABLE #0 r264285: Tue Apr 8 17:25:59 PDT 2014 root@icarus.home.lan:/usr/obj/usr/src/sys/X7SBA_RELENG_9_amd64 amd64
>Description:
	Add some 4K quirks for the following Western Digital Caviar MHDDs:

	- WD Black, 4000GB, WD4003FZEX
	- WD Black, 3000GB, WD3003FZEX
	- WD Black, 2000GB, WD2003FZEX
	- WD Black, 1000GB, WD1003FZEX
	- WD Black,  500GB, WD5003AZEX (yes this really does use 4K physical)
	- WD Black, 2000GB, WD2002FAEX
	- WD Black, 1000GB, WD1002FAEX
	- WD Black, 4000GB, WD4001FAEX
	- WD Black, 3000GB, WD3001FAEX
	- WD Black, 2000GB, WD2001FAEX
	- WD Black, 1000GB, WD1001FAEX
	- WD Red,    750GB, WD7500BFCX (yes this really does use 4K physical)
	- WD Red,   1000GB, WD10JFCX

	Also add a comment reflecting that WD????RX also matches some models
	of Red drives (not listed above) and not just Green.
>How-To-Repeat:
	n/a
>Fix:
	Apply below patch.


--- sys/cam/ata/ata_da.c.orig	2014-01-20 17:15:51.000000000 -0800
+++ sys/cam/ata/ata_da.c	2014-04-16 02:09:04.326162134 -0700
@@ -235,16 +235,31 @@
 		/*quirks*/ADA_Q_4K
 	},
 	{
+		/* WDC Caviar Red Advanced Format (4k) drives */
+		{ T_DIRECT, SIP_MEDIA_FIXED, "*", "WDC WD????CX*", "*" },
+		/*quirks*/ADA_Q_4K
+	},
+	{
 		/* WDC Caviar Green Advanced Format (4k) drives */
 		{ T_DIRECT, SIP_MEDIA_FIXED, "*", "WDC WD????RS*", "*" },
 		/*quirks*/ADA_Q_4K
 	},
 	{
-		/* WDC Caviar Green Advanced Format (4k) drives */
+		/* WDC Caviar Green/Red Advanced Format (4k) drives */
 		{ T_DIRECT, SIP_MEDIA_FIXED, "*", "WDC WD????RX*", "*" },
 		/*quirks*/ADA_Q_4K
 	},
 	{
+		/* WDC Caviar Red Advanced Format (4k) drives */
+		{ T_DIRECT, SIP_MEDIA_FIXED, "*", "WDC WD??????CX*", "*" },
+		/*quirks*/ADA_Q_4K
+	},
+	{
+		/* WDC Caviar Black Advanced Format (4k) drives */
+		{ T_DIRECT, SIP_MEDIA_FIXED, "*", "WDC WD??????EX*", "*" },
+		/*quirks*/ADA_Q_4K
+	},
+	{
 		/* WDC Caviar Green Advanced Format (4k) drives */
 		{ T_DIRECT, SIP_MEDIA_FIXED, "*", "WDC WD??????RS*", "*" },
 		/*quirks*/ADA_Q_4K
>Release-Note:
>Audit-Trail:

From: Jeremy Chadwick <jdc@koitsu.org>
To: FreeBSD-gnats-submit@FreeBSD.org, freebsd-bugs@FreeBSD.org
Cc:  
Subject: Re: kern/188685: [cam] QUIRK: Add 4K quirks for WD Red and Black
 MHDDs
Date: Wed, 16 Apr 2014 02:21:43 -0700

 Patch available here:
 
 http://jdc.koitsu.org/freebsd/188685/ata_da.c.diff
 
 -- 
 | Jeremy Chadwick                                   jdc@koitsu.org |
 | UNIX Systems Administrator                http://jdc.koitsu.org/ |
 | Making life hard for others since 1977.             PGP 4BD6C0CB |
 
>Unformatted:
