From nobody@FreeBSD.org  Wed Feb 12 18:46:35 2014
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTPS id 61AF24F7
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 12 Feb 2014 18:46:35 +0000 (UTC)
Received: from newred.freebsd.org (cgiserv.freebsd.org [IPv6:2001:1900:2254:206a::50:4])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.freebsd.org (Postfix) with ESMTPS id 4D22E1173
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 12 Feb 2014 18:46:35 +0000 (UTC)
Received: from cgiserv.freebsd.org ([127.0.1.6])
	by newred.freebsd.org (8.14.7/8.14.7) with ESMTP id s1CIkZp4007663
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 12 Feb 2014 18:46:35 GMT
	(envelope-from nobody@cgiserv.freebsd.org)
Received: (from nobody@localhost)
	by cgiserv.freebsd.org (8.14.7/8.14.7/Submit) id s1CIkZVc007662;
	Wed, 12 Feb 2014 18:46:35 GMT
	(envelope-from nobody)
Message-Id: <201402121846.s1CIkZVc007662@cgiserv.freebsd.org>
Date: Wed, 12 Feb 2014 18:46:35 GMT
From: Takanori Sawada <tak.swd@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: order of arguments for mtx_init is incorrect
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         186701
>Category:       kern
>Synopsis:       order of arguments for mtx_init is incorrect
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    brueffer
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Feb 12 18:50:00 UTC 2014
>Closed-Date:    Fri Feb 28 01:41:27 CET 2014
>Last-Modified:  Fri Feb 28 01:41:27 CET 2014
>Originator:     Takanori Sawada
>Release:        
>Organization:
>Environment:
FreeBSD Current
>Description:
Args are in wrong order to mtx_init(9)

(1)
http://svnweb.freebsd.org/base/head/sys/arm/broadcom/bcm2835/bcm2835_mbox.c?revision=261410&view=markup#l173

now:
mtx_init(&sc->lock, "vcio mbox", MTX_DEF, 0);

correct:
mtx_init(&sc->lock, "vcio mbox", NULL, MTX_DEF);

(2)
http://svnweb.freebsd.org/base/head/sys/dev/nand/nandbus.c?revision=260180&view=markup#l177

now:
mtx_init(&sc->nandbus_mtx, "nandbus lock", MTX_DEF, 0);

correct:
mtx_init(&sc->nandbus_mtx, "nandbus lock", NULL, MTX_DEF);

(3)
http://svnweb.freebsd.org/base/head/sys/powerpc/ofw/ofw_real.c?revision=253588&view=markup#l303

now:
mtx_init(&of_bounce_mtx, "OF Bounce Page", MTX_DEF, 0);

correct:
mtx_init(&of_bounce_mtx, "OF Bounce Page", NULL, MTX_DEF);
>How-To-Repeat:

>Fix:


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->patched 
State-Changed-By: brueffer 
State-Changed-When: Fri Feb 14 12:18:38 CET 2014 
State-Changed-Why:  
Committed, thanks! 


Responsible-Changed-From-To: freebsd-bugs->brueffer 
Responsible-Changed-By: brueffer 
Responsible-Changed-When: Fri Feb 14 12:18:38 CET 2014 
Responsible-Changed-Why:  
MFC reminder. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=186701 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/186701: commit references a PR
Date: Fri, 14 Feb 2014 11:18:28 +0000 (UTC)

 Author: brueffer
 Date: Fri Feb 14 11:18:15 2014
 New Revision: 261884
 URL: http://svnweb.freebsd.org/changeset/base/261884
 
 Log:
   Correct the order of arguments to mtx_init().
   
   PR:		186701
   Submitted by:	Takanori Sawada <tak.swd at gmail.com>
   MFC after:	2 weeks
 
 Modified:
   head/sys/arm/broadcom/bcm2835/bcm2835_mbox.c
   head/sys/dev/nand/nandbus.c
   head/sys/powerpc/ofw/ofw_real.c
 
 Modified: head/sys/arm/broadcom/bcm2835/bcm2835_mbox.c
 ==============================================================================
 --- head/sys/arm/broadcom/bcm2835/bcm2835_mbox.c	Fri Feb 14 10:56:26 2014	(r261883)
 +++ head/sys/arm/broadcom/bcm2835/bcm2835_mbox.c	Fri Feb 14 11:18:15 2014	(r261884)
 @@ -170,7 +170,7 @@ bcm_mbox_attach(device_t dev)
  		return (ENXIO);
  	}
  
 -	mtx_init(&sc->lock, "vcio mbox", MTX_DEF, 0);
 +	mtx_init(&sc->lock, "vcio mbox", NULL, MTX_DEF);
  	for (i = 0; i < BCM2835_MBOX_CHANS; i++) {
  		sc->valid[0] = 0;
  		sc->msg[0] = 0;
 
 Modified: head/sys/dev/nand/nandbus.c
 ==============================================================================
 --- head/sys/dev/nand/nandbus.c	Fri Feb 14 10:56:26 2014	(r261883)
 +++ head/sys/dev/nand/nandbus.c	Fri Feb 14 11:18:15 2014	(r261884)
 @@ -174,7 +174,7 @@ nandbus_attach(device_t dev)
  	nfc = device_get_parent(dev);
  	nfc_sc = device_get_softc(nfc);
  
 -	mtx_init(&sc->nandbus_mtx, "nandbus lock", MTX_DEF, 0);
 +	mtx_init(&sc->nandbus_mtx, "nandbus lock", NULL, MTX_DEF);
  	cv_init(&sc->nandbus_cv, "nandbus cv");
  
  	/* Check each possible CS for existing nand devices */
 
 Modified: head/sys/powerpc/ofw/ofw_real.c
 ==============================================================================
 --- head/sys/powerpc/ofw/ofw_real.c	Fri Feb 14 10:56:26 2014	(r261883)
 +++ head/sys/powerpc/ofw/ofw_real.c	Fri Feb 14 11:18:15 2014	(r261884)
 @@ -300,7 +300,7 @@ ofw_real_init(ofw_t ofw, void *openfirm)
  {
  	openfirmware = (int (*)(void *))openfirm;
  
 -	mtx_init(&of_bounce_mtx, "OF Bounce Page", MTX_DEF, 0);
 +	mtx_init(&of_bounce_mtx, "OF Bounce Page", NULL, MTX_DEF);
  	of_bounce_virt = NULL;
  	return (0);
  }
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/186701: commit references a PR
Date: Fri, 28 Feb 2014 00:39:44 +0000 (UTC)

 Author: brueffer
 Date: Fri Feb 28 00:39:35 2014
 New Revision: 262586
 URL: http://svnweb.freebsd.org/changeset/base/262586
 
 Log:
   MFC: r261884
   
   Correct the order of arguments to mtx_init().
   
   PR:		186701
   Submitted by:	Takanori Sawada <tak.swd at gmail.com>
 
 Modified:
   stable/10/sys/arm/broadcom/bcm2835/bcm2835_mbox.c
   stable/10/sys/dev/nand/nandbus.c
   stable/10/sys/powerpc/ofw/ofw_real.c
 Directory Properties:
   stable/10/   (props changed)
 
 Modified: stable/10/sys/arm/broadcom/bcm2835/bcm2835_mbox.c
 ==============================================================================
 --- stable/10/sys/arm/broadcom/bcm2835/bcm2835_mbox.c	Fri Feb 28 00:26:57 2014	(r262585)
 +++ stable/10/sys/arm/broadcom/bcm2835/bcm2835_mbox.c	Fri Feb 28 00:39:35 2014	(r262586)
 @@ -167,7 +167,7 @@ bcm_mbox_attach(device_t dev)
  		return (ENXIO);
  	}
  
 -	mtx_init(&sc->lock, "vcio mbox", MTX_DEF, 0);
 +	mtx_init(&sc->lock, "vcio mbox", NULL, MTX_DEF);
  	for (i = 0; i < BCM2835_MBOX_CHANS; i++) {
  		sc->valid[0] = 0;
  		sc->msg[0] = 0;
 
 Modified: stable/10/sys/dev/nand/nandbus.c
 ==============================================================================
 --- stable/10/sys/dev/nand/nandbus.c	Fri Feb 28 00:26:57 2014	(r262585)
 +++ stable/10/sys/dev/nand/nandbus.c	Fri Feb 28 00:39:35 2014	(r262586)
 @@ -174,7 +174,7 @@ nandbus_attach(device_t dev)
  	nfc = device_get_parent(dev);
  	nfc_sc = device_get_softc(nfc);
  
 -	mtx_init(&sc->nandbus_mtx, "nandbus lock", MTX_DEF, 0);
 +	mtx_init(&sc->nandbus_mtx, "nandbus lock", NULL, MTX_DEF);
  	cv_init(&sc->nandbus_cv, "nandbus cv");
  
  	/* Check each possible CS for existing nand devices */
 
 Modified: stable/10/sys/powerpc/ofw/ofw_real.c
 ==============================================================================
 --- stable/10/sys/powerpc/ofw/ofw_real.c	Fri Feb 28 00:26:57 2014	(r262585)
 +++ stable/10/sys/powerpc/ofw/ofw_real.c	Fri Feb 28 00:39:35 2014	(r262586)
 @@ -300,7 +300,7 @@ ofw_real_init(ofw_t ofw, void *openfirm)
  {
  	openfirmware = (int (*)(void *))openfirm;
  
 -	mtx_init(&of_bounce_mtx, "OF Bounce Page", MTX_DEF, 0);
 +	mtx_init(&of_bounce_mtx, "OF Bounce Page", NULL, MTX_DEF);
  	of_bounce_virt = NULL;
  	return (0);
  }
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: brueffer 
State-Changed-When: Fri Feb 28 01:41:06 CET 2014 
State-Changed-Why:  
Merge to stable branch done. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=186701 
>Unformatted:
