From nobody@FreeBSD.org  Tue Feb 11 14:35:57 2014
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTPS id 3C62C4A2
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 11 Feb 2014 14:35:57 +0000 (UTC)
Received: from newred.freebsd.org (cgiserv.freebsd.org [IPv6:2001:1900:2254:206a::50:4])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.freebsd.org (Postfix) with ESMTPS id 0B9791894
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 11 Feb 2014 14:35:57 +0000 (UTC)
Received: from cgiserv.freebsd.org ([127.0.1.6])
	by newred.freebsd.org (8.14.7/8.14.7) with ESMTP id s1BEZuQ3052676
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 11 Feb 2014 14:35:56 GMT
	(envelope-from nobody@cgiserv.freebsd.org)
Received: (from nobody@localhost)
	by cgiserv.freebsd.org (8.14.7/8.14.7/Submit) id s1BEZujp052670;
	Tue, 11 Feb 2014 14:35:56 GMT
	(envelope-from nobody)
Message-Id: <201402111435.s1BEZujp052670@cgiserv.freebsd.org>
Date: Tue, 11 Feb 2014 14:35:56 GMT
From: Martin Sugioarto <nakal@web.de>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Crash during umount -a -t smbfs
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         186652
>Category:       kern
>Synopsis:       [smbfs] [panic] crash during umount -a -t smbfs
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    ae
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Feb 11 14:40:00 UTC 2014
>Closed-Date:    Fri May 02 21:47:41 UTC 2014
>Last-Modified:  Fri May 02 21:47:41 UTC 2014
>Originator:     Martin Sugioarto
>Release:        10.0-RELEASE
>Organization:
>Environment:
FreeBSD 10.0-RELEASE FreeBSD 10.0-RELEASE #0 r260789: Thu Jan 16 22:34:59 UTC 2014     root@snap.freebsd.org:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
smbfs have been not responsive for all mounted shares. I tried to remount
them, but the kernel crashed shortly after executing umount -a -t smbfs.

Here is the stack trace:

#0  doadump (textdump=<value optimized out>) at pcpu.h:219
#1  0xffffffff808af530 in kern_reboot (howto=260) at /usr/src/sys/kern/kern_shutdown.c:447
#2  0xffffffff808af8f4 in panic (fmt=<value optimized out>) at /usr/src/sys/kern/kern_shutdown.c:754
#3  0xffffffff80c8e692 in trap_fatal (frame=<value optimized out>, eva=<value optimized out>) at /usr/src/sys/amd64/amd64/trap.c:882
#4  0xffffffff80c8e969 in trap_pfault (frame=0xfffffe02298e5940, usermode=0) at /usr/src/sys/amd64/amd64/trap.c:699
#5  0xffffffff80c8e0f6 in trap (frame=0xfffffe02298e5940) at /usr/src/sys/amd64/amd64/trap.c:463
#6  0xffffffff80c75392 in calltrap () at /usr/src/sys/amd64/amd64/exception.S:232
#7  0xffffffff808f81ec in turnstile_broadcast (ts=0x0, queue=0) at /usr/src/sys/kern/subr_turnstile.c:838
#8  0xffffffff8089c860 in __mtx_unlock_sleep (c=0xfffff80207b37d08, opts=<value optimized out>, file=0xffffffff81c41001 " disordered parameters %d:%d\n", line=1) at /usr/src/sys/kern/kern_mutex.c:761
#9  0xffffffff8089c7e9 in __mtx_unlock_flags (c=<value optimized out>, opts=<value optimized out>, file=0xffffffff81c41001 " disordered parameters %d:%d\n", line=1) at /usr/src/sys/kern/kern_mutex.c:254
#10 0xffffffff81c37936 in smb_iod_invrq (iod=<value optimized out>) at /usr/src/sys/modules/smbfs/../../netsmb/smb_iod.c:91
#11 0xffffffff81c36597 in smb_iod_addrq (rqp=0xfffff80207b37c00) at /usr/src/sys/modules/smbfs/../../netsmb/smb_iod.c:116
#12 0xffffffff81c33984 in smb_rq_simple (rqp=0xfffff80207b37c00) at /usr/src/sys/modules/smbfs/../../netsmb/smb_rq.c:168
#13 0xffffffff81c31eac in smb_smb_ssnclose (vcp=<value optimized out>, scred=<value optimized out>) at /usr/src/sys/modules/smbfs/../../netsmb/smb_smb.c:464
#14 0xffffffff81c373df in smb_iod_thread (arg=0xfffff80027aec600) at /usr/src/sys/modules/smbfs/../../netsmb/smb_iod.c:180
#15 0xffffffff8088198a in fork_exit (callout=0xffffffff81c37290 <smb_iod_thread>, arg=0xfffff80027aec600, frame=0xfffffe02298e5c00) at /usr/src/sys/kern/kern_fork.c:995
#16 0xffffffff80c758ce in fork_trampoline () at /usr/src/sys/amd64/amd64/exception.S:606
#17 0x0000000000000000 in ?? ()


vmcore file is still available, if you need further information.

--
Martin Sugioarto
>How-To-Repeat:

>Fix:


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-fs 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Wed Apr 16 02:08:27 UTC 2014 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=186652 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/186652: commit references a PR
Date: Thu, 17 Apr 2014 12:22:14 +0000 (UTC)

 Author: ae
 Date: Thu Apr 17 12:22:08 2014
 New Revision: 264600
 URL: http://svnweb.freebsd.org/changeset/base/264600
 
 Log:
   Remove redundant unlock.
   
   This code was removed from the opensolaris and darwin's
   netsmb implementations, in DfBSD it also has been disabled.
   
   PR:		36566, 87859, 139407, 161579, 175557, 178412, 186652
   MFC after:	2 weeks
   Sponsored by:	Yandex LLC
 
 Modified:
   head/sys/netsmb/smb_iod.c
 
 Modified: head/sys/netsmb/smb_iod.c
 ==============================================================================
 --- head/sys/netsmb/smb_iod.c	Thu Apr 17 12:16:51 2014	(r264599)
 +++ head/sys/netsmb/smb_iod.c	Thu Apr 17 12:22:08 2014	(r264600)
 @@ -87,8 +87,6 @@ smb_iod_invrq(struct smbiod *iod)
  	 */
  	SMB_IOD_RQLOCK(iod);
  	TAILQ_FOREACH(rqp, &iod->iod_rqlist, sr_link) {
 -		if (rqp->sr_flags & SMBR_INTERNAL)
 -			SMBRQ_SUNLOCK(rqp);
  		rqp->sr_flags |= SMBR_RESTART;
  		smb_iod_rqprocessed(rqp, ENOTCONN);
  	}
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: ae 
State-Changed-When: Fri May 2 21:47:05 UTC 2014 
State-Changed-Why:  
Fixed in head/ and stable/10. 


Responsible-Changed-From-To: freebsd-fs->ae 
Responsible-Changed-By: ae 
Responsible-Changed-When: Fri May 2 21:47:05 UTC 2014 
Responsible-Changed-Why:  
Take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=186652 
>Unformatted:
