From naddy@mips.inka.de  Mon Dec  9 16:45:31 2013
Return-Path: <naddy@mips.inka.de>
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTPS id 693D783E
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  9 Dec 2013 16:45:31 +0000 (UTC)
Received: from mail-in-05.arcor-online.net (mail-in-05.arcor-online.net [151.189.21.45])
	(using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.freebsd.org (Postfix) with ESMTPS id 1C6901A13
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  9 Dec 2013 16:45:31 +0000 (UTC)
Received: from mail-in-16-z2.arcor-online.net (mail-in-16-z2.arcor-online.net [151.189.8.33])
	by mx.arcor.de (Postfix) with ESMTP id 4D507E3DBA
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  9 Dec 2013 17:11:06 +0100 (CET)
Received: from mail-in-07.arcor-online.net (mail-in-07.arcor-online.net [151.189.21.47])
	by mail-in-16-z2.arcor-online.net (Postfix) with ESMTP id 4C2A5212031
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  9 Dec 2013 17:11:06 +0100 (CET)
Received: from lorvorc.mips.inka.de (dslb-092-075-215-225.pools.arcor-ip.net [92.75.215.225])
	by mail-in-07.arcor-online.net (Postfix) with ESMTPS id 1C490107BB7
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  9 Dec 2013 17:11:06 +0100 (CET)
Received: from lorvorc.mips.inka.de (localhost [127.0.0.1])
	by lorvorc.mips.inka.de (8.14.7/8.14.7) with ESMTP id rB9GB5Bq074986
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 9 Dec 2013 17:11:05 +0100 (CET)
	(envelope-from naddy@lorvorc.mips.inka.de)
Received: (from naddy@localhost)
	by lorvorc.mips.inka.de (8.14.7/8.14.7/Submit) id rB9GB5E3074985;
	Mon, 9 Dec 2013 17:11:05 +0100 (CET)
	(envelope-from naddy)
Message-Id: <201312091611.rB9GB5E3074985@lorvorc.mips.inka.de>
Date: Mon, 9 Dec 2013 17:11:05 +0100 (CET)
From: Christian Weisgerber <naddy@FreeBSD.org>
Reply-To: Christian Weisgerber <naddy@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: ncurses: bump ospeed from short to int
X-Send-Pr-Version: 3.114
X-GNATS-Notify:

>Number:         184638
>Category:       kern
>Synopsis:       [ncurses] bump ospeed from short to int
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Dec 09 16:50:00 UTC 2013
>Closed-Date:    
>Last-Modified:  Sun Apr 20 21:49:57 UTC 2014
>Originator:     Christian Weisgerber
>Release:        FreeBSD 9.2-STABLE amd64
>Organization:
>Environment:
System: FreeBSD lorvorc.mips.inka.de 9.2-STABLE FreeBSD 9.2-STABLE #0 r259069: Sat Dec 7 15:52:28 CET 2013 naddy@lorvorc.mips.inka.de:/usr/obj/usr/src/sys/GENERIC amd64

>Description:

In FreeBSD (all supported versions) the type of the ospeed variable
is defined as "short" in lib/ncurses/ncurses/Makefile.  However,
in contrib/ncurses/ncurses/tinfo/lib_baudrate.c the USE_OLD_TTY
hack is disabled for FreeBSD >=7 since the required 4.3BSD compatibility
goo went away.  As a result, ospeed now needs to be able to hold
values up to 921600 (cf. <sys/_termios.h>), so it must be bumped
from short to int.

Obviously this is a binary-incompatible API change.

Arguably, switching ospeed's type is more intrusive than having
garbage values in ospeed, but we should strive for correctness.

(FWIW, OpenBSD, which is facing the same issue, will switch to int
ospeed.)

>How-To-Repeat:

>Fix:

>Release-Note:
>Audit-Trail:
>Unformatted:
