From jon@spock.org  Thu May  4 00:22:20 2000
Return-Path: <jon@spock.org>
Received: from spock.org (cm-24-161-5-13.nycap.rr.com [24.161.5.13])
	by hub.freebsd.org (Postfix) with ESMTP id 9069637B9F9
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  4 May 2000 00:22:04 -0700 (PDT)
	(envelope-from jon@spock.org)
Received: (from jon@localhost)
	by spock.org  serial EF600Q3T-B7F;
	Thu, 4 May 2000 03:21:59 -0400 (EDT)
	(envelope-from jon)
Message-Id: <200005040721.DAA41967@spock.org>
Date: Thu, 4 May 2000 03:21:59 -0400 (EDT)
From: jon@spock.org
Reply-To: jon@spock.org
To: FreeBSD-gnats-submit@freebsd.org
Subject: syscons off by 1 error handling e[1J
X-Send-Pr-Version: 3.2

>Number:         18381
>Category:       kern
>Synopsis:       syscons off by 1 error handling \e[1J
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    yokota
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu May  4 00:30:01 PDT 2000
>Closed-Date:    Fri Jul 20 07:08:27 PDT 2001
>Last-Modified:  Fri Jul 20 07:09:09 PDT 2001
>Originator:     Jonathan Chen
>Release:        4.0-STABLE / 5.0-CURRENT
>Organization:
>Environment:

	

>Description:
Off by one error in sys/dev/syscons/sctermvar.h function sc_term_clr_eos()

Call to sc_vtb_erase() needs the length instead of ending position.
	

>How-To-Repeat:

echo "\e[1;1AAA...AAA\e[1;10H\e[1J\e[2;10H\e[1K"

	

>Fix:
	
Index: sctermvar.h
===================================================================
RCS file: /export/ncvs/src/sys/dev/syscons/sctermvar.h,v
retrieving revision 1.1
diff -u -r1.1 sctermvar.h
--- sctermvar.h	2000/01/15 15:25:37	1.1
+++ sctermvar.h	2000/05/04 07:08:43
@@ -221,7 +221,7 @@
 		sc_remove_cutmarking(scp);
 		break;
 	case 1: /* clear from beginning of display to cursor */
-		sc_vtb_erase(&scp->vtb, 0, scp->cursor_pos, ch, attr);
+		sc_vtb_erase(&scp->vtb, 0, scp->cursor_pos+1, ch, attr);
 		mark_for_update(scp, 0);
 		mark_for_update(scp, scp->cursor_pos);
 		sc_remove_cutmarking(scp);

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->yokota 
Responsible-Changed-By: johan 
Responsible-Changed-When: Thu Aug 24 04:54:00 PDT 2000 
Responsible-Changed-Why:  
Over to syscons maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=18381 
State-Changed-From-To: open->closed 
State-Changed-By: yokota 
State-Changed-When: Fri Jul 20 07:08:27 PDT 2001 
State-Changed-Why:  
Committed to 5.0-CURRENT. Will be merged to RELENG_4 shortly. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=18381 
>Unformatted:
