From nobody@FreeBSD.org  Mon Oct 21 22:40:01 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTP id EFD6D597
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 21 Oct 2013 22:40:01 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.freebsd.org (Postfix) with ESMTPS id DE05F2BE9
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 21 Oct 2013 22:40:01 +0000 (UTC)
Received: from oldred.freebsd.org ([127.0.1.6])
	by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id r9LMe1uc016154
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 21 Oct 2013 22:40:01 GMT
	(envelope-from nobody@oldred.freebsd.org)
Received: (from nobody@localhost)
	by oldred.freebsd.org (8.14.5/8.14.5/Submit) id r9LMe1KZ016153;
	Mon, 21 Oct 2013 22:40:01 GMT
	(envelope-from nobody)
Message-Id: <201310212240.r9LMe1KZ016153@oldred.freebsd.org>
Date: Mon, 21 Oct 2013 22:40:01 GMT
From: "Edward O'Callaghan" <eocallaghan@alterapraxis.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: RTL8111/8168 fails to attach.
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         183167
>Category:       kern
>Synopsis:       RTL8111/8168 fails to attach.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    yongari
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Oct 21 22:50:02 UTC 2013
>Closed-Date:    Wed Nov 06 04:29:01 UTC 2013
>Last-Modified:  Wed Nov 06 04:29:01 UTC 2013
>Originator:     Edward O'Callaghan
>Release:        FreeBSD 10.0-BETA1
>Organization:
Altera Praxis Pty Ltd
>Environment:
FreeBSD 10.0-BETA1 amd64
>Description:
G'day,

The network adapter found in this^[1] crappy commodity board fails to attach.
The NIC in question seems to be a 'RTL8111/8168 Express Gigabit Ethernet' with the vendor:product id of 10ec:8168. I presume the right driver should be re(4) which claims to support this chipset. If it is any help this MB has a horrible UEFI BIOS. Let me know if there is anything else I can provide?

Kind Regards,
Edward.

[1] - http://www.asus.com/Motherboards/Z87C/
>How-To-Repeat:
Try FreeBSD with a 'RTL8111/8168 Express Gigabit Ethernet' NIC.
>Fix:
It is known that GNU/Linux attaches this NIC and was found to work fine.
Possibly just a case of adding the product id to the driver?

>Release-Note:
>Audit-Trail:

From: "Edward O'Callaghan" <victoredwardocallaghan@gmail.com>
To: bug-followup@FreeBSD.org, eocallaghan@alterapraxis.com
Cc:  
Subject: Re: kern/183167: RTL8111/8168 fails to attach.
Date: Wed, 23 Oct 2013 03:45:14 +1100

 --047d7bf0f2f4f6ce5604e9571ffc
 Content-Type: text/plain; charset=UTF-8
 
 Possible patch attached. Needs a review and better testing.
 
 -- 
 
 -- 
                 The choice of a       AuroraUX, dependent type & homotopy theory
       -----==-     _GNU_              http://www.auroraux.org/
       ----==-- _       generation
       ---==---(_)__  __ ____  __      Edward O'Callaghan
       --==---/ / _ \/ // /\ \/ /      victoredwardocallaghan_at_gmail.com
       -=====/_/_//_/\_,_/ /_/\_\
 
 --047d7bf0f2f4f6ce5604e9571ffc
 Content-Type: text/x-patch; charset=US-ASCII; 
 	name="0001-Add-preliminary-support-for-some-newer-RTL8111-8168-.patch"
 Content-Disposition: attachment; 
 	filename="0001-Add-preliminary-support-for-some-newer-RTL8111-8168-.patch"
 Content-Transfer-Encoding: base64
 X-Attachment-Id: f_hn3d4vij0
 
 RnJvbSA3ZDU0ZjQ3NGQ5MWIzNjJjM2U5MDg5NGFiOTljY2Y3NjU1YzYwMjA0IE1vbiBTZXAgMTcg
 MDA6MDA6MDAgMjAwMQpGcm9tOiBFZHdhcmQgTydDYWxsYWdoYW4gPGVvY2FsbGFnaGFuQGFsdGVy
 YXByYXhpcy5jb20+CkRhdGU6IFdlZCwgMjMgT2N0IDIwMTMgMDE6MTY6MTQgKzExMDAKU3ViamVj
 dDogW1BBVENIXSBBZGQgcHJlbGltaW5hcnkgc3VwcG9ydCBmb3Igc29tZSBuZXdlciBSVEw4MTEx
 LzgxNjggRXhwcmVzcwogR2lnYWJpdCBFdGhlcm5ldCBjb250cm9sbGVycyBzdWNoIGFzIHRoZSBv
 bmUgZm91bmQgaW4gUFIxODMxNjcuCk9yZ2FuaXphdGlvbjogQWx0ZXJhIFByYXhpcyBQdHkgTHRk
 LgpUbzogZnJlZWJzZC1uZXRAZnJlZWJzZC5vcmcKClNpZ25lZC1vZmYtYnk6IEVkd2FyZCBPJ0Nh
 bGxhZ2hhbiA8ZW9jYWxsYWdoYW5AYWx0ZXJhcHJheGlzLmNvbT4KLS0tCiBzeXMvZGV2L3JlL2lm
 X3JlLmMgfCA2ICsrKysrKwogc3lzL3BjaS9pZl9ybHJlZy5oIHwgMyArKysKIDIgZmlsZXMgY2hh
 bmdlZCwgOSBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvc3lzL2Rldi9yZS9pZl9yZS5jIGIv
 c3lzL2Rldi9yZS9pZl9yZS5jCmluZGV4IDM4MWZhODcuLjBlYTMzMGEgMTAwNjQ0Ci0tLSBhL3N5
 cy9kZXYvcmUvaWZfcmUuYworKysgYi9zeXMvZGV2L3JlL2lmX3JlLmMKQEAgLTIzNCw2ICsyMzQs
 OSBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IHJsX2h3cmV2IHJlX2h3cmV2c1tdID0gewogCXsgUkxf
 SFdSRVZfODE2OEUsIFJMXzgxNjksICI4MTY4RS84MTExRSIsIFJMX0pVTUJPX01UVV85S30sCiAJ
 eyBSTF9IV1JFVl84MTY4RV9WTCwgUkxfODE2OSwgIjgxNjhFLzgxMTFFLVZMIiwgUkxfSlVNQk9f
 TVRVXzZLfSwKIAl7IFJMX0hXUkVWXzgxNjhGLCBSTF84MTY5LCAiODE2OEYvODExMUYiLCBSTF9K
 VU1CT19NVFVfOUt9LAorCXsgUkxfSFdSRVZfODE2OEcsIFJMXzgxNjksICI4MTY4Ry84MTExRyIs
 IFJMX01UVX0sCisJeyBSTF9IV1JFVl84MTY4RVAsIFJMXzgxNjksICI4MTY4Ry84MTExRVAiLCBS
 TF9NVFV9LAorCXsgUkxfSFdSRVZfODE2OEdVLCBSTF84MTY5LCAiODE2OEcvODExMUdVIiwgUkxf
 TVRVfSwKIAl7IFJMX0hXUkVWXzg0MTEsIFJMXzgxNjksICI4NDExIiwgUkxfSlVNQk9fTVRVXzlL
 fSwKIAl7IDAsIDAsIE5VTEwsIDAgfQogfTsKQEAgLTE0NTEsNiArMTQ1NCw3IEBAIHJlX2F0dGFj
 aChkZXZpY2VfdCBkZXYpCiAJCSAgICBSTF9GTEFHX0RFU0NWMiB8IFJMX0ZMQUdfTUFDU1RBVCB8
 IFJMX0ZMQUdfQVVUT1BBRCB8CiAJCSAgICBSTF9GTEFHX0pVTUJPVjIgfCBSTF9GTEFHX1dBSVRf
 VFhQT0xMIHwgUkxfRkxBR19XT0xfTUFOTElOSzsKIAkJYnJlYWs7CisJY2FzZSBSTF9IV1JFVl84
 MTY4R1U6CiAJY2FzZSBSTF9IV1JFVl84MTY4RToKIAkJc2MtPnJsX2ZsYWdzIHw9IFJMX0ZMQUdf
 UEhZV0FLRSB8IFJMX0ZMQUdfUEhZV0FLRV9QTSB8CiAJCSAgICBSTF9GTEFHX1BBUiB8IFJMX0ZM
 QUdfREVTQ1YyIHwgUkxfRkxBR19NQUNTVEFUIHwKQEAgLTE0NTgsNyArMTQ2Miw5IEBAIHJlX2F0
 dGFjaChkZXZpY2VfdCBkZXYpCiAJCSAgICBSTF9GTEFHX1dPTF9NQU5MSU5LOwogCQlicmVhazsK
 IAljYXNlIFJMX0hXUkVWXzgxNjhFX1ZMOgorCWNhc2UgUkxfSFdSRVZfODE2OEVQOgogCWNhc2Ug
 UkxfSFdSRVZfODE2OEY6CisJY2FzZSBSTF9IV1JFVl84MTY4RzoKIAljYXNlIFJMX0hXUkVWXzg0
 MTE6CiAJCXNjLT5ybF9mbGFncyB8PSBSTF9GTEFHX1BIWVdBS0UgfCBSTF9GTEFHX1BBUiB8CiAJ
 CSAgICBSTF9GTEFHX0RFU0NWMiB8IFJMX0ZMQUdfTUFDU1RBVCB8IFJMX0ZMQUdfQ01EU1RPUCB8
 CmRpZmYgLS1naXQgYS9zeXMvcGNpL2lmX3JscmVnLmggYi9zeXMvcGNpL2lmX3JscmVnLmgKaW5k
 ZXggMTQyZmU0OC4uOTU1NTBiNyAxMDA2NDQKLS0tIGEvc3lzL3BjaS9pZl9ybHJlZy5oCisrKyBi
 L3N5cy9wY2kvaWZfcmxyZWcuaApAQCAtMTkyLDYgKzE5Miw5IEBACiAjZGVmaW5lCVJMX0hXUkVW
 XzgxMDZFCQkweDQ0ODAwMDAwCiAjZGVmaW5lCVJMX0hXUkVWXzgxNjhGCQkweDQ4MDAwMDAwCiAj
 ZGVmaW5lCVJMX0hXUkVWXzg0MTEJCTB4NDg4MDAwMDAKKyNkZWZpbmUgUkVfSFdSRVZfODE2OEcg
 ICAgICAweDRDMDAwMDAwCisjZGVmaW5lIFJFX0hXUkVWXzgxNjhFUCAgICAgMHg1MDAwMDAwMAor
 I2RlZmluZSBSRV9IV1JFVl84MTY4R1UgICAgIDB4NTA4MDAwMDAgICAgICAvKiA4MTA2RVVTICov
 CiAjZGVmaW5lCVJMX0hXUkVWXzgxMzkJCTB4NjAwMDAwMDAKICNkZWZpbmUJUkxfSFdSRVZfODEz
 OUEJCTB4NzAwMDAwMDAKICNkZWZpbmUJUkxfSFdSRVZfODEzOUFHCQkweDcwODAwMDAwCi0tIAox
 LjguNC4xCgo=
 --047d7bf0f2f4f6ce5604e9571ffc--

From: Edward O'Callaghan <eocallaghan@alterapraxis.com>
To: bug-followup@FreeBSD.org,eocallaghan@alterapraxis.com
Cc:  
Subject: Re: kern/183167: RTL8111/8168 fails to attach.
Date: Wed, 23 Oct 2013 03:40:34 +1100

 --MP_/IgIZzM0sgnOe4YTg117kGzi
 Content-Type: text/plain; charset=US-ASCII
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline
 
 Possible patch attached. Needs a review and better testing.
 --MP_/IgIZzM0sgnOe4YTg117kGzi
 Content-Type: text/x-patch
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
  filename=0001-Add-preliminary-support-for-some-newer-RTL8111-8168-.patch
 
 From 7d54f474d91b362c3e90894ab99ccf7655c60204 Mon Sep 17 00:00:00 2001
 From: Edward O'Callaghan <eocallaghan@alterapraxis.com>
 Date: Wed, 23 Oct 2013 01:16:14 +1100
 Subject: [PATCH] Add preliminary support for some newer RTL8111/8168 Express
  Gigabit Ethernet controllers such as the one found in PR183167.
 Organization: Altera Praxis Pty Ltd.
 To: freebsd-net@freebsd.org
 
 Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
 ---
  sys/dev/re/if_re.c | 6 ++++++
  sys/pci/if_rlreg.h | 3 +++
  2 files changed, 9 insertions(+)
 
 diff --git a/sys/dev/re/if_re.c b/sys/dev/re/if_re.c
 index 381fa87..0ea330a 100644
 --- a/sys/dev/re/if_re.c
 +++ b/sys/dev/re/if_re.c
 @@ -234,6 +234,9 @@ static const struct rl_hwrev re_hwrevs[] = {
  	{ RL_HWREV_8168E, RL_8169, "8168E/8111E", RL_JUMBO_MTU_9K},
  	{ RL_HWREV_8168E_VL, RL_8169, "8168E/8111E-VL", RL_JUMBO_MTU_6K},
  	{ RL_HWREV_8168F, RL_8169, "8168F/8111F", RL_JUMBO_MTU_9K},
 +	{ RL_HWREV_8168G, RL_8169, "8168G/8111G", RL_MTU},
 +	{ RL_HWREV_8168EP, RL_8169, "8168G/8111EP", RL_MTU},
 +	{ RL_HWREV_8168GU, RL_8169, "8168G/8111GU", RL_MTU},
  	{ RL_HWREV_8411, RL_8169, "8411", RL_JUMBO_MTU_9K},
  	{ 0, 0, NULL, 0 }
  };
 @@ -1451,6 +1454,7 @@ re_attach(device_t dev)
  		    RL_FLAG_DESCV2 | RL_FLAG_MACSTAT | RL_FLAG_AUTOPAD |
  		    RL_FLAG_JUMBOV2 | RL_FLAG_WAIT_TXPOLL | RL_FLAG_WOL_MANLINK;
  		break;
 +	case RL_HWREV_8168GU:
  	case RL_HWREV_8168E:
  		sc->rl_flags |= RL_FLAG_PHYWAKE | RL_FLAG_PHYWAKE_PM |
  		    RL_FLAG_PAR | RL_FLAG_DESCV2 | RL_FLAG_MACSTAT |
 @@ -1458,7 +1462,9 @@ re_attach(device_t dev)
  		    RL_FLAG_WOL_MANLINK;
  		break;
  	case RL_HWREV_8168E_VL:
 +	case RL_HWREV_8168EP:
  	case RL_HWREV_8168F:
 +	case RL_HWREV_8168G:
  	case RL_HWREV_8411:
  		sc->rl_flags |= RL_FLAG_PHYWAKE | RL_FLAG_PAR |
  		    RL_FLAG_DESCV2 | RL_FLAG_MACSTAT | RL_FLAG_CMDSTOP |
 diff --git a/sys/pci/if_rlreg.h b/sys/pci/if_rlreg.h
 index 142fe48..95550b7 100644
 --- a/sys/pci/if_rlreg.h
 +++ b/sys/pci/if_rlreg.h
 @@ -192,6 +192,9 @@
  #define	RL_HWREV_8106E		0x44800000
  #define	RL_HWREV_8168F		0x48000000
  #define	RL_HWREV_8411		0x48800000
 +#define RE_HWREV_8168G      0x4C000000
 +#define RE_HWREV_8168EP     0x50000000
 +#define RE_HWREV_8168GU     0x50800000      /* 8106EUS */
  #define	RL_HWREV_8139		0x60000000
  #define	RL_HWREV_8139A		0x70000000
  #define	RL_HWREV_8139AG		0x70800000
 -- 
 1.8.4.1
 
 
 --MP_/IgIZzM0sgnOe4YTg117kGzi--
State-Changed-From-To: open->feedback 
State-Changed-By: yongari 
State-Changed-When: Tue Oct 29 06:05:20 UTC 2013 
State-Changed-Why:  
Addressed in r257304-257306. 
Let me know whether it works or not. 


Responsible-Changed-From-To: freebsd-bugs->yongari 
Responsible-Changed-By: yongari 
Responsible-Changed-When: Tue Oct 29 06:05:20 UTC 2013 
Responsible-Changed-Why:  
Grab. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=183167 

From: Edward O'Callaghan <eocallaghan@alterapraxis.com>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/183167: RTL8111/8168 fails to attach.
Date: Wed, 6 Nov 2013 05:08:15 +1100

 --Sig_/5zKXajwl/lw8Rxqc9sJ=ceH
 Content-Type: text/plain; charset=US-ASCII
 Content-Transfer-Encoding: quoted-printable
 
 You can close this now, because both our patches in HEAD resolved my
 issues.
 
 --Sig_/5zKXajwl/lw8Rxqc9sJ=ceH
 Content-Type: application/pgp-signature; name=signature.asc
 Content-Disposition: attachment; filename=signature.asc
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.22 (GNU/Linux)
 
 iQIcBAEBCgAGBQJSeTQUAAoJENeyf/ug44dtiX8P/i9ZvnWrK16u5Gn3mBMfKtS5
 7bx9ob/WFuHwZ+Ai9eobrKUiueRvAx/Ge9pgLJVeiANQII2IFyrs9XijN3JLfrDN
 WdO/cualHSzHvjKP5sFIgBtsfYtEfEuHPj3D/YS6Pm4ti+dNa6NDppBOk6NLbpNH
 SkdeTBF/8QSqCByQWdD4N3daYhvtbFb5vtyTGj7tMLpt1H8HHJLeyMHzezavxy3R
 ldxRCHyvrqEPE1hHyf36TJj5kZJRNfN714Ol0CRDlgKfUGCTqwzw5UPZuCtmpiXD
 v91+UluytaKnZgSGBa2vxmwHtfb8GTz1df6BAj75+MVC2DW5qZemm4rQMcEcA/yc
 wBYmYJaJuErximNZWDX0d6Eektcqm0oFKOSdW/Gw9JVObP/cSC+49uxkoyw8Ichu
 R0o36EQSeDl8BEgct0SgpbkVaH6Ixhqh1xhL/TEVncOjR+bMXCmpRE9kh3V47n0K
 pw72e6dpRKOJa1NApPWktc2GmpBTMUAlaCjN6yyf9FMfHmW4Ruj47ehy96trN+9u
 RYSOJqafmR4kdq+VXmlhDUii+0/6LJ7OQYeju3Kw9TigL9PRg7zfMie63anLJztl
 JoMDropJHCz7MpWCYTFKdihACiU7YeTlE5hBoQ843lGEwD1vMLoyw5Y93CzxrIoG
 v5Y3OwMKolAV3Jt/pF/i
 =5X4l
 -----END PGP SIGNATURE-----
 
 --Sig_/5zKXajwl/lw8Rxqc9sJ=ceH--
State-Changed-From-To: feedback->closed 
State-Changed-By: yongari 
State-Changed-When: Wed Nov 6 04:28:11 UTC 2013 
State-Changed-Why:  
Close, both HEAD and stable have required changes. 
Thanks for confirmation. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=183167 
>Unformatted:
