From nobody@FreeBSD.org  Sun Sep  8 10:25:32 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTP id B78EEEDB
	for <freebsd-gnats-submit@FreeBSD.org>; Sun,  8 Sep 2013 10:25:32 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.freebsd.org (Postfix) with ESMTPS id A60182674
	for <freebsd-gnats-submit@FreeBSD.org>; Sun,  8 Sep 2013 10:25:32 +0000 (UTC)
Received: from oldred.freebsd.org ([127.0.1.6])
	by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id r88APWbI011365
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 8 Sep 2013 10:25:32 GMT
	(envelope-from nobody@oldred.freebsd.org)
Received: (from nobody@localhost)
	by oldred.freebsd.org (8.14.5/8.14.5/Submit) id r88APWmH011362;
	Sun, 8 Sep 2013 10:25:32 GMT
	(envelope-from nobody)
Message-Id: <201309081025.r88APWmH011362@oldred.freebsd.org>
Date: Sun, 8 Sep 2013 10:25:32 GMT
From: Shahar Klein <shahark@mellanox.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: vlan over lagg over mlxen crashes the kernel
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         181931
>Category:       kern
>Synopsis:       [vlan] [lagg] vlan over lagg over mlxen crashes the kernel
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-net
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Sep 08 10:30:00 UTC 2013
>Closed-Date:    
>Last-Modified:  Sun Nov 17 22:30:00 UTC 2013
>Originator:     Shahar Klein
>Release:        9.1
>Organization:
Mellanox
>Environment:
FreeBSD 9.1-RELEASE FreeBSD 9.1-RELEASE root@farrell.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC amd64
>Description:

Creating a vlan over lagg over mlxen crashes the kernel
>How-To-Repeat:

ifconfig lagg0 create
ifconfig lagg0 laggport mlxen0 laggport mlxen1
ifconfig lagg0.400 create
>Fix:
seems like a sanity test is needed entering the rx_vlan handler

--- a/sys/ofed/drivers/net/mlx4/en_netdev.c
+++ b/sys/ofed/drivers/net/mlx4/en_netdev.c
@@ -51,6 +51,9 @@ static void mlx4_en_vlan_rx_add_vid(void *arg, struct net_device *dev, u16 vid)
        int idx;
        u8 field;

+        if (arg != priv)
+                return;
+
        if ((vid == 0) || (vid > 4095))    /* Invalid */
                return;
        en_dbg(HW, priv, "adding VLAN:%d\n", vid);
@@ -72,6 +75,9 @@ static void mlx4_en_vlan_rx_kill_vid(void *arg, struct net_device *dev, u16 vid)
        int idx;
        u8 field;

+        if (arg != priv)
+                return;
+
        if ((vid == 0) || (vid > 4095))    /* Invalid */
                return;
        en_dbg(HW, priv, "Killing VID:%d\n", vid);


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-net 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Sun Sep 8 18:44:40 UTC 2013 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=181931 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/181931: commit references a PR
Date: Sun, 17 Nov 2013 20:58:38 +0000 (UTC)

 Author: alfred
 Date: Sun Nov 17 20:58:31 2013
 New Revision: 258276
 URL: http://svnweb.freebsd.org/changeset/base/258276
 
 Log:
   Fix creating a vlan over lagg over mlxen crash.
   
   PR:		181931
   Submitted by:	Shahar Klein (shahark mellanox.com)
 
 Modified:
   head/sys/ofed/drivers/net/mlx4/en_netdev.c
 
 Modified: head/sys/ofed/drivers/net/mlx4/en_netdev.c
 ==============================================================================
 --- head/sys/ofed/drivers/net/mlx4/en_netdev.c	Sun Nov 17 20:29:33 2013	(r258275)
 +++ head/sys/ofed/drivers/net/mlx4/en_netdev.c	Sun Nov 17 20:58:31 2013	(r258276)
 @@ -52,6 +52,9 @@ static void mlx4_en_vlan_rx_add_vid(void
  	int idx;
  	u8 field;
  
 +	if (arg != priv)
 +		return;
 +
  	if ((vid == 0) || (vid > 4095))    /* Invalid */
  		return;
  	en_dbg(HW, priv, "adding VLAN:%d\n", vid);
 @@ -73,6 +76,9 @@ static void mlx4_en_vlan_rx_kill_vid(voi
  	int idx;
  	u8 field;
  
 +	if (arg != priv)
 +		return;
 +
  	if ((vid == 0) || (vid > 4095))    /* Invalid */
  		return;
  	en_dbg(HW, priv, "Killing VID:%d\n", vid);
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/181931: commit references a PR
Date: Sun, 17 Nov 2013 22:24:42 +0000 (UTC)

 Author: alfred
 Date: Sun Nov 17 22:24:34 2013
 New Revision: 258280
 URL: http://svnweb.freebsd.org/changeset/base/258280
 
 Log:
   MFC:  258276
   
   Fix creating a vlan over lagg over mlxen crash.
   
   PR:             181931
   Submitted by:   Shahar Klein (shahark mellanox.com)
   
   Approved by:	re
 
 Modified:
   stable/10/sys/ofed/drivers/net/mlx4/en_netdev.c
 Directory Properties:
   stable/10/sys/   (props changed)
 
 Modified: stable/10/sys/ofed/drivers/net/mlx4/en_netdev.c
 ==============================================================================
 --- stable/10/sys/ofed/drivers/net/mlx4/en_netdev.c	Sun Nov 17 21:36:19 2013	(r258279)
 +++ stable/10/sys/ofed/drivers/net/mlx4/en_netdev.c	Sun Nov 17 22:24:34 2013	(r258280)
 @@ -52,6 +52,9 @@ static void mlx4_en_vlan_rx_add_vid(void
  	int idx;
  	u8 field;
  
 +	if (arg != priv)
 +		return;
 +
  	if ((vid == 0) || (vid > 4095))    /* Invalid */
  		return;
  	en_dbg(HW, priv, "adding VLAN:%d\n", vid);
 @@ -73,6 +76,9 @@ static void mlx4_en_vlan_rx_kill_vid(voi
  	int idx;
  	u8 field;
  
 +	if (arg != priv)
 +		return;
 +
  	if ((vid == 0) || (vid > 4095))    /* Invalid */
  		return;
  	en_dbg(HW, priv, "Killing VID:%d\n", vid);
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
