From nobody@FreeBSD.org  Fri Sep  6 22:57:15 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTP id E95BDF0D
	for <freebsd-gnats-submit@FreeBSD.org>; Fri,  6 Sep 2013 22:57:15 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.freebsd.org (Postfix) with ESMTPS id D86D42006
	for <freebsd-gnats-submit@FreeBSD.org>; Fri,  6 Sep 2013 22:57:15 +0000 (UTC)
Received: from oldred.freebsd.org ([127.0.1.6])
	by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id r86MvEl9033756
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 6 Sep 2013 22:57:14 GMT
	(envelope-from nobody@oldred.freebsd.org)
Received: (from nobody@localhost)
	by oldred.freebsd.org (8.14.5/8.14.5/Submit) id r86MvEDE033751;
	Fri, 6 Sep 2013 22:57:14 GMT
	(envelope-from nobody)
Message-Id: <201309062257.r86MvEDE033751@oldred.freebsd.org>
Date: Fri, 6 Sep 2013 22:57:14 GMT
From: Fabian Keil <fk@fabiankeil.de>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] Line breaks missing in geli's kern.geom.confxml entries
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         181900
>Category:       kern
>Synopsis:       [geom] [patch] Line breaks missing in geli's kern.geom.confxml entries
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    ae
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Sep 06 23:00:00 UTC 2013
>Closed-Date:    Sat Dec 14 04:21:12 UTC 2013
>Last-Modified:  Sat Dec 14 04:21:12 UTC 2013
>Originator:     Fabian Keil
>Release:        HEAD
>Organization:
>Environment:
FreeBSD r500.local 10.0-CURRENT FreeBSD 10.0-CURRENT #597 r255153+2c13cb0: Fri Sep  6 13:19:19 CEST 2013     fk@r500.local:/usr/obj/usr/src/sys/ZOEY  amd64

>Description:
The attached patch adds two missing line breaks for geli's kern.geom.confxml entries.
>How-To-Repeat:
Attach geli provider, execute sysctl kern.geom.confxml, note missing line breaks for KeysTotal and KeysAllocated.
>Fix:


Patch attached with submission follows:

From 1cf8de8c8b7d0c5b50f681bc8600d06cf57ac24e Mon Sep 17 00:00:00 2001
From: Fabian Keil <fk@fabiankeil.de>
Date: Wed, 4 Sep 2013 15:48:28 +0200
Subject: [PATCH] Add missing line breaks in geli's kern.geom.confxml entries

---
 sys/geom/eli/g_eli.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sys/geom/eli/g_eli.c b/sys/geom/eli/g_eli.c
index d6dcb4f..fc43372 100644
--- a/sys/geom/eli/g_eli.c
+++ b/sys/geom/eli/g_eli.c
@@ -1172,9 +1172,9 @@ g_eli_dumpconf(struct sbuf *sb, const char *indent, struct g_geom *gp,
 	if (pp != NULL || cp != NULL)
 		return;	/* Nothing here. */
 
-	sbuf_printf(sb, "%s<KeysTotal>%ju</KeysTotal>", indent,
+	sbuf_printf(sb, "%s<KeysTotal>%ju</KeysTotal>\n", indent,
 	    (uintmax_t)sc->sc_ekeys_total);
-	sbuf_printf(sb, "%s<KeysAllocated>%ju</KeysAllocated>", indent,
+	sbuf_printf(sb, "%s<KeysAllocated>%ju</KeysAllocated>\n", indent,
 	    (uintmax_t)sc->sc_ekeys_allocated);
 	sbuf_printf(sb, "%s<Flags>", indent);
 	if (sc->sc_flags == 0)
-- 
1.8.2.2



>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-geom 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Sat Sep 7 00:54:31 UTC 2013 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=181900 
State-Changed-From-To: open->patched 
State-Changed-By: ae 
State-Changed-When: Mon Nov 11 11:14:27 UTC 2013 
State-Changed-Why:  
Patched in head/. 


Responsible-Changed-From-To: freebsd-geom->ae 
Responsible-Changed-By: ae 
Responsible-Changed-When: Mon Nov 11 11:14:27 UTC 2013 
Responsible-Changed-Why:  
Take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=181900 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/181900: commit references a PR
Date: Mon, 11 Nov 2013 11:13:22 +0000 (UTC)

 Author: ae
 Date: Mon Nov 11 11:13:12 2013
 New Revision: 257965
 URL: http://svnweb.freebsd.org/changeset/base/257965
 
 Log:
   Add missing line breaks.
   
   PR:		181900
   MFC after:	1 week
 
 Modified:
   head/sys/geom/eli/g_eli.c
 
 Modified: head/sys/geom/eli/g_eli.c
 ==============================================================================
 --- head/sys/geom/eli/g_eli.c	Mon Nov 11 10:54:06 2013	(r257964)
 +++ head/sys/geom/eli/g_eli.c	Mon Nov 11 11:13:12 2013	(r257965)
 @@ -1170,9 +1170,9 @@ g_eli_dumpconf(struct sbuf *sb, const ch
  	if (pp != NULL || cp != NULL)
  		return;	/* Nothing here. */
  
 -	sbuf_printf(sb, "%s<KeysTotal>%ju</KeysTotal>", indent,
 +	sbuf_printf(sb, "%s<KeysTotal>%ju</KeysTotal>\n", indent,
  	    (uintmax_t)sc->sc_ekeys_total);
 -	sbuf_printf(sb, "%s<KeysAllocated>%ju</KeysAllocated>", indent,
 +	sbuf_printf(sb, "%s<KeysAllocated>%ju</KeysAllocated>\n", indent,
  	    (uintmax_t)sc->sc_ekeys_allocated);
  	sbuf_printf(sb, "%s<Flags>", indent);
  	if (sc->sc_flags == 0)
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/181900: commit references a PR
Date: Sat, 14 Dec 2013 04:16:59 +0000 (UTC)

 Author: ae
 Date: Sat Dec 14 04:16:47 2013
 New Revision: 259384
 URL: http://svnweb.freebsd.org/changeset/base/259384
 
 Log:
   MFC r257965:
     Add missing line breaks.
   
     PR:		181900
 
 Modified:
   stable/9/sys/geom/eli/g_eli.c
 Directory Properties:
   stable/9/sys/   (props changed)
 
 Modified: stable/9/sys/geom/eli/g_eli.c
 ==============================================================================
 --- stable/9/sys/geom/eli/g_eli.c	Sat Dec 14 04:16:27 2013	(r259383)
 +++ stable/9/sys/geom/eli/g_eli.c	Sat Dec 14 04:16:47 2013	(r259384)
 @@ -1163,9 +1163,9 @@ g_eli_dumpconf(struct sbuf *sb, const ch
  	if (pp != NULL || cp != NULL)
  		return;	/* Nothing here. */
  
 -	sbuf_printf(sb, "%s<KeysTotal>%ju</KeysTotal>", indent,
 +	sbuf_printf(sb, "%s<KeysTotal>%ju</KeysTotal>\n", indent,
  	    (uintmax_t)sc->sc_ekeys_total);
 -	sbuf_printf(sb, "%s<KeysAllocated>%ju</KeysAllocated>", indent,
 +	sbuf_printf(sb, "%s<KeysAllocated>%ju</KeysAllocated>\n", indent,
  	    (uintmax_t)sc->sc_ekeys_allocated);
  	sbuf_printf(sb, "%s<Flags>", indent);
  	if (sc->sc_flags == 0)
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/181900: commit references a PR
Date: Sat, 14 Dec 2013 04:16:40 +0000 (UTC)

 Author: ae
 Date: Sat Dec 14 04:16:27 2013
 New Revision: 259383
 URL: http://svnweb.freebsd.org/changeset/base/259383
 
 Log:
   MFC r257965:
     Add missing line breaks.
   
     PR:		181900
 
 Modified:
   stable/10/sys/geom/eli/g_eli.c
 Directory Properties:
   stable/10/   (props changed)
 
 Modified: stable/10/sys/geom/eli/g_eli.c
 ==============================================================================
 --- stable/10/sys/geom/eli/g_eli.c	Sat Dec 14 03:08:03 2013	(r259382)
 +++ stable/10/sys/geom/eli/g_eli.c	Sat Dec 14 04:16:27 2013	(r259383)
 @@ -1170,9 +1170,9 @@ g_eli_dumpconf(struct sbuf *sb, const ch
  	if (pp != NULL || cp != NULL)
  		return;	/* Nothing here. */
  
 -	sbuf_printf(sb, "%s<KeysTotal>%ju</KeysTotal>", indent,
 +	sbuf_printf(sb, "%s<KeysTotal>%ju</KeysTotal>\n", indent,
  	    (uintmax_t)sc->sc_ekeys_total);
 -	sbuf_printf(sb, "%s<KeysAllocated>%ju</KeysAllocated>", indent,
 +	sbuf_printf(sb, "%s<KeysAllocated>%ju</KeysAllocated>\n", indent,
  	    (uintmax_t)sc->sc_ekeys_allocated);
  	sbuf_printf(sb, "%s<Flags>", indent);
  	if (sc->sc_flags == 0)
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: ae 
State-Changed-When: Sat Dec 14 04:20:29 UTC 2013 
State-Changed-Why:  
Merged to stable/10 and stable/9. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=181900 
>Unformatted:
