From nobody@FreeBSD.org  Sun Aug 11 11:15:00 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTP id D724D8B9
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 11 Aug 2013 11:15:00 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.freebsd.org (Postfix) with ESMTPS id C57F92043
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 11 Aug 2013 11:15:00 +0000 (UTC)
Received: from oldred.freebsd.org ([127.0.1.6])
	by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id r7BBF0rm007206
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 11 Aug 2013 11:15:00 GMT
	(envelope-from nobody@oldred.freebsd.org)
Received: (from nobody@localhost)
	by oldred.freebsd.org (8.14.5/8.14.5/Submit) id r7BBF0A4007205;
	Sun, 11 Aug 2013 11:15:00 GMT
	(envelope-from nobody)
Message-Id: <201308111115.r7BBF0A4007205@oldred.freebsd.org>
Date: Sun, 11 Aug 2013 11:15:00 GMT
From: shahar klein <shahark@mellanox.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: unloading ipoib crashes the kernel
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         181225
>Category:       kern
>Synopsis:       [infiniband] [patch] unloading ipoib crashes the kernel
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-net
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Aug 11 11:20:00 UTC 2013
>Closed-Date:    Tue Nov 12 21:34:52 UTC 2013
>Last-Modified:  Tue Nov 12 21:40:01 UTC 2013
>Originator:     shahar klein
>Release:        9.1
>Organization:
Mellanox
>Environment:
FreeBSD 9.1-RELEASE #0 r+95f2241: Mon Jul 15 16:48:47 IDT 2013 .../sys/GENERIC amd64
>Description:
When an ipoib interface is up - unloading the ipoib module crashes the kernel
>How-To-Repeat:

bring up a ipoib interface with an IP and unload the ipoib module
>Fix:
a/sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_main.c b/sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_main.c
index abed7fa..f4e6706 100644
--- a/sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_main.c
+++ b/sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_main.c
@@ -1073,6 +1073,8 @@ ipoib_remove_one(struct ib_device *device)
                if (rdma_port_get_link_layer(device, priv->port) != IB_LINK_LAYER_INFINIBAND)
                        continue;

+                ipoib_stop(priv);
+
                ib_unregister_event_handler(&priv->event_handler);

                /* dev_change_flags(priv->dev, priv->dev->flags & ~IFF_UP); */


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-amd64->freebsd-net 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Sun Aug 11 13:40:22 UTC 2013 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=181225 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/181225: commit references a PR
Date: Tue, 20 Aug 2013 18:08:15 +0000 (UTC)

 Author: jhb
 Date: Tue Aug 20 18:08:06 2013
 New Revision: 254576
 URL: http://svnweb.freebsd.org/changeset/base/254576
 
 Log:
   Stop an ipoib interface before detaching it.
   
   PR:		kern/181225
   Submitted by:	Shahar Klein
   Obtained from:	Mellanox
   MFC after:	1 week
 
 Modified:
   head/sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_main.c
 
 Modified: head/sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_main.c
 ==============================================================================
 --- head/sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_main.c	Tue Aug 20 18:06:18 2013	(r254575)
 +++ head/sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_main.c	Tue Aug 20 18:08:06 2013	(r254576)
 @@ -1073,6 +1073,8 @@ ipoib_remove_one(struct ib_device *devic
  		if (rdma_port_get_link_layer(device, priv->port) != IB_LINK_LAYER_INFINIBAND)
  			continue;
  
 +		ipoib_stop(priv);
 +
  		ib_unregister_event_handler(&priv->event_handler);
  
  		/* dev_change_flags(priv->dev, priv->dev->flags & ~IFF_UP); */
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: jhb 
State-Changed-When: Tue Nov 12 21:33:51 UTC 2013 
State-Changed-Why:  
Fix merged to 9. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=181225 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/181225: commit references a PR
Date: Tue, 12 Nov 2013 21:33:13 +0000 (UTC)

 Author: jhb
 Date: Tue Nov 12 21:33:01 2013
 New Revision: 258072
 URL: http://svnweb.freebsd.org/changeset/base/258072
 
 Log:
   MFC 254576: Stop an ipoib interface before detaching it.
   
   PR:		kern/181225
 
 Modified:
   stable/9/sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_main.c
 Directory Properties:
   stable/9/sys/   (props changed)
 
 Modified: stable/9/sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_main.c
 ==============================================================================
 --- stable/9/sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_main.c	Tue Nov 12 21:14:19 2013	(r258071)
 +++ stable/9/sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_main.c	Tue Nov 12 21:33:01 2013	(r258072)
 @@ -1073,6 +1073,8 @@ ipoib_remove_one(struct ib_device *devic
  		if (rdma_port_get_link_layer(device, priv->port) != IB_LINK_LAYER_INFINIBAND)
  			continue;
  
 +		ipoib_stop(priv);
 +
  		ib_unregister_event_handler(&priv->event_handler);
  
  		/* dev_change_flags(priv->dev, priv->dev->flags & ~IFF_UP); */
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
