From nobody@FreeBSD.org  Thu Aug  8 05:41:47 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTP id 57262592
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  8 Aug 2013 05:41:47 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.freebsd.org (Postfix) with ESMTPS id 4552D26E7
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  8 Aug 2013 05:41:47 +0000 (UTC)
Received: from oldred.freebsd.org ([127.0.1.6])
	by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id r785flHh031316
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 8 Aug 2013 05:41:47 GMT
	(envelope-from nobody@oldred.freebsd.org)
Received: (from nobody@localhost)
	by oldred.freebsd.org (8.14.5/8.14.5/Submit) id r785flo0031315;
	Thu, 8 Aug 2013 05:41:47 GMT
	(envelope-from nobody)
Message-Id: <201308080541.r785flo0031315@oldred.freebsd.org>
Date: Thu, 8 Aug 2013 05:41:47 GMT
From: Adrian Chadd <adrian@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [iwn] stream calculation is wrong for the Intel 4965
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         181132
>Category:       kern
>Synopsis:       [iwn] stream calculation is wrong for the Intel 4965
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-wireless
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Aug 08 05:50:00 UTC 2013
>Closed-Date:    
>Last-Modified:  Thu Aug  8 06:00:00 UTC 2013
>Originator:     Adrian Chadd
>Release:        -HEAD
>Organization:
>Environment:
>Description:
When the 4965 probes (and bootverbose is set), it sees 2 transmit radios and 3 receive radios. So it assumes that the hardware is a 2T3R device. Which is actually incorrect - even though it has three receive radios, it's still a two-stream receive device.

>How-To-Repeat:
* Bootverbose!
* Probe/attach an Intel 4965
* See what's going on!
>Fix:
Until Intel 3x3 devices are supported, we should limit the TX/RX stream counts to 2.

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-wireless 
Responsible-Changed-By: adrian 
Responsible-Changed-When: Thu Aug 8 05:51:05 UTC 2013 
Responsible-Changed-Why:  
Changing to owner 


http://www.freebsd.org/cgi/query-pr.cgi?pr=181132 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/181132: commit references a PR
Date: Thu,  8 Aug 2013 05:52:54 +0000 (UTC)

 Author: adrian
 Date: Thu Aug  8 05:52:41 2013
 New Revision: 254085
 URL: http://svnweb.freebsd.org/changeset/base/254085
 
 Log:
   Cap the number of streams supported to two for now.
   
   I haven't yet reviewed the Intel driver(s) in more depth to see if
   there are 1x1 NICs that report they support 2 transmit/receive chains..
   if so then we'll have to update this.
   
   Tested:
   
   * Intel 4965, which is a 2x2 device with 3 RX and 2 TX chains.
   
   PR:		kern/181132
 
 Modified:
   head/sys/dev/iwn/if_iwn.c
 
 Modified: head/sys/dev/iwn/if_iwn.c
 ==============================================================================
 --- head/sys/dev/iwn/if_iwn.c	Thu Aug  8 05:41:55 2013	(r254084)
 +++ head/sys/dev/iwn/if_iwn.c	Thu Aug  8 05:52:41 2013	(r254085)
 @@ -638,6 +638,20 @@ iwn_attach(device_t dev)
  	if (sc->sc_flags & IWN_FLAG_HAS_11N) {
  		ic->ic_rxstream = sc->nrxchains;
  		ic->ic_txstream = sc->ntxchains;
 +
 +		/*
 +		 * The NICs we currently support cap out at 2x2 support
 +		 * separate from the chains being used.
 +		 *
 +		 * This is a total hack to work around that until some
 +		 * per-device method is implemented to return the
 +		 * actual stream support.
 +		 */
 +		if (ic->ic_rxstream > 2)
 +			ic->ic_rxstream = 2;
 +		if (ic->ic_txstream > 2)
 +			ic->ic_txstream = 2;
 +
  		ic->ic_htcaps =
  			  IEEE80211_HTCAP_SMPS_OFF	/* SMPS mode disabled */
  			| IEEE80211_HTCAP_SHORTGI20	/* short GI in 20MHz */
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
