From julio+host-mastodon-jmmv@meroh.net  Sun Jul 14 17:20:49 2013
Return-Path: <julio+host-mastodon-jmmv@meroh.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	by hub.freebsd.org (Postfix) with ESMTP id 4C3ACAC8
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 14 Jul 2013 17:20:49 +0000 (UTC)
	(envelope-from julio+host-mastodon-jmmv@meroh.net)
Received: from hrndva-omtalb.mail.rr.com (hrndva-omtalb.mail.rr.com [71.74.56.122])
	by mx1.freebsd.org (Postfix) with ESMTP id E8F2AA2B
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 14 Jul 2013 17:20:48 +0000 (UTC)
Received: from [108.176.158.82] ([108.176.158.82:65529] helo=portal.meroh.net)
	by hrndva-oedge02.mail.rr.com (envelope-from <julio+host-mastodon-jmmv@meroh.net>)
	(ecelerity 2.2.3.46 r()) with ESMTP
	id A7/A4-21735-9EDD2E15; Sun, 14 Jul 2013 17:20:41 +0000
Received: from mastodon.meroh.net (mastodon.meroh.net [192.168.1.12])
	by portal.meroh.net (Postfix) with ESMTP id D5979EFE67
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 14 Jul 2013 13:20:37 -0400 (EDT)
Received: from mastodon.meroh.net (localhost [127.0.0.1])
	by mastodon.meroh.net (8.14.7/8.14.7) with ESMTP id r6EHKU1c085035
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 14 Jul 2013 13:20:30 -0400 (EDT)
	(envelope-from jmmv@mastodon.meroh.net)
Received: (from jmmv@localhost)
	by mastodon.meroh.net (8.14.7/8.14.7/Submit) id r6EHKUPK085034;
	Sun, 14 Jul 2013 13:20:30 -0400 (EDT)
	(envelope-from jmmv)
Message-Id: <201307141720.r6EHKUPK085034@mastodon.meroh.net>
Date: Sun, 14 Jul 2013 13:20:30 -0400 (EDT)
From: Julio Merino <julio+host-mastodon-jmmv@meroh.net>
Reply-To: Julio Merino <julio+host-mastodon-jmmv@meroh.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Change syscons to support consoles at 1920x1200
X-Send-Pr-Version: 3.114
X-GNATS-Notify:

>Number:         180558
>Category:       kern
>Synopsis:       [syscons] [patch] Change syscons to support consoles at 1920x1200
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    jmmv
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jul 14 17:30:01 UTC 2013
>Closed-Date:    Sun Mar 02 01:48:01 UTC 2014
>Last-Modified:  Sun Mar  2 11:40:12 UTC 2014
>Originator:     Julio Merino
>Release:        FreeBSD 10.0-CURRENT powerpc
>Organization:
>Environment:
System: FreeBSD mastodon.meroh.net 10.0-CURRENT FreeBSD 10.0-CURRENT #0: Sun Jun 30 08:05:23 UTC 2013 root@snap.freebsd.org:/usr/obj/powerpc.powerpc64/usr/src/sys/GENERIC64 powerpc


	
>Description:
	This is a followup PR from:

        http://lists.freebsd.org/pipermail/freebsd-ppc/2013-April/006236.html

        My original problem description said:

	-----
        I have a PowerMac attached to a 24" widescreen capable of
        1920x1200 at 60Hz.  The graphics card is an nVidia GeForce FX
        5200 Ultra (NV34).
	
        OpenFirmware properly sets up the screen to its highest
        resolution and uses the full display to show the console.
	
        When FreeBSD powerpc64 9.1 boots, I get a 4:3 console centered
        on the screen.  According to the monitor's built-in information
        panel, however, the screen is properly set up to 1920x1200.
        This makes me believe that FreeBSD is correctly setting the
        display to its native resolution but, for some reason, forces
        the console to be 4:3 (which is a 72 lines by 99 columns).
	-----

	As it turns out, and as nwhitehorn@ pointed out in a reply, the
	problem comes from a hardcoded limit in syscons that at the
	moment is set to support consoles on 1600x1200 displays at most.

	Given that screens with a native resolution of 1920x1200 are
	very common today (24"), I would like to request that the
	default value of COL in syscons is bumped to support them
	properly -- hence this PR.
>How-To-Repeat:
	Boot FreeBSD powerpc64 on a machine with a display that has a
	native resolution of, at least, 1920x1200.

	The fact that I'm experiencing this on powerpc64 is irrelevant
	given that the problem is in the generic syscons code.
>Fix:
	syscons should probably not have such a hardcoded limit.
	However, fixing that is out of scope for this PR and deserves
	its own report.
	
	The following does the trick for me:

Index: syscons.h
===================================================================
--- syscons.h	(revision 253339)
+++ syscons.h	(working copy)
@@ -145,9 +145,9 @@
 /*
    The following #defines are hard-coded for a maximum text
    resolution corresponding to a maximum framebuffer
-   resolution of 1600x1200 with an 8x8 font...
+   resolution of 1920x1200 with an 8x8 font...
 */
-#define	COL		200
+#define	COL		240
 #define	ROW		150
 
 #define PCBURST		128
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->jmmv 
Responsible-Changed-By: jmmv 
Responsible-Changed-When: Tue Feb 25 02:44:50 UTC 2014 
Responsible-Changed-Why:  
I should try to deal with this now that I'm a committer! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=180558 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/180558: commit references a PR
Date: Tue, 25 Feb 2014 13:48:13 +0000 (UTC)

 Author: jmmv
 Date: Tue Feb 25 13:48:05 2014
 New Revision: 262480
 URL: http://svnweb.freebsd.org/changeset/base/262480
 
 Log:
   Increase maximum number of columns to support 1980x1200 displays.
   
   In my specific case, this fixes the problem of my PowerMac G5 displaying a
   4:3 console on a 16:10 display with black bars on the left and right.
   
   PR:		kern/180558
   Reviewed by:	nwhitehorn
   MFC after:	5 days
 
 Modified:
   head/sys/dev/syscons/syscons.h
 
 Modified: head/sys/dev/syscons/syscons.h
 ==============================================================================
 --- head/sys/dev/syscons/syscons.h	Tue Feb 25 12:13:11 2014	(r262479)
 +++ head/sys/dev/syscons/syscons.h	Tue Feb 25 13:48:05 2014	(r262480)
 @@ -145,9 +145,9 @@
  /*
     The following #defines are hard-coded for a maximum text
     resolution corresponding to a maximum framebuffer
 -   resolution of 1600x1200 with an 8x8 font...
 +   resolution of 1980x1200 with an 8x8 font...
  */
 -#define	COL		200
 +#define	COL		240
  #define	ROW		150
  
  #define PCBURST		128
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/180558: commit references a PR
Date: Tue, 25 Feb 2014 23:04:47 +0000 (UTC)

 Author: jmmv
 Date: Tue Feb 25 23:04:39 2014
 New Revision: 262502
 URL: http://svnweb.freebsd.org/changeset/base/262502
 
 Log:
   Fix comment introduced in r262480: it's 1920x1200, not 1980x1200.
   
   PR:		kern/180558
   MFC after:	5 days
 
 Modified:
   head/sys/dev/syscons/syscons.h
 
 Modified: head/sys/dev/syscons/syscons.h
 ==============================================================================
 --- head/sys/dev/syscons/syscons.h	Tue Feb 25 23:03:48 2014	(r262501)
 +++ head/sys/dev/syscons/syscons.h	Tue Feb 25 23:04:39 2014	(r262502)
 @@ -145,7 +145,7 @@
  /*
     The following #defines are hard-coded for a maximum text
     resolution corresponding to a maximum framebuffer
 -   resolution of 1980x1200 with an 8x8 font...
 +   resolution of 1920x1200 with an 8x8 font...
  */
  #define	COL		240
  #define	ROW		150
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: jmmv 
State-Changed-When: Sun Mar 2 01:47:43 UTC 2014 
State-Changed-Why:  
Fixed and MFCd into stable/10. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=180558 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/180558: commit references a PR
Date: Sun,  2 Mar 2014 11:39:51 +0000 (UTC)

 Author: jmmv
 Date: Sun Mar  2 01:46:44 2014
 New Revision: 262674
 URL: http://svnweb.freebsd.org/changeset/base/262674
 
 Log:
   Increase maximum number of columns to support 1920x1200 displays.
   
   This is a MFC of r262480 and r262502.
   
   Please note that this is changing a constant in a header file so it
   could affect ABIs.  However, as far as I can tell, this is apparently
   only used in code to declare static arrays and thus it should be safe
   to change...
   
   PR:		kern/180558
 
 Modified:
   stable/10/sys/dev/syscons/syscons.h
 Directory Properties:
   stable/10/   (props changed)
 
 Modified: stable/10/sys/dev/syscons/syscons.h
 ==============================================================================
 --- stable/10/sys/dev/syscons/syscons.h	Sun Mar  2 00:47:47 2014	(r262673)
 +++ stable/10/sys/dev/syscons/syscons.h	Sun Mar  2 01:46:44 2014	(r262674)
 @@ -145,9 +145,9 @@
  /*
     The following #defines are hard-coded for a maximum text
     resolution corresponding to a maximum framebuffer
 -   resolution of 1600x1200 with an 8x8 font...
 +   resolution of 1920x1200 with an 8x8 font...
  */
 -#define	COL		200
 +#define	COL		240
  #define	ROW		150
  
  #define PCBURST		128
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
