From nobody@FreeBSD.org  Wed Jun 19 20:36:16 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	by hub.freebsd.org (Postfix) with ESMTP id BB2914D4
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 19 Jun 2013 20:36:16 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121])
	by mx1.freebsd.org (Postfix) with ESMTP id AD2061D84
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 19 Jun 2013 20:36:16 +0000 (UTC)
Received: from oldred.freebsd.org ([127.0.1.6])
	by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id r5JKaGGU072078
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 19 Jun 2013 20:36:16 GMT
	(envelope-from nobody@oldred.freebsd.org)
Received: (from nobody@localhost)
	by oldred.freebsd.org (8.14.5/8.14.5/Submit) id r5JKaG6n072065;
	Wed, 19 Jun 2013 20:36:16 GMT
	(envelope-from nobody)
Message-Id: <201306192036.r5JKaG6n072065@oldred.freebsd.org>
Date: Wed, 19 Jun 2013 20:36:16 GMT
From: Renato Botelho <garga@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: lagg interfaces loses capabilities when protocol changes
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         179733
>Category:       kern
>Synopsis:       [lagg] [patch] interface loses capabilities when protocol changes
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-net
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jun 19 20:40:00 UTC 2013
>Closed-Date:    
>Last-Modified:  Wed Jun 19 21:01:24 UTC 2013
>Originator:     Renato Botelho
>Release:        10-current
>Organization:
ESF
>Environment:
FreeBSD freebsd1.localdomain 10.0-CURRENT FreeBSD 10.0-CURRENT #2 r250859M: Wed May 22 10:15:21 BRT 2013     root@freebsd1.localdomain:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
When you change laggproto of a lagg interface, it loses all capabilities except VLAN_HWFILTER.

I don't know if the patch I'm sending is the correct fix, but it worked on my test environment.
>How-To-Repeat:
# ifconfig lagg0 create
# ifconfig lagg0 laggproto lacp laggport NIC1 laggport NIC2

# ifconfig lagg0 | grep capabilities
capabilities=1389b<RXCSUM,TXCSUM,VLAN_MTU,VLAN_HWTAGGING,VLAN_HWCSUM,WOL_UCAST,WOL_MCAST,WOL_MAGIC,VLAN_HWFILTER>

# ifconfig lagg0 laggproto loadbalance

# ifconfig lagg0 | grep capabilities
capabilities=10000<VLAN_HWFILTER>
>Fix:
Index: sys/net/if_lagg.c
===================================================================
--- sys/net/if_lagg.c	(revision 252002)
+++ sys/net/if_lagg.c	(working copy)
@@ -997,6 +997,7 @@
 				sc->sc_proto = lagg_protos[i].ti_proto;
 				if (sc->sc_proto != LAGG_PROTO_NONE)
 					error = lagg_protos[i].ti_attach(sc);
+				lagg_capabilities(sc);
 				LAGG_WUNLOCK(sc);
 				return (error);
 			}


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-net 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Wed Jun 19 21:00:53 UTC 2013 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=179733 
>Unformatted:
