From nobody@FreeBSD.org  Sun May 12 18:39:10 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
	by hub.freebsd.org (Postfix) with ESMTP id F3880340
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 12 May 2013 18:39:09 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from oldred.FreeBSD.org (oldred.freebsd.org [8.8.178.121])
	by mx1.freebsd.org (Postfix) with ESMTP id E5D8D90E
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 12 May 2013 18:39:09 +0000 (UTC)
Received: from oldred.FreeBSD.org ([127.0.1.6])
	by oldred.FreeBSD.org (8.14.5/8.14.5) with ESMTP id r4CId7JR002434
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 12 May 2013 18:39:07 GMT
	(envelope-from nobody@oldred.FreeBSD.org)
Received: (from nobody@localhost)
	by oldred.FreeBSD.org (8.14.5/8.14.5/Submit) id r4CId7Z2002433;
	Sun, 12 May 2013 18:39:07 GMT
	(envelope-from nobody)
Message-Id: <201305121839.r4CId7Z2002433@oldred.FreeBSD.org>
Date: Sun, 12 May 2013 18:39:07 GMT
From: Trond Endrestol <trond.endrestol@ximalas.info>
To: freebsd-gnats-submit@FreeBSD.org
Subject: kern.geom.confdot contains superfluous semicolon at the end of the last curly brace
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         178540
>Category:       kern
>Synopsis:       [geom] [patch] kern.geom.confdot contains superfluous semicolon at the end of the last curly brace
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    jh
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun May 12 18:40:01 UTC 2013
>Closed-Date:    Mon Jun 03 16:26:51 UTC 2013
>Last-Modified:  Mon Jun 03 16:26:51 UTC 2013
>Originator:     Trond Endrestol
>Release:        10.0-CURRENT
>Organization:
Private
>Environment:
FreeBSD freebsd10.bsd.net 10.0-CURRENT FreeBSD 10.0-CURRENT #0 r250558: Sun May 12 14:32:16 CEST 2013     root@freebsd10.bsd.net:/usr/obj/usr/src/sys/VBOX  amd64
>Description:
The sysctl kern.geom.confdot contains a superfluous semicolon after the last curly brace, making the dot utility from graphics/graphviz complain like this:

Warning: <stdin>:1: syntax error in line 1 near ';'
>How-To-Repeat:
Install graphics/graphviz and run:

sysctl -n kern.geom.confdot | dot -Tps > geom.ps
>Fix:
Remove the offending semicolon from sys/geom/geom_dump.c:

--- geom_dump.c.orig    2013-04-26 17:16:50.000000000 +0200
+++ geom_dump.c 2013-05-12 20:28:40.369226016 +0200
@@ -105,7 +105,7 @@
        sbuf_printf(sb, "digraph geom {\n");
        LIST_FOREACH(mp, &g_classes, class)
                g_confdot_class(sb, mp);
-       sbuf_printf(sb, "};\n");
+       sbuf_printf(sb, "}\n");
        sbuf_finish(sb);
 }


Patch attached with submission follows:

--- geom_dump.c.orig	2013-04-26 17:16:50.000000000 +0200
+++ geom_dump.c	2013-05-12 20:28:40.369226016 +0200
@@ -105,7 +105,7 @@
 	sbuf_printf(sb, "digraph geom {\n");
 	LIST_FOREACH(mp, &g_classes, class)
 		g_confdot_class(sb, mp);
-	sbuf_printf(sb, "};\n");
+	sbuf_printf(sb, "}\n");
 	sbuf_finish(sb);
 }
 


>Release-Note:
>Audit-Trail:

From: Trond Endrestol <trond.endrestol@ximalas.info>
To: freebsd-gnats-submit@FreeBSD.org
Cc:  
Subject: kern/178540: kern.geom.confdot contains superfluous semicolon at the
 end of the last curly brace
Date: Sun, 12 May 2013 18:39:07 GMT

 >Number:         178540
 >Category:       kern
 >Synopsis:       kern.geom.confdot contains superfluous semicolon at the end of the last curly brace
 >Confidential:   no
 >Severity:       non-critical
 >Priority:       low
 >Responsible:    freebsd-bugs
 >State:          open
 >Quarter:        
 >Keywords:       
 >Date-Required:
 >Class:          sw-bug
 >Submitter-Id:   current-users
 >Arrival-Date:   Sun May 12 18:40:01 UTC 2013
 >Closed-Date:
 >Last-Modified:
 >Originator:     Trond Endrestol
 >Release:        10.0-CURRENT
 >Organization:
 Private
 >Environment:
 FreeBSD freebsd10.bsd.net 10.0-CURRENT FreeBSD 10.0-CURRENT #0 r250558: Sun May 12 14:32:16 CEST 2013     root@freebsd10.bsd.net:/usr/obj/usr/src/sys/VBOX  amd64
 >Description:
 The sysctl kern.geom.confdot contains a superfluous semicolon after the last curly brace, making the dot utility from graphics/graphviz complain like this:
 
 Warning: <stdin>:1: syntax error in line 1 near ';'
 >How-To-Repeat:
 Install graphics/graphviz and run:
 
 sysctl -n kern.geom.confdot | dot -Tps > geom.ps
 >Fix:
 Remove the offending semicolon from sys/geom/geom_dump.c:
 
 --- geom_dump.c.orig    2013-04-26 17:16:50.000000000 +0200
 +++ geom_dump.c 2013-05-12 20:28:40.369226016 +0200
 @@ -105,7 +105,7 @@
         sbuf_printf(sb, "digraph geom {\n");
         LIST_FOREACH(mp, &g_classes, class)
                 g_confdot_class(sb, mp);
 -       sbuf_printf(sb, "};\n");
 +       sbuf_printf(sb, "}\n");
         sbuf_finish(sb);
  }
 
 
 Patch attached with submission follows:
 
 --- geom_dump.c.orig	2013-04-26 17:16:50.000000000 +0200
 +++ geom_dump.c	2013-05-12 20:28:40.369226016 +0200
 @@ -105,7 +105,7 @@
  	sbuf_printf(sb, "digraph geom {\n");
  	LIST_FOREACH(mp, &g_classes, class)
  		g_confdot_class(sb, mp);
 -	sbuf_printf(sb, "};\n");
 +	sbuf_printf(sb, "}\n");
  	sbuf_finish(sb);
  }
  
 
 
 >Release-Note:
 >Audit-Trail:
 >Unformatted:
 _______________________________________________
 freebsd-bugs@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
 To unsubscribe, send any mail to "freebsd-bugs-unsubscribe@freebsd.org"
Responsible-Changed-From-To: freebsd-bugs->freebsd-geom 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Mon May 20 03:25:50 UTC 2013 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=178540 
Responsible-Changed-From-To: freebsd-geom->jh 
Responsible-Changed-By: jh 
Responsible-Changed-When: Tue May 21 17:19:59 UTC 2013 
Responsible-Changed-Why:  
Take. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=178540 
State-Changed-From-To: open->patched 
State-Changed-By: jh 
State-Changed-When: Tue May 21 18:41:23 UTC 2013 
State-Changed-Why:  
Patched in head (r250868). Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=178540 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/178540: commit references a PR
Date: Tue, 21 May 2013 18:41:06 +0000 (UTC)

 Author: jh
 Date: Tue May 21 18:40:54 2013
 New Revision: 250868
 URL: http://svnweb.freebsd.org/changeset/base/250868
 
 Log:
   Remove an extra semicolon from the DOT language output.
   
   PR:		kern/178540
   Submitted by:	Trond Endrestol
   MFC after:	1 week
 
 Modified:
   head/sys/geom/geom_dump.c
 
 Modified: head/sys/geom/geom_dump.c
 ==============================================================================
 --- head/sys/geom/geom_dump.c	Tue May 21 18:38:09 2013	(r250867)
 +++ head/sys/geom/geom_dump.c	Tue May 21 18:40:54 2013	(r250868)
 @@ -105,7 +105,7 @@ g_confdot(void *p, int flag )
  	sbuf_printf(sb, "digraph geom {\n");
  	LIST_FOREACH(mp, &g_classes, class)
  		g_confdot_class(sb, mp);
 -	sbuf_printf(sb, "};\n");
 +	sbuf_printf(sb, "}\n");
  	sbuf_finish(sb);
  }
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/178540: commit references a PR
Date: Mon,  3 Jun 2013 16:09:36 +0000 (UTC)

 Author: jh
 Date: Mon Jun  3 16:09:23 2013
 New Revision: 251303
 URL: http://svnweb.freebsd.org/changeset/base/251303
 
 Log:
   MFC r250868: Remove an extra semicolon from the DOT language output.
   
   PR:		kern/178540
 
 Modified:
   stable/9/sys/geom/geom_dump.c
 Directory Properties:
   stable/9/sys/   (props changed)
 
 Modified: stable/9/sys/geom/geom_dump.c
 ==============================================================================
 --- stable/9/sys/geom/geom_dump.c	Mon Jun  3 16:05:34 2013	(r251302)
 +++ stable/9/sys/geom/geom_dump.c	Mon Jun  3 16:09:23 2013	(r251303)
 @@ -104,7 +104,7 @@ g_confdot(void *p, int flag )
  	sbuf_printf(sb, "digraph geom {\n");
  	LIST_FOREACH(mp, &g_classes, class)
  		g_confdot_class(sb, mp);
 -	sbuf_printf(sb, "};\n");
 +	sbuf_printf(sb, "}\n");
  	sbuf_finish(sb);
  }
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/178540: commit references a PR
Date: Mon,  3 Jun 2013 16:10:42 +0000 (UTC)

 Author: jh
 Date: Mon Jun  3 16:10:30 2013
 New Revision: 251304
 URL: http://svnweb.freebsd.org/changeset/base/251304
 
 Log:
   MFC r250868: Remove an extra semicolon from the DOT language output.
   
   PR:		kern/178540
 
 Modified:
   stable/8/sys/geom/geom_dump.c
 Directory Properties:
   stable/8/sys/   (props changed)
   stable/8/sys/geom/   (props changed)
 
 Modified: stable/8/sys/geom/geom_dump.c
 ==============================================================================
 --- stable/8/sys/geom/geom_dump.c	Mon Jun  3 16:09:23 2013	(r251303)
 +++ stable/8/sys/geom/geom_dump.c	Mon Jun  3 16:10:30 2013	(r251304)
 @@ -104,7 +104,7 @@ g_confdot(void *p, int flag )
  	sbuf_printf(sb, "digraph geom {\n");
  	LIST_FOREACH(mp, &g_classes, class)
  		g_confdot_class(sb, mp);
 -	sbuf_printf(sb, "};\n");
 +	sbuf_printf(sb, "}\n");
  	sbuf_finish(sb);
  }
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: jh 
State-Changed-When: Mon Jun 3 16:26:49 UTC 2013 
State-Changed-Why:  
Fixed in head, stable/9 and stable/8. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=178540 
>Unformatted:
