From nobody@FreeBSD.org  Wed May  8 05:54:34 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	by hub.freebsd.org (Postfix) with ESMTP id 7D2A1B46
	for <freebsd-gnats-submit@FreeBSD.org>; Wed,  8 May 2013 05:54:34 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from oldred.FreeBSD.org (oldred.freebsd.org [8.8.178.121])
	by mx1.freebsd.org (Postfix) with ESMTP id 707867C2
	for <freebsd-gnats-submit@FreeBSD.org>; Wed,  8 May 2013 05:54:34 +0000 (UTC)
Received: from oldred.FreeBSD.org ([127.0.1.6])
	by oldred.FreeBSD.org (8.14.5/8.14.5) with ESMTP id r485sXQJ025282
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 8 May 2013 05:54:33 GMT
	(envelope-from nobody@oldred.FreeBSD.org)
Received: (from nobody@localhost)
	by oldred.FreeBSD.org (8.14.5/8.14.5/Submit) id r485sXUM025281;
	Wed, 8 May 2013 05:54:33 GMT
	(envelope-from nobody)
Message-Id: <201305080554.r485sXUM025281@oldred.FreeBSD.org>
Date: Wed, 8 May 2013 05:54:33 GMT
From: Vladimir <v.chernyadev@tradesoft.ru>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Coredump when smbfs mounted
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         178412
>Category:       kern
>Synopsis:       [smbfs] Coredump when smbfs mounted
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    ae
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed May 08 06:00:00 UTC 2013
>Closed-Date:    Fri May 02 21:46:59 UTC 2014
>Last-Modified:  Fri May 02 21:46:59 UTC 2014
>Originator:     Vladimir
>Release:        9.1 amd64, 8.2 amd64
>Organization:
Tradesoft LLC
>Environment:
FreeBSD 9.1-RELEASE FreeBSD 9.1-RELEASE #0 r243825: Tue Dec  4 09:23:10 UTC 2012     root@farrell.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  amd64

>Description:
When mounted many smbfs like this:
# mount
//MNTUSER@PC1/WINSHARE1 on /home/pc1 (smbfs, noatime)
//MNTUSER@PC2/WINSHARE2 on /home/pc2 (smbfs, noatime)
//MNTUSER@PC3/WINSHARE3 on /home/pc3 (smbfs, noatime)
//MNTUSER@PC4/WINSHARE4 on /home/pc4 (smbfs, noatime)
(and so on)

And users and FreeBSD are actively using WINSHAREX (/home/pcX), then if some of these Windows PC's shuts down without unmount, the FreeBSD may reboot or going to the coredump. When mounted more than 10 smbfs, the reboots may repeated each day. Else reboots 1-2 times at week.
>How-To-Repeat:
Mount many smbfs (10 or better 20), simulate some reads and writes both on Windows and FreeBSD. Randomly turn on and off the Windows PC's wihout unmount smbfs.
>Fix:


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-fs 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Wed May 8 21:31:55 UTC 2013 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=178412 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/178412: commit references a PR
Date: Thu, 17 Apr 2014 12:22:13 +0000 (UTC)

 Author: ae
 Date: Thu Apr 17 12:22:08 2014
 New Revision: 264600
 URL: http://svnweb.freebsd.org/changeset/base/264600
 
 Log:
   Remove redundant unlock.
   
   This code was removed from the opensolaris and darwin's
   netsmb implementations, in DfBSD it also has been disabled.
   
   PR:		36566, 87859, 139407, 161579, 175557, 178412, 186652
   MFC after:	2 weeks
   Sponsored by:	Yandex LLC
 
 Modified:
   head/sys/netsmb/smb_iod.c
 
 Modified: head/sys/netsmb/smb_iod.c
 ==============================================================================
 --- head/sys/netsmb/smb_iod.c	Thu Apr 17 12:16:51 2014	(r264599)
 +++ head/sys/netsmb/smb_iod.c	Thu Apr 17 12:22:08 2014	(r264600)
 @@ -87,8 +87,6 @@ smb_iod_invrq(struct smbiod *iod)
  	 */
  	SMB_IOD_RQLOCK(iod);
  	TAILQ_FOREACH(rqp, &iod->iod_rqlist, sr_link) {
 -		if (rqp->sr_flags & SMBR_INTERNAL)
 -			SMBRQ_SUNLOCK(rqp);
  		rqp->sr_flags |= SMBR_RESTART;
  		smb_iod_rqprocessed(rqp, ENOTCONN);
  	}
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: ae 
State-Changed-When: Fri May 2 21:45:49 UTC 2014 
State-Changed-Why:  
Fixed in head/ and stable/10. 


Responsible-Changed-From-To: freebsd-fs->ae 
Responsible-Changed-By: ae 
Responsible-Changed-When: Fri May 2 21:45:49 UTC 2014 
Responsible-Changed-Why:  
Take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=178412 
>Unformatted:
