From nobody@FreeBSD.org  Sat May  4 00:56:07 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
	by hub.freebsd.org (Postfix) with ESMTP id 18F57B6
	for <freebsd-gnats-submit@FreeBSD.org>; Sat,  4 May 2013 00:56:07 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [69.147.83.34])
	by mx1.freebsd.org (Postfix) with ESMTP id 0C95C1D7C
	for <freebsd-gnats-submit@FreeBSD.org>; Sat,  4 May 2013 00:56:07 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.5/8.14.5) with ESMTP id r440u3NA064106
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 4 May 2013 00:56:03 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.5/8.14.5/Submit) id r440u3Gi064105;
	Sat, 4 May 2013 00:56:03 GMT
	(envelope-from nobody)
Message-Id: <201305040056.r440u3Gi064105@red.freebsd.org>
Date: Sat, 4 May 2013 00:56:03 GMT
From: Adam Nowacki <nowak@tepeserwery.pl>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [zfs] extended attributes leak 
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         178329
>Category:       kern
>Synopsis:       [zfs] extended attributes leak
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-fs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat May 04 01:00:00 UTC 2013
>Closed-Date:    
>Last-Modified:  Sat May  4 22:10:00 UTC 2013
>Originator:     Adam Nowacki
>Release:        9.1-RELEASE
>Organization:
>Environment:
FreeBSD storage 9.1-RELEASE FreeBSD 9.1-RELEASE #5: Tue Apr 30 15:08:36 UTC 2013     root@storage:/usr/obj/usr/src/sys/GENERIC  amd64

>Description:
ZFS objects used to store extended attributes are not deleted when parent file/directory is deleted. Those objects still occupy disk space but are otherwise unreferenced and can't be deleted.

So far I've traced it down to sys\cddl\contrib\opensolaris\uts\common\fs\zfs\zfs_dir.c:zfs_rmnode.
ZTOV(zp) is NULL for extended attributes directory (object 9) so zfs_purgedir is not called and object 10 is left alone.
>How-To-Repeat:
# zfs create -o mountpoint=/test root/test
# touch /test/file1
# setextattr user test abc /test/file1
# zdb root/test
    Object  lvl   iblk   dblk  dsize  lsize   %full  type
         8    1    16K    512      0    512    0.00  ZFS plain file
         9    1    16K    512     1K    512  100.00  ZFS directory
        10    1    16K    512    512    512  100.00  ZFS plain file

object 8 - the file,
object 9 - extended attributes directory,
object 10 - value of the 'test' extended attribute ("abc")

# rm /test/file1
# zdb root/test

    Object  lvl   iblk   dblk  dsize  lsize   %full  type
        10    1    16K    512    512    512  100.00  ZFS plain file

objects 8 and 9 are deleted, object 10 is still there (leaked). 
>Fix:


>Release-Note:
>Audit-Trail:

From: Andriy Gapon <avg@FreeBSD.org>
To: bug-followup@FreeBSD.org, nowak@tepeserwery.pl
Cc:  
Subject: Re: kern/178329: [zfs] extended attributes leak
Date: Sat, 04 May 2013 20:26:19 +0300

 Can not reproduce with head code.
 
 -- 
 Andriy Gapon
Responsible-Changed-From-To: freebsd-bugs->freebsd-fs 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Sat May 4 21:38:43 UTC 2013 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=178329 

From: Adam Nowacki <nowak@tepeserwery.pl>
To: Andriy Gapon <avg@FreeBSD.org>
Cc: bug-followup@FreeBSD.org
Subject: Re: kern/178329: [zfs] extended attributes leak
Date: Sun, 05 May 2013 00:00:36 +0200

 On 2013-05-04 19:26, Andriy Gapon wrote:
 > Can not reproduce with head code.
 
 Appears to be fixed in 9.1-STABLE too.
 
 But the problem of already leaked objects remain:
 1) zpool scrub will not delete leaked objects,
 2) zfs send will include leaked objects.
 
 Maybe patch scrub to detect and remove leaked objects (sysctl flag 
 disabled by default)?
>Unformatted:
