From nobody@FreeBSD.org  Mon Mar 25 23:01:45 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
	by hub.freebsd.org (Postfix) with ESMTP id AE5EFE9A
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 25 Mar 2013 23:01:45 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 9FE0D86F
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 25 Mar 2013 23:01:45 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.5/8.14.5) with ESMTP id r2PN1jrQ076090
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 25 Mar 2013 23:01:45 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.5/8.14.5/Submit) id r2PN1jqk076074;
	Mon, 25 Mar 2013 23:01:45 GMT
	(envelope-from nobody)
Message-Id: <201303252301.r2PN1jqk076074@red.freebsd.org>
Date: Mon, 25 Mar 2013 23:01:45 GMT
From: hiren panchasara <hiren.panchasara@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] Updating igb manpage/code with info about num_queues
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         177384
>Category:       kern
>Synopsis:       [igb] [patch] Updating igb manpage/code with info about num_queues
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    sbruno
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Mar 25 23:10:00 UTC 2013
>Closed-Date:    Thu Apr 04 15:20:05 UTC 2013
>Last-Modified:  Thu Apr 04 15:20:05 UTC 2013
>Originator:     hiren panchasara
>Release:        current
>Organization:
>Environment:
10.0-CURRENT FreeBSD 10.0-CURRENT #1 r248555: Wed Mar 20 15:00:20 UTC 2013
>Description:
Updating manpage and source file for igb to specify tunable num_queues.
>How-To-Repeat:

>Fix:
Index: share/man/man4/igb.4
===================================================================
--- share/man/man4/igb.4        (revision 248708)
+++ share/man/man4/igb.4        (working copy)
@@ -31,7 +31,7 @@
 .\"
 .\" $FreeBSD$
 .\"
-.Dd May 12, 2012
+.Dd March 25, 2013
 .Dt IGB 4
 .Os
 .Sh NAME
@@ -160,6 +160,11 @@
 .It Va hw.igb.enable_aim
 If set to 1, enable Adaptive Interrupt Moderation.
 The default is to enable Adaptive Interrupt Moderation.
+.It Va hw.igb.num_queues
+Numer of queues used for data transfer.
+If set to 0, number of queues will be configured
+automatically based on number of CPUs and max
+supported MSI-X messages on the device.
 .It Va kern.ipc.nmbclusters
 The maximum number of mbuf clusters allowed.
 If the system has more than one igb card or jumbo frames are
Index: sys/dev/e1000/if_igb.c
===================================================================
--- sys/dev/e1000/if_igb.c      (revision 248708)
+++ sys/dev/e1000/if_igb.c      (working copy)
@@ -375,7 +375,8 @@
 
 /*
 ** This will autoconfigure based on
-** the number of CPUs if left at 0.
+** the number of CPUs and max supported MSI-X messages
+** if left at 0.
 */
 static int igb_num_queues = 0;
 TUNABLE_INT("hw.igb.num_queues", &igb_num_queues);


>Release-Note:
>Audit-Trail:

From: hiren panchasara <hiren.panchasara@gmail.com>
To: FreeBSD-gnats-submit@freebsd.org, freebsd-bugs@freebsd.org
Cc: jfvogel@gmail.com
Subject: Re: kern/177384: [patch] Updating igb manpage/code with info about num_queues
Date: Mon, 25 Mar 2013 16:53:01 -0700

 + Jack (maintainer)
 
 On Mon, Mar 25, 2013 at 4:10 PM,  <FreeBSD-gnats-submit@freebsd.org> wrote:
 > Thank you very much for your problem report.
 > It has the internal identification `kern/177384'.
 > The individual assigned to look at your
 > report is: freebsd-bugs.
 >
 > You can access the state of your problem report at any time
 > via this link:
 >
 > http://www.freebsd.org/cgi/query-pr.cgi?pr=177384
 >
 >>Category:       kern
 >>Responsible:    freebsd-bugs
 >>Synopsis:       [patch] Updating igb manpage/code with info about num_queues
 >>Arrival-Date:   Mon Mar 25 23:10:00 UTC 2013
Responsible-Changed-From-To: freebsd-bugs->freebsd-net 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Wed Mar 27 01:46:24 UTC 2013 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=177384 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/177384: commit references a PR
Date: Wed,  3 Apr 2013 21:55:27 +0000 (UTC)

 Author: sbruno
 Date: Wed Apr  3 21:55:19 2013
 New Revision: 249070
 URL: http://svnweb.freebsd.org/changeset/base/249070
 
 Log:
   Update man page for igb(4) with a little bit of information about
   hw.igb.num_queues for those so inclined.
   
   PR:		kern/177384
   Submitted by:	hiren.panchasara@gmail.com
   Reviewed by:	sbruno@
   Approved by:	jfv@
   Obtained from:	Yahoo! Inc.
   MFC after:	2 weeks
 
 Modified:
   head/share/man/man4/igb.4
   head/sys/dev/e1000/if_igb.c
 
 Modified: head/share/man/man4/igb.4
 ==============================================================================
 --- head/share/man/man4/igb.4	Wed Apr  3 21:34:35 2013	(r249069)
 +++ head/share/man/man4/igb.4	Wed Apr  3 21:55:19 2013	(r249070)
 @@ -31,7 +31,7 @@
  .\"
  .\" $FreeBSD$
  .\"
 -.Dd May 12, 2012
 +.Dd March 25, 2013
  .Dt IGB 4
  .Os
  .Sh NAME
 @@ -160,6 +160,11 @@ The minimum is 80, and the maximum is 40
  .It Va hw.igb.enable_aim
  If set to 1, enable Adaptive Interrupt Moderation.
  The default is to enable Adaptive Interrupt Moderation.
 +.It Va hw.igb.num_queues
 +Numer of queues used for data transfer.
 +If set to 0, number of queues will be configured
 +automatically based on number of CPUs and max
 +supported MSI-X messages on the device.
  .It Va kern.ipc.nmbclusters
  The maximum number of mbuf clusters allowed.
  If the system has more than one igb card or jumbo frames are
 
 Modified: head/sys/dev/e1000/if_igb.c
 ==============================================================================
 --- head/sys/dev/e1000/if_igb.c	Wed Apr  3 21:34:35 2013	(r249069)
 +++ head/sys/dev/e1000/if_igb.c	Wed Apr  3 21:55:19 2013	(r249070)
 @@ -375,7 +375,8 @@ SYSCTL_INT(_hw_igb, OID_AUTO, header_spl
  
  /*
  ** This will autoconfigure based on
 -** the number of CPUs if left at 0.
 +** the number of CPUs and max supported MSI-X messages
 +** if left at 0.
  */
  static int igb_num_queues = 0;
  TUNABLE_INT("hw.igb.num_queues", &igb_num_queues);
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: sbruno 
State-Changed-When: Thu Apr 4 15:17:58 UTC 2013 
State-Changed-Why:  
This has been resolved on current and will be sent to stable/8 and  
stable/9 via MFC 


Responsible-Changed-From-To: freebsd-net->sbruno 
Responsible-Changed-By: sbruno 
Responsible-Changed-When: Thu Apr 4 15:17:58 UTC 2013 
Responsible-Changed-Why:  
This has been resolved on current and will be sent to stable/8 and  
stable/9 via MFC 

http://www.freebsd.org/cgi/query-pr.cgi?pr=177384 
>Unformatted:
