From nobody@FreeBSD.org  Wed Mar 20 18:57:24 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	by hub.freebsd.org (Postfix) with ESMTP id CA37A5F4
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 20 Mar 2013 18:57:24 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id BBD32E30
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 20 Mar 2013 18:57:24 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.5/8.14.5) with ESMTP id r2KIvOmk055490
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 20 Mar 2013 18:57:24 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.5/8.14.5/Submit) id r2KIvOBq055489;
	Wed, 20 Mar 2013 18:57:24 GMT
	(envelope-from nobody)
Message-Id: <201303201857.r2KIvOBq055489@red.freebsd.org>
Date: Wed, 20 Mar 2013 18:57:24 GMT
From: hiren panchasara <hiren.panchasara@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] Fixing clang warnings at /sys/dev/vxge
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         177151
>Category:       kern
>Synopsis:       [patch] Fixing clang warnings at /sys/dev/vxge
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:
>Keywords:
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Mar 20 19:00:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     hiren panchasara
>Release:        current
>Organization:
>Environment:
10.0-CURRENT FreeBSD 10.0-CURRENT #1 r248555: Wed Mar 20 15:00:20 UTC 2013
>Description:
Fixing a couple of clang warnings:
1) In vxgehal-virtualpath.c - redundant parenthesis
2) In vxgehal-mgmtaux.c -
warning: comparison of constant 4294967295 with expression of type
       'vxge_debug_level_e' (aka 'enum vxge_debug_level_e') is always false

It was comparing dev_config->debug_level which is 2^23 i.e. 4294967295 with VXGE_HAL_USE_FLASH_DEFAULT which is 0xffffffff.

Compare function looks like this:

#define __HAL_AUX_CONFIG_ENTRY(key, value, fmt) \
    if (value == VXGE_HAL_USE_FLASH_DEFAULT) { \ 
        __HAL_AUX_ENTRY(key, "FLASH DEFAULT", "%s"); \
    } else { \ 
        __HAL_AUX_ENTRY(key, value,
                        fmt); \
    }

I am removing the "if" from here because that is what clang is complaining about as its unnecessary.

>How-To-Repeat:
cd sys/dev/vxge
make 

and you will see the warnings from clang.
>Fix:
Index: sys/dev/vxge/vxgehal/vxgehal-mgmtaux.c
===================================================================
--- sys/dev/vxge/vxgehal/vxgehal-mgmtaux.c      (revision 248555)
+++ sys/dev/vxge/vxgehal/vxgehal-mgmtaux.c      (working copy)
@@ -687,7 +687,7 @@
            dev_config->stats_read_method, "%u");
        __HAL_AUX_CONFIG_ENTRY("Device Poll Timeout",
            dev_config->device_poll_millis, "%u");
-       __HAL_AUX_CONFIG_ENTRY("debug_level",
+       __HAL_AUX_ENTRY("debug_level",
            dev_config->debug_level, "%u");
        __HAL_AUX_CONFIG_ENTRY("debug_mask",
            dev_config->debug_mask, "%u");
Index: sys/dev/vxge/vxgehal/vxgehal-virtualpath.c
===================================================================
--- sys/dev/vxge/vxgehal/vxgehal-virtualpath.c  (revision 248555)
+++ sys/dev/vxge/vxgehal/vxgehal-virtualpath.c  (working copy)
@@ -7307,11 +7307,11 @@
 
        if (
 #if defined(VXGE_EMULATED_INTA)
-           (hldev->header.config.intr_mode ==
-           VXGE_HAL_INTR_MODE_EMULATED_INTA) ||
+           hldev->header.config.intr_mode ==
+           VXGE_HAL_INTR_MODE_EMULATED_INTA ||
 #endif
-           (hldev->header.config.intr_mode ==
-           VXGE_HAL_INTR_MODE_MSIX_ONE_SHOT)) {
+           hldev->header.config.intr_mode ==
+           VXGE_HAL_INTR_MODE_MSIX_ONE_SHOT) {
                vxge_hal_pio_mem_write32_upper(hldev->header.pdev,
                    hldev->header.regh0, (u32) bVAL32(
                    VXGE_HAL_ONE_SHOT_VECT1_EN_ONE_SHOT_VECT1_EN, 0),
@@ -7380,11 +7380,11 @@
 
        if (
 #if defined(VXGE_EMULATED_INTA)
-           (hldev->header.config.intr_mode ==
-           VXGE_HAL_INTR_MODE_EMULATED_INTA) ||
+           hldev->header.config.intr_mode ==
+           VXGE_HAL_INTR_MODE_EMULATED_INTA ||
 #endif
-           (hldev->header.config.intr_mode ==
-           VXGE_HAL_INTR_MODE_MSIX_ONE_SHOT)) {
+           hldev->header.config.intr_mode ==
+           VXGE_HAL_INTR_MODE_MSIX_ONE_SHOT) {
                vxge_hal_pio_mem_write32_upper(hldev->header.pdev,
                    hldev->header.regh0,
                    (u32) bVAL32(mBIT((msix_id >> 2)), 0),


>Release-Note:
>Audit-Trail:
>Unformatted:
