From lidl@hydra.pix.net  Mon Mar 18 15:30:08 2013
Return-Path: <lidl@hydra.pix.net>
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
	by hub.freebsd.org (Postfix) with ESMTP id 844277C6
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 18 Mar 2013 15:30:08 +0000 (UTC)
	(envelope-from lidl@hydra.pix.net)
Received: from hydra.pix.net (hydra.pix.net [IPv6:2001:470:e254::3c])
	by mx1.freebsd.org (Postfix) with ESMTP id 5E4A12A4
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 18 Mar 2013 15:30:08 +0000 (UTC)
Received: from hydra.pix.net (localhost [127.0.0.1])
	by hydra.pix.net (8.14.5/8.14.5) with ESMTP id r2IFU6BK049391
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 18 Mar 2013 11:30:06 -0400 (EDT)
	(envelope-from lidl@hydra.pix.net)
Received: (from lidl@localhost)
	by hydra.pix.net (8.14.5/8.14.5/Submit) id r2IFU66r049390;
	Mon, 18 Mar 2013 11:30:06 -0400 (EDT)
	(envelope-from lidl)
Message-Id: <201303181530.r2IFU66r049390@hydra.pix.net>
Date: Mon, 18 Mar 2013 11:30:06 -0400 (EDT)
From: Kurt Lidl <lidl@pix.net>
Reply-To: Kurt Lidl <lidl@pix.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: AMT serial port for X79 chipset does not attach
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         177072
>Category:       kern
>Synopsis:       [uart] [patch] AMT serial port for X79 chipset does not attach
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    eadler
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Mar 18 15:40:02 UTC 2013
>Closed-Date:    Tue Apr 30 02:08:05 UTC 2013
>Last-Modified:  Wed Apr 16 18:10:01 UTC 2014
>Originator:     Kurt Lidl
>Release:        FreeBSD FreeBSD 10.0-CURRENT amd64
>Organization:
Pix.Com Technologies, LLC
>Environment:
System: FreeBSD xxxx.pix.net 10.0-CURRENT FreeBSD 10.0-CURRENT #2: Sun Mar 17 22:43:32 EDT 2013     lidl@xxxx.pix.net:/usr/obj/usr/src/sys/GENERIC  amd64

This was sync'd to svn at svn r248325.

>Description:

The AMT serial port on the C600/X79 chipset is not attached
to the uart driver at boot.

>How-To-Repeat:

Boot machine with X79 chipset, notice:
pci0: <simple comms> at device 22.0 (no driver attached)

>Fix:

Apply the following patch:

diff -r fecb548fe499 sys/dev/uart/uart_bus_pci.c
--- a/sys/dev/uart/uart_bus_pci.c	Fri Mar 15 13:56:19 2013 -0400
+++ b/sys/dev/uart/uart_bus_pci.c	Sun Mar 17 23:48:29 2013 -0400
@@ -114,6 +114,7 @@
 { 0x14e4, 0x4344, 0xffff, 0, "Sony Ericsson GC89 PC Card", 0x10},
 { 0x151f, 0x0000, 0xffff, 0, "TOPIC Semiconductor TP560 56k modem", 0x10 },
 { 0x8086, 0x1c3d, 0xffff, 0, "Intel AMT - KT Controller", 0x10 },
+{ 0x8086, 0x1d3d, 0xffff, 0, "Intel C600/X79 Series Chipset KT Controller", 0x10 },
 { 0x8086, 0x2e17, 0xffff, 0, "4 Series Chipset Serial KT Controller", 0x10 },
 { 0x8086, 0x3b67, 0xffff, 0, "5 Series/3400 Series Chipset KT Controller",
 	0x10 },
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->eadler 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Mon Mar 18 15:41:00 UTC 2013 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=177072 

From: Andriy Gapon <avg@FreeBSD.org>
To: bug-followup@FreeBSD.org, lidl@pix.net
Cc:  
Subject: Re: kern/177072: AMT serial port for X79 chipset does not attach
Date: Mon, 18 Mar 2013 23:37:05 +0200

 Are you sure that that hardware device has anything to do with uart driver?
 
 -- 
 Andriy Gapon

From: Kurt Lidl <lidl@pix.net>
To: Andriy Gapon <avg@FreeBSD.org>
Cc: bug-followup@FreeBSD.org
Subject: Re: kern/177072: AMT serial port for X79 chipset does not attach
Date: Mon, 18 Mar 2013 20:45:02 -0400

 On Mon, Mar 18, 2013 at 11:37:05PM +0200, Andriy Gapon wrote:
 > Are you sure that that hardware device has anything to do with uart driver?
 
 Well, once I had it attached as a uart device, identified like this
 in the dmesg:
 
 uart2: <Non-standard ns8250 class UART with FIFOs> port 0x9100-0x9107 mem 0xeff24000-0xeff24fff irq 17 at device 22.3 on pci0
 uart2: console (115200,n,8,1)
 
 I could then start a getty on it, and login over an AMT serial-over-lan
 session.
 
 So, I'm going with 'yes', it's relevant.
 
 -Kurt

From: Andriy Gapon <avg@FreeBSD.org>
To: Kurt Lidl <lidl@pix.net>
Cc: bug-followup@FreeBSD.org
Subject: Re: kern/177072: AMT serial port for X79 chipset does not attach
Date: Tue, 19 Mar 2013 11:02:55 +0200

 on 19/03/2013 02:45 Kurt Lidl said the following:
 > On Mon, Mar 18, 2013 at 11:37:05PM +0200, Andriy Gapon wrote:
 >> Are you sure that that hardware device has anything to do with uart driver?
 > 
 > Well, once I had it attached as a uart device, identified like this
 > in the dmesg:
 > 
 > uart2: <Non-standard ns8250 class UART with FIFOs> port 0x9100-0x9107 mem 0xeff24000-0xeff24fff irq 17 at device 22.3 on pci0
 > uart2: console (115200,n,8,1)
 > 
 > I could then start a getty on it, and login over an AMT serial-over-lan
 > session.
 > 
 > So, I'm going with 'yes', it's relevant.
 
 OK, thank you.
 It was just not clear from the original PR text that that was the correct
 "simple comms".
 
 
 -- 
 Andriy Gapon

From: Kurt Lidl <kurt.lidl@cello.com>
To: bug-followup@FreeBSD.org, lidl@pix.net
Cc:  
Subject: Re: kern/177072: [uart] [patch] AMT serial port for X79 chipset does
 not attach
Date: Thu, 18 Apr 2013 16:32:29 -0400

 Any chance this could be committed?
 
 Are there other details that are needed before this can be done?
 
 Thanks.
 -Kurt
State-Changed-From-To: open->analyzed 
State-Changed-By: eadler 
State-Changed-When: Thu Apr 18 23:38:28 UTC 2013 
State-Changed-Why:  
awaiting approval or review prior to commit (no action needed from 
submitter) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=177072 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/177072: commit references a PR
Date: Tue, 23 Apr 2013 13:04:09 +0000 (UTC)

 Author: eadler
 Date: Tue Apr 23 13:03:08 2013
 New Revision: 249803
 URL: http://svnweb.freebsd.org/changeset/base/249803
 
 Log:
   Add support for Intel C600/X79 Series Chipset KT Controller.
   
   PR:		kern/177072
   Submitted by:	Kurt Lidl <lidl@pix.net>
 
 Modified:
   head/sys/dev/uart/uart_bus_pci.c
 
 Modified: head/sys/dev/uart/uart_bus_pci.c
 ==============================================================================
 --- head/sys/dev/uart/uart_bus_pci.c	Tue Apr 23 13:03:03 2013	(r249802)
 +++ head/sys/dev/uart/uart_bus_pci.c	Tue Apr 23 13:03:08 2013	(r249803)
 @@ -114,6 +114,7 @@ static const struct pci_id pci_ns8250_id
  { 0x14e4, 0x4344, 0xffff, 0, "Sony Ericsson GC89 PC Card", 0x10},
  { 0x151f, 0x0000, 0xffff, 0, "TOPIC Semiconductor TP560 56k modem", 0x10 },
  { 0x8086, 0x1c3d, 0xffff, 0, "Intel AMT - KT Controller", 0x10 },
 +{ 0x8086, 0x1d3d, 0xffff, 0, "Intel C600/X79 Series Chipset KT Controller", 0x10 },
  { 0x8086, 0x2e17, 0xffff, 0, "4 Series Chipset Serial KT Controller", 0x10 },
  { 0x8086, 0x3b67, 0xffff, 0, "5 Series/3400 Series Chipset KT Controller",
  	0x10 },
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: analyzed->patched 
State-Changed-By: eadler 
State-Changed-When: Tue Apr 23 13:23:12 UTC 2013 
State-Changed-Why:  
committed 

http://www.freebsd.org/cgi/query-pr.cgi?pr=177072 
State-Changed-From-To: patched->closed 
State-Changed-By: eadler 
State-Changed-When: Tue Apr 30 02:08:05 UTC 2013 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=177072 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/177072: commit references a PR
Date: Wed, 16 Apr 2014 18:09:14 +0000 (UTC)

 Author: eadler
 Date: Wed Apr 16 18:09:11 2014
 New Revision: 264547
 URL: http://svnweb.freebsd.org/changeset/base/264547
 
 Log:
   MFC r249803:
   
   	Add support for Intel C600/X79 Series Chipset KT Controller.
   
   PR:		kern/177072
 
 Modified:
   stable/9/sys/dev/uart/uart_bus_pci.c
 Directory Properties:
   stable/9/sys/   (props changed)
   stable/9/sys/dev/   (props changed)
 
 Modified: stable/9/sys/dev/uart/uart_bus_pci.c
 ==============================================================================
 --- stable/9/sys/dev/uart/uart_bus_pci.c	Wed Apr 16 17:57:08 2014	(r264546)
 +++ stable/9/sys/dev/uart/uart_bus_pci.c	Wed Apr 16 18:09:11 2014	(r264547)
 @@ -114,6 +114,7 @@ static const struct pci_id pci_ns8250_id
  { 0x14e4, 0x4344, 0xffff, 0, "Sony Ericsson GC89 PC Card", 0x10},
  { 0x151f, 0x0000, 0xffff, 0, "TOPIC Semiconductor TP560 56k modem", 0x10 },
  { 0x8086, 0x1c3d, 0xffff, 0, "Intel AMT - KT Controller", 0x10 },
 +{ 0x8086, 0x1d3d, 0xffff, 0, "Intel C600/X79 Series Chipset KT Controller", 0x10 },
  { 0x8086, 0x2e17, 0xffff, 0, "4 Series Chipset Serial KT Controller", 0x10 },
  { 0x8086, 0x3b67, 0xffff, 0, "5 Series/3400 Series Chipset KT Controller",
  	0x10 },
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/177072: commit references a PR
Date: Wed, 16 Apr 2014 18:09:43 +0000 (UTC)

 Author: eadler
 Date: Wed Apr 16 18:09:39 2014
 New Revision: 264548
 URL: http://svnweb.freebsd.org/changeset/base/264548
 
 Log:
   MFC r249803:
   
   	Add support for Intel C600/X79 Series Chipset KT Controller.
   
   PR:		kern/177072
 
 Modified:
   stable/8/sys/dev/uart/uart_bus_pci.c
 Directory Properties:
   stable/8/sys/   (props changed)
   stable/8/sys/dev/   (props changed)
   stable/8/sys/dev/uart/   (props changed)
 
 Modified: stable/8/sys/dev/uart/uart_bus_pci.c
 ==============================================================================
 --- stable/8/sys/dev/uart/uart_bus_pci.c	Wed Apr 16 18:09:11 2014	(r264547)
 +++ stable/8/sys/dev/uart/uart_bus_pci.c	Wed Apr 16 18:09:39 2014	(r264548)
 @@ -114,6 +114,7 @@ static const struct pci_id pci_ns8250_id
  { 0x14e4, 0x4344, 0xffff, 0, "Sony Ericsson GC89 PC Card", 0x10},
  { 0x151f, 0x0000, 0xffff, 0, "TOPIC Semiconductor TP560 56k modem", 0x10 },
  { 0x8086, 0x1c3d, 0xffff, 0, "Intel AMT - KT Controller", 0x10 },
 +{ 0x8086, 0x1d3d, 0xffff, 0, "Intel C600/X79 Series Chipset KT Controller", 0x10 },
  { 0x8086, 0x2e17, 0xffff, 0, "4 Series Chipset Serial KT Controller", 0x10 },
  { 0x8086, 0x3b67, 0xffff, 0, "5 Series/3400 Series Chipset KT Controller",
  	0x10 },
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
