From nobody@FreeBSD.org  Wed Mar  6 23:33:52 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	by hub.freebsd.org (Postfix) with ESMTP id D549D5B0
	for <freebsd-gnats-submit@FreeBSD.org>; Wed,  6 Mar 2013 23:33:52 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id B18D6134
	for <freebsd-gnats-submit@FreeBSD.org>; Wed,  6 Mar 2013 23:33:52 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.5/8.14.5) with ESMTP id r26NXqqO066058
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 6 Mar 2013 23:33:52 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.5/8.14.5/Submit) id r26NXqAx066057;
	Wed, 6 Mar 2013 23:33:52 GMT
	(envelope-from nobody)
Message-Id: <201303062333.r26NXqAx066057@red.freebsd.org>
Date: Wed, 6 Mar 2013 23:33:52 GMT
From: Hiren Panchasara <hiren.panchasara@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] Fixing clang warnings at different places 
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         176712
>Category:       kern
>Synopsis:       [patch] Fixing clang warnings at different places
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    hiren
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Mar 06 23:40:00 UTC 2013
>Closed-Date:    Sun May 04 04:04:57 UTC 2014
>Last-Modified:  Sun May 04 04:04:57 UTC 2014
>Originator:     Hiren Panchasara
>Release:        current
>Organization:
>Environment:
freebsd current
>Description:
http://www.strugglingcoder.info/patches/clang_warnings_dev_acpi_support.txt
http://www.strugglingcoder.info/patches/clang_warnings_dev_ata.txt
http://www.strugglingcoder.info/patches/clang_warnings_dev_bktr.txt
http://www.strugglingcoder.info/patches/clang_warnings_dev_bwn.txt
http://www.strugglingcoder.info/patches/clang_warnings_dev_drm.txt

Here are a bunch of patches to fix warnings on freebsd-head.

Here is the tread where it was discussed on current: http://lists.freebsd.org/pipermail/freebsd-current/2013-January/039078.html

cheers,
Hiren
>How-To-Repeat:

>Fix:


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-amd64->freebsd-bugs 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Thu Mar 7 16:32:04 UTC 2013 
Responsible-Changed-Why:  
reclassify. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=176712 
Responsible-Changed-From-To: freebsd-bugs->eadler 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Sun Mar 17 02:52:55 UTC 2013 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=176712 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/176712: commit references a PR
Date: Tue, 23 Apr 2013 13:03:24 +0000 (UTC)

 Author: eadler
 Date: Tue Apr 23 13:02:55 2013
 New Revision: 249799
 URL: http://svnweb.freebsd.org/changeset/base/249799
 
 Log:
   Remove always-true conditions from if statement.
   
   PR:		kern/176712
   Submitted by:	Hiren Panchasara <hiren.panchasara@gmail.com>
   Approved by:	cperciva (mentor)
 
 Modified:
   head/sys/dev/drm/mach64_dma.c
 
 Modified: head/sys/dev/drm/mach64_dma.c
 ==============================================================================
 --- head/sys/dev/drm/mach64_dma.c	Tue Apr 23 13:02:51 2013	(r249798)
 +++ head/sys/dev/drm/mach64_dma.c	Tue Apr 23 13:02:55 2013	(r249799)
 @@ -512,7 +512,7 @@ void mach64_dump_ring_info(drm_mach64_pr
  
  	DRM_INFO("\n");
  
 -	if (ring->head >= 0 && ring->head < ring->size / sizeof(u32)) {
 +       if (ring->head < ring->size / sizeof(u32)) {
  		struct list_head *ptr;
  		u32 addr = le32_to_cpu(((u32 *) ring->start)[ring->head + 1]);
  
 @@ -1276,7 +1276,7 @@ int mach64_do_dispatch_pseudo_dma(drm_ma
  			entry = list_entry(ptr, drm_mach64_freelist_t, list);
  			buf = entry->buf;
  			offset = buf_addr - GETBUFADDR(buf);
 -			if (offset >= 0 && offset < MACH64_BUFFER_SIZE) {
 +                       if (offset < MACH64_BUFFER_SIZE) {
  				found = 1;
  				break;
  			}
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/176712: commit references a PR
Date: Tue, 23 Apr 2013 13:03:01 +0000 (UTC)

 Author: eadler
 Date: Tue Apr 23 13:02:48 2013
 New Revision: 249797
 URL: http://svnweb.freebsd.org/changeset/base/249797
 
 Log:
   Remove tautological compare.
   
   PR:		kern/176712
   Submitted by:	Hiren Panchasara <hiren.panchasara@gmail.com>
   Approved by:	cperciva (mentor)
 
 Modified:
   head/sys/dev/acpi_support/acpi_toshiba.c
 
 Modified: head/sys/dev/acpi_support/acpi_toshiba.c
 ==============================================================================
 --- head/sys/dev/acpi_support/acpi_toshiba.c	Tue Apr 23 10:48:14 2013	(r249796)
 +++ head/sys/dev/acpi_support/acpi_toshiba.c	Tue Apr 23 13:02:48 2013	(r249797)
 @@ -324,7 +324,7 @@ hci_force_fan(ACPI_HANDLE h, int op, UIN
  
  	ACPI_SERIAL_ASSERT(toshiba);
  	if (op == HCI_SET) {
 -		if (*state < 0 || *state > 1)
 +               if (*state > 1)
  			return (EINVAL);
  		*state <<= HCI_FAN_SHIFT;
  	}
 @@ -368,7 +368,7 @@ hci_lcd_brightness(ACPI_HANDLE h, int op
  
  	ACPI_SERIAL_ASSERT(toshiba);
  	if (op == HCI_SET) {
 -		if (*brightness < 0 || *brightness > HCI_LCD_BRIGHTNESS_MAX)
 +               if (*brightness > HCI_LCD_BRIGHTNESS_MAX)
  			return (EINVAL);
  		*brightness <<= HCI_LCD_BRIGHTNESS_SHIFT;
  	}
 @@ -384,7 +384,7 @@ hci_lcd_backlight(ACPI_HANDLE h, int op,
  
  	ACPI_SERIAL_ASSERT(toshiba);
  	if (op == HCI_SET) {
 -		if (*backlight < 0 || *backlight > 1)
 +               if (*backlight > 1)
  			return (EINVAL);
  	}
  	return (hci_call(h, op, HCI_REG_LCD_BACKLIGHT, backlight));
 @@ -397,7 +397,7 @@ hci_cpu_speed(ACPI_HANDLE h, int op, UIN
  
  	ACPI_SERIAL_ASSERT(toshiba);
  	if (op == HCI_SET) {
 -		if (*speed < 0 || *speed > HCI_CPU_SPEED_MAX)
 +               if (*speed > HCI_CPU_SPEED_MAX)
  			return (EINVAL);
  		*speed <<= HCI_CPU_SPEED_SHIFT;
  	}
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/176712: commit references a PR
Date: Tue, 23 Apr 2013 13:03:30 +0000 (UTC)

 Author: eadler
 Date: Tue Apr 23 13:02:57 2013
 New Revision: 249800
 URL: http://svnweb.freebsd.org/changeset/base/249800
 
 Log:
   Avoid warning about uninitalized variable
   
   PR:		kern/176712
   Submitted by:	Hiren Panchasara <hiren.panchasara@gmail.com> (earlier vesion)
   Approved by:	cperciva (mentor)
 
 Modified:
   head/sys/dev/bwn/if_bwn.c
 
 Modified: head/sys/dev/bwn/if_bwn.c
 ==============================================================================
 --- head/sys/dev/bwn/if_bwn.c	Tue Apr 23 13:02:55 2013	(r249799)
 +++ head/sys/dev/bwn/if_bwn.c	Tue Apr 23 13:02:57 2013	(r249800)
 @@ -9183,6 +9183,7 @@ bwn_dma_newbuf(struct bwn_dma_ring *dr, 
  	struct mbuf *m;
  	int error;
  
 +	paddr = 0;
  	m = m_getcl(M_NOWAIT, MT_DATA, M_PKTHDR);
  	if (m == NULL) {
  		error = ENOBUFS;
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/176712: commit references a PR
Date: Tue, 23 Apr 2013 13:03:14 +0000 (UTC)

 Author: eadler
 Date: Tue Apr 23 13:02:51 2013
 New Revision: 249798
 URL: http://svnweb.freebsd.org/changeset/base/249798
 
 Log:
   Make temp, temp1 the same type that they will later be used for.
   
   PR:		kern/176712
   Submitted by:	Hiren Panchasara <hiren.panchasara@gmail.com>
   Reviewed by:	jmg (earlier version)
   Approved by:	cperciva (mentor)
 
 Modified:
   head/sys/dev/bktr/bktr_core.c
 
 Modified: head/sys/dev/bktr/bktr_core.c
 ==============================================================================
 --- head/sys/dev/bktr/bktr_core.c	Tue Apr 23 13:02:48 2013	(r249797)
 +++ head/sys/dev/bktr/bktr_core.c	Tue Apr 23 13:02:51 2013	(r249798)
 @@ -1936,7 +1936,7 @@ int
  tuner_ioctl( bktr_ptr_t bktr, int unit, ioctl_cmd_t cmd, caddr_t arg, struct thread* td )
  {
  	int		tmp_int;
 -	unsigned int	temp, temp1;
 +       int             temp, temp1;
  	int		offset;
  	int		count;
  	u_char		*buf;
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->patched 
State-Changed-By: eadler 
State-Changed-When: Tue Apr 23 13:24:59 UTC 2013 
State-Changed-Why:  
committed in r249799 

http://www.freebsd.org/cgi/query-pr.cgi?pr=176712 
Responsible-Changed-From-To: eadler->hiren 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Tue Apr 23 16:35:13 UTC 2013 
Responsible-Changed-Why:  
reverted in r249812 - over to submitter 

http://www.freebsd.org/cgi/query-pr.cgi?pr=176712 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/176712: commit references a PR
Date: Mon,  6 May 2013 21:57:52 +0000 (UTC)

 Author: hiren
 Date: Mon May  6 21:57:44 2013
 New Revision: 250314
 URL: http://svnweb.freebsd.org/changeset/base/250314
 
 Log:
   Fixing a clang warning about using uninitialized variable.
   
   PR: 176712
   Suggested by:	jhb
   Approved by:	sbruno (mentor)
 
 Modified:
   head/sys/dev/bwn/if_bwn.c
 
 Modified: head/sys/dev/bwn/if_bwn.c
 ==============================================================================
 --- head/sys/dev/bwn/if_bwn.c	Mon May  6 21:44:06 2013	(r250313)
 +++ head/sys/dev/bwn/if_bwn.c	Mon May  6 21:57:44 2013	(r250314)
 @@ -9242,7 +9242,7 @@ back:
  	/*
  	 * Setup RX buf descriptor
  	 */
 -	dr->setdesc(dr, desc, paddr, meta->mt_m->m_len -
 +	dr->setdesc(dr, desc, meta->mt_paddr, meta->mt_m->m_len -
  	    sizeof(*hdr), 0, 0, 0);
  	return (error);
  }
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: linimon 
State-Changed-When: Sun May 4 04:04:10 UTC 2014 
State-Changed-Why:  
committed over 1 year ago. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=176712 
>Unformatted:
