From nobody@FreeBSD.org  Sat Mar  2 04:45:47 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	by hub.freebsd.org (Postfix) with ESMTP id 8461A4BF
	for <freebsd-gnats-submit@FreeBSD.org>; Sat,  2 Mar 2013 04:45:47 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 60FD898E
	for <freebsd-gnats-submit@FreeBSD.org>; Sat,  2 Mar 2013 04:45:47 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.5/8.14.5) with ESMTP id r224jkI6067537
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 2 Mar 2013 04:45:46 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.5/8.14.5/Submit) id r224jkBo067536;
	Sat, 2 Mar 2013 04:45:46 GMT
	(envelope-from nobody)
Message-Id: <201303020445.r224jkBo067536@red.freebsd.org>
Date: Sat, 2 Mar 2013 04:45:46 GMT
From: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Crash with IPv6 and Firewire
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         176596
>Category:       kern
>Synopsis:       [firewire] [ip6] Crash with IPv6 and Firewire
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    ae
>State:          patched
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Mar 02 04:50:00 UTC 2013
>Closed-Date:    
>Last-Modified:  Fri Nov 22 04:47:40 UTC 2013
>Originator:     YOSHIFUJI Hideaki
>Release:        9.1-RELEASE
>Organization:
USAGI Project / WIDE Project
>Environment:
FreeBSD 9.1-RELEASE r243826

>Description:
When try to ping6 peer (addreess is fe80::1, for example) over firewire, it immediately crashes.

Stack trace is as follows:

kbd_backtrace
panic
trap_fatal
trap_pfault
trap
calltrap
nd6_llinfo_settimer_locked
nd6_na_input
icmp6_input
ip6_input
netisr_dispatch_src
netisr_dispatch
firewire_input
fwip_unicast_input
fw_rcv
fwohci_arcv
fwohci_task_dma
taskqueue_run_locked

>How-To-Repeat:
Let ${peer_eui64} EUI-64 of your peer on fwip0, then
$ ping6 fe80::${peer_eui64}%fwip0

>Fix:


>Release-Note:
>Audit-Trail:

From: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
To: bug-followup@FreeBSD.org, yoshfuji@linux-ipv6.org
Cc:  
Subject: Re: kern/176596: Crash with IPv6 and Firewire
Date: Sat, 02 Mar 2013 14:18:10 +0900

 See full stack trace at:
 https://twitter.com/yoshfuji/status/307707100627337216/photo/1
Responsible-Changed-From-To: freebsd-bugs->freebsd-net 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Sat Mar 2 23:34:38 UTC 2013 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=176596 
Responsible-Changed-From-To: freebsd-net->ae 
Responsible-Changed-By: ae 
Responsible-Changed-When: Fri Jun 14 15:40:18 UTC 2013 
Responsible-Changed-Why:  
Take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=176596 

From: "Andrey V. Elsukov" <ae@FreeBSD.org>
To: bug-followup@FreeBSD.org, yoshfuji@linux-ipv6.org
Cc:  
Subject: Re: kern/176596: [firewire] [ip6] Crash with IPv6 and Firewire
Date: Sun, 30 Jun 2013 20:25:19 +0400

 Hi,
 
 It seems to me, that in the nd6_cache_lladdr() function at the lines:
 
 1592         if (lladdr) {           /* (3-5) and (7) */
 1593                 /*
 1594                  * Record source link-layer address
 1595                  * XXX is it dependent to ifp->if_type?
 1596                  */
 1597                 bcopy(lladdr, &ln->ll_addr, ifp->if_addrlen);
 
 bcopy overwrites part of lle_timer struct and then this triggers panic
 in the callout_reset().
 
 -- 
 WBR, Andrey V. Elsukov
State-Changed-From-To: open->analyzed 
State-Changed-By: ae 
State-Changed-When: Sun Jun 30 21:50:35 UTC 2013 
State-Changed-Why:  
fwip(4) has 16-bytes sized hw address, but struct llenetry 
expects only 8-bytes. In the nd6_cache_lladdr() occurs 
overwriting of lle_timer field and this leads to panic in 
callout_reset(). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=176596 
State-Changed-From-To: analyzed->patched 
State-Changed-By: ae 
State-Changed-When: Fri Nov 22 04:46:30 UTC 2013 
State-Changed-Why:  
This has been fixed in head/ with r254823. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=176596 
>Unformatted:
