From nobody@FreeBSD.org  Wed Feb 20 03:13:26 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	by hub.freebsd.org (Postfix) with ESMTP id E3815270
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 20 Feb 2013 03:13:26 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 8D793C2F
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 20 Feb 2013 03:13:26 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.5/8.14.5) with ESMTP id r1K3DQua071062
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 20 Feb 2013 03:13:26 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.5/8.14.5/Submit) id r1K3DQaC071061;
	Wed, 20 Feb 2013 03:13:26 GMT
	(envelope-from nobody)
Message-Id: <201302200313.r1K3DQaC071061@red.freebsd.org>
Date: Wed, 20 Feb 2013 03:13:26 GMT
From: Marcelo Araujo <araujo@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [kernel] On net/if_var.h we can't return a value in a void function.
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         176280
>Category:       kern
>Synopsis:       [kernel] On net/if_var.h we can't return a value in a void function.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Feb 20 03:20:01 UTC 2013
>Closed-Date:    
>Last-Modified:  Thu Feb 21 02:47:05 UTC 2013
>Originator:     Marcelo Araujo
>Release:        9.1-RELEASE
>Organization:
FreeBSD
>Environment:
FreeBSD qnap91 9.1-RELEASE FreeBSD 9.1-RELEASE #0: Tue Jan 22 11:03:23 CST 2013     root@qnap91:/usr/obj/usr/src/sys/QNAP  amd64
>Description:
On FreeBSD-HEAD specifically on sys/net/if_var.h at line 695 on the function drbr_advance we cannot call a return in a void function, we should use the mbuf struct.
>How-To-Repeat:
Build it using clang.
>Fix:


Patch attached with submission follows:

--- sys/net/if_var.h	2013-02-19 10:54:20.065079344 +0800
+++ /tmp/b	2013-02-20 11:07:26.009262919 +0800
@@ -695,7 +695,7 @@
 	return (buf_ring_dequeue_sc(br));
 }
 
-static __inline void
+static __inline int 
 drbr_advance(struct ifnet *ifp, struct buf_ring *br)
 {
 #ifdef ALTQ


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: araujo 
State-Changed-When: Wed Feb 20 04:03:57 UTC 2013 
State-Changed-Why:  
It is not a problem... :) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=176280 
State-Changed-From-To: closed->open 
State-Changed-By: araujo 
State-Changed-When: Thu Feb 21 02:47:04 UTC 2013 
State-Changed-Why:  
Re-open this PR, discussed with Eitan Adler 

http://www.freebsd.org/cgi/query-pr.cgi?pr=176280 
>Unformatted:
