From nobody@FreeBSD.org  Sun Mar 26 08:24:10 2000
Return-Path: <nobody@FreeBSD.org>
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
	by hub.freebsd.org (Postfix) with ESMTP id 7F48C37B896
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 26 Mar 2000 08:24:10 -0800 (PST)
	(envelope-from nobody@FreeBSD.org)
Received: (from nobody@localhost)
	by freefall.freebsd.org (8.9.3/8.9.2) id IAA03315;
	Sun, 26 Mar 2000 08:24:11 -0800 (PST)
	(envelope-from nobody@FreeBSD.org)
Message-Id: <200003261624.IAA03315@freefall.freebsd.org>
Date: Sun, 26 Mar 2000 08:24:11 -0800 (PST)
From: rguyom@mail.dotcom.fr
Sender: nobody@FreeBSD.org
To: freebsd-gnats-submit@FreeBSD.org
Subject: matcd driver worked on 3.x but doesn't work anymore on 4.0-STABLE
X-Send-Pr-Version: www-1.0

>Number:         17605
>Category:       kern
>Synopsis:       matcd driver worked on 3.x but doesn't work anymore on 4.0-STABLE
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Mar 26 08:30:01 PST 2000
>Closed-Date:    Mon Aug 14 05:52:30 PDT 2000
>Last-Modified:  Tue Aug 22 22:40:05 PDT 2000
>Originator:     Rmi Guyomarch
>Release:        4.0-STABLE
>Organization:
>Environment:
FreeBSD diabolic-cow.mail.dotcom.fr 4.0-STABLE FreeBSD 4.0-STABLE #30: Sun Mar 26 17:08:44 CEST 2000     root@diabolic-cow.mail.dotcom.fr:/usr/src/sys/compile/DIABOLIC-COW  i386
>Description:
The matcd driver isn't used at all. "dmesg | grep matcd" doesn't output
anything.

>How-To-Repeat:
Add a line "device matcd0 at isa? port ?", compile, install, reboot and
"dmesg | grep matcd".
>Fix:
It seems it's just a typo in i386/isa/matcd.c. This patch fix
the problem :

--- src/sys/i386/isa/matcd.c.orig   Sun Mar 26 17:02:38 2000
+++ src/sys/i386/isa/matcd.c        Sun Mar 26 17:04:08 2000
@@ -496,7 +496,7 @@
 static int     matcd_probe(struct isa_device *dev);
 static int     matcd_attach(struct isa_device *dev);
 struct isa_driver      matcddriver={matcd_probe, matcd_attach,
-                                    "matcdc"};
+                                    "matcd"};
 
 
 static d_open_t                matcdopen;


>Release-Note:
>Audit-Trail:

From: Brian Candler <B.Candler@pobox.com>
To: freebsd-gnats-submit@FreeBSD.org, rguyom@mail.dotcom.fr
Cc: Frank Durda IV <bsdmail@nemesis.lonestar.org>
Subject: Re: kern/17605: matcd driver worked on 3.x but doesn't work anymore on 4.0-STABLE
Date: Sun, 14 May 2000 21:59:47 +0100

 I had the same problem here. I don't think it's exactly a typo (see the
 author's note <20> in the source file), but thanks for providing a solution.
 
 For someone who understands this stuff better than me: I have compiled a
 kernel with 'options BUS_DEBUG', and have attached some excerpts from dmesg,
 (1) with Remi's patch, and (2) unmodified kernel [except for a few
 additional printf's of my own]
 
 Looking at the unmodified kernel: when device_add_child_ordered is called,
 it is asking for 'matcd' rather than 'matcdc' and fails.
 
 Regards,
 
 Brian Candler.
 
 ---------------------------------------------------------------------------
 
 (1) Working: FreeBSD 4.0-RELEASE plus Remi's patch ("matcdc" -> "matcd" in
 line 499)
 
 ...
 May 14 21:01:25 karma /kernel: device_add_child_ordered:658: isa at nexus with order 0 as unit 0
 May 14 21:01:25 karma /kernel: make_device:590: isa at nexus as unit 0
 May 14 21:01:25 karma /kernel: devclass_find_internal:251: looking for isa
 May 14 21:01:25 karma /kernel: devclass_add_device:533: (null) in devclass isa
 May 14 21:01:25 karma /kernel: devclass_alloc_unit:483: unit 0 in devclass isa
 May 14 21:01:25 karma /kernel: devclass_alloc_unit:522: now: unit 0 in devclass isa
 May 14 21:01:25 karma /kernel: devclass_find_driver_internal:393: isa in devclass nexus
 May 14 21:01:25 karma /kernel: device_probe_child:772: Trying isa
 May 14 21:01:25 karma /kernel: [Entered isa_probe]
 May 14 21:01:25 karma /kernel: devclass_find_internal:251: looking for isa
 May 14 21:01:25 karma /kernel: devclass_add_driver:296: matcd
 May 14 21:01:25 karma /kernel: compile_methods:216: matcd has 2 methods, wasting 152 bytes
 May 14 21:01:25 karma /kernel: devclass_find_internal:251: looking for matcd
 May 14 21:01:25 karma /kernel: devclass_find_internal:259: matcd not found, creating
 May 14 21:01:25 karma /kernel: (wrap old_driver matcd)
 May 14 21:01:25 karma /kernel: isa0: <ISA bus> on motherboard
 May 14 21:01:25 karma /kernel: [Entered isa_attach]
 May 14 21:01:25 karma /kernel: [Entering isa_probe_children]
 May 14 21:01:25 karma /kernel: device_add_child_ordered:658: fdc at isa with order 1 as unit 0
 ...
 May 14 21:01:28 karma /kernel: devclass_alloc_unit:522: now: unit 0 in devclass ppc
 May 14 21:01:28 karma /kernel: device_add_child_ordered:658: matcd at isa with order 1 as unit 0
 May 14 21:01:28 karma /kernel: make_device:590: matcd at isa as unit 0
 May 14 21:01:28 karma /kernel: devclass_find_internal:251: looking for matcd
 May 14 21:01:28 karma /kernel: devclass_add_device:533: (null) in devclass matcd
 May 14 21:01:28 karma /kernel: devclass_alloc_unit:483: unit 0 in devclass matcd
 May 14 21:01:28 karma /kernel: devclass_alloc_unit:522: now: unit 0 in devclass matcd
 May 14 21:01:28 karma /kernel: device_add_child_ordered:658: ex at isa with order 1 as unit -1
 ...
 May 14 21:01:32 karma /kernel: plip0: <PLIP network interface> on ppbus0
 May 14 21:01:32 karma /kernel: devclass_find_driver_internal:393: matcd in devclass isa
 May 14 21:01:32 karma /kernel: device_probe_child:772: Trying matcd
 May 14 21:01:32 karma /kernel: [Entering isa_compat_probe]
 May 14 21:01:32 karma /kernel: [op->driver->name=matcd, dvp->id_iobase=0230]
 May 14 21:01:32 karma /kernel: [Probe: Yes]
 May 14 21:01:32 karma /kernel: < In matcd_probe >>
 May 14 21:01:32 karma /kernel: matcdc0: In probe i 0 y 4 port 230
 May 14 21:01:32 karma /kernel: matcd0: size of port_hints 32
 May 14 21:01:32 karma /kernel: < In doprobe(560,0) >>
 May 14 21:01:32 karma /kernel: matcdc0: Probe found something
 May 14 21:01:32 karma /kernel: matcd - Matsushita (Panasonic) CD-ROM Driver by FDIV, Version  1(26) 18-Oct-95
 May 14 21:01:32 karma /kernel: matcd0 at port 0x230-0x233 on isa0
 May 14 21:01:32 karma /kernel: matcdc: Attach dev c06d0540 id_unit 0
 May 14 21:01:32 karma /kernel: matcdc0 Host interface type 0
 May 14 21:01:32 karma /kernel: matcd0: Status byte 82 matcd0: [CR-5630.75]  
 May 14 21:01:32 karma /kernel: matcd0: driver is using old-style compatability shims
 May 14 21:01:32 karma /kernel: devclass_find_driver_internal:393: ex in devclass isa
 May 14 21:01:32 karma /kernel: device_probe_child:772: Trying ex
 ...
 
 ---------------------------------------------------------------------------
 
 (2) Not working: FreeBSD 4.0-RELEASE unpatched
 
 ...
 May 14 21:07:50 karma /kernel: device_add_child_ordered:658: isa at nexus with order 0 as unit 0
 May 14 21:07:50 karma /kernel: make_device:590: isa at nexus as unit 0
 May 14 21:07:50 karma /kernel: devclass_find_internal:251: looking for isa
 May 14 21:07:50 karma /kernel: devclass_add_device:533: (null) in devclass isa
 May 14 21:07:50 karma /kernel: devclass_alloc_unit:483: unit 0 in devclass isa
 May 14 21:07:50 karma /kernel: devclass_alloc_unit:522: now: unit 0 in devclass isa
 May 14 21:07:50 karma /kernel: devclass_find_driver_internal:393: isa in devclass nexus
 May 14 21:07:50 karma /kernel: device_probe_child:772: Trying isa
 May 14 21:07:50 karma /kernel: [Entered isa_probe]
 May 14 21:07:50 karma /kernel: devclass_find_internal:251: looking for isa
 May 14 21:07:50 karma /kernel: devclass_add_driver:296: matcdc
 May 14 21:07:50 karma /kernel: compile_methods:216: matcdc has 2 methods, wasting 152 bytes
 May 14 21:07:50 karma /kernel: devclass_find_internal:251: looking for matcdc
 May 14 21:07:50 karma /kernel: devclass_find_internal:259: matcdc not found, creating
 May 14 21:07:50 karma /kernel: (wrap old_driver matcdc)
 May 14 21:07:50 karma /kernel: isa0: <ISA bus> on motherboard
 May 14 21:07:50 karma /kernel: [Entered isa_attach]
 May 14 21:07:50 karma /kernel: [Entering isa_probe_children]
 May 14 21:07:50 karma /kernel: device_add_child_ordered:658: fdc at isa with order 1 as unit 0
 ...
 May 14 21:07:53 karma /kernel: devclass_alloc_unit:522: now: unit 0 in devclass ppc
 May 14 21:07:53 karma /kernel: device_add_child_ordered:658: matcd at isa with order 1 as unit 0
 May 14 21:07:53 karma /kernel: make_device:590: matcd at isa as unit 0
 May 14 21:07:53 karma /kernel: devclass_find_internal:251: looking for matcd
 May 14 21:07:53 karma /kernel: devclass_find_internal:259: matcd not found, creating
 May 14 21:07:53 karma /kernel: devclass_add_device:533: (null) in devclass matcd
 May 14 21:07:53 karma /kernel: devclass_alloc_unit:483: unit 0 in devclass matcd
 May 14 21:07:53 karma /kernel: devclass_alloc_unit:522: now: unit 0 in devclass matcd
 May 14 21:07:53 karma /kernel: device_add_child_ordered:658: ex at isa with order 1 as unit -1
 ...
 May 14 21:07:57 karma /kernel: plip0: <PLIP network interface> on ppbus0
 May 14 21:07:57 karma /kernel: devclass_find_driver_internal:393: matcd in devclass isa
 May 14 21:07:57 karma /kernel: devclass_find_driver_internal:400: not found
 May 14 21:07:57 karma /kernel: devclass_find_driver_internal:393: ex in devclass isa
 May 14 21:07:57 karma /kernel: device_probe_child:772: Trying ex
 ...
 
State-Changed-From-To: open->closed 
State-Changed-By: sheldonh 
State-Changed-When: Mon Aug 14 05:52:30 PDT 2000 
State-Changed-Why:  
Superseded by kern/20296. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=17605 

From: "Paul A. Scott" <pscott@the-frontier.org>
To: <freebsd-gnats-submit@FreeBSD.org>, <rguyom@mail.dotcom.fr>
Cc:  
Subject: Re: kern/17605: matcd driver worked on 3.x but doesn't work anymore on 4.0-STABLE
Date: Sun, 20 Aug 2000 12:10:37 -0700

 The above patch also works on FreeBSD 4.1 without modification.
 Apply with "patch -i matcd.c patchfile" to ignore whitespace differences.
 
 Paul
 
 

From: "Paul A. Scott" <pscott@the-frontier.org>
To: <freebsd-gnats-submit@FreeBSD.org>, <rguyom@mail.dotcom.fr>
Cc:  
Subject: Re: kern/17605: matcd driver worked on 3.x but doesn't work anymore on 4.0-STABLE
Date: Tue, 22 Aug 2000 22:39:46 -0700

  Sorry, that should have been a lower case ell (NOT eye):
 
  patch -l matcd.c patchfile" to ignore whitespace differences.
 
  Paul
 
>Unformatted:
