From nobody@FreeBSD.org  Mon Feb 11 11:48:54 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
	by hub.freebsd.org (Postfix) with ESMTP id D2CA03FB
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 11 Feb 2013 11:48:54 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id B9D7B143
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 11 Feb 2013 11:48:54 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.5/8.14.5) with ESMTP id r1BBmphS072979
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 11 Feb 2013 11:48:51 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.5/8.14.5/Submit) id r1BBmp8Q072978;
	Mon, 11 Feb 2013 11:48:51 GMT
	(envelope-from nobody)
Message-Id: <201302111148.r1BBmp8Q072978@red.freebsd.org>
Date: Mon, 11 Feb 2013 11:48:51 GMT
From: Olivier Cochard-Labbe <olivier@cochard.me>
To: freebsd-gnats-submit@FreeBSD.org
Subject: flow control systcl consistency for em drivers
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         176027
>Category:       kern
>Synopsis:       [em] [patch] flow control systcl consistency for em drivers
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-net
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Feb 11 11:50:00 UTC 2013
>Closed-Date:    
>Last-Modified:  Mon Feb 11 14:11:24 UTC 2013
>Originator:     Olivier Cochard-Labbe
>Release:        9.1-RELEASE
>Organization:
BSD Router Project
>Environment:
>Description:
On my systems em(4) flow control can be configured with:
dev.em.0.fc (if chipset depends of if_em.c)
or
dev.em.0.flow_control (if chipset depends of if_lem.c)

For more consistency (but a POLA?), here is a small patch for if_lem.c that replace 'flow_control' usage by 'fc' usage.


>How-To-Repeat:

>Fix:
Applying the patch.

Patch attached with submission follows:

--- sys/dev/e1000/if_lem.c.orig	2013-02-11 10:21:00.000000000 +0100
+++ sys/dev/e1000/if_lem.c	2013-02-11 10:21:20.000000000 +0100
@@ -458,7 +458,7 @@
 #endif
 
         /* Sysctl for setting the interface flow control */
-	lem_set_flow_cntrl(adapter, "flow_control",
+	lem_set_flow_cntrl(adapter, "fc",
 	    "flow control setting",
 	    &adapter->fc_setting, lem_fc_setting);
 


>Release-Note:
>Audit-Trail:

From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Olivier Cochard-Labbe <olivier@cochard.me>
Cc: freebsd-gnats-submit@FreeBSD.org, jfv@FreeBSD.org
Subject: Re: kern/176027: flow control systcl consistency for em drivers
Date: Mon, 11 Feb 2013 17:10:20 +0400

 I'd prefer the opposite: substitute for "flow_control" in if_em.c.
 
 Jack, what's your opinion?
 
 -- 
 Totus tuus, Glebius.
Responsible-Changed-From-To: freebsd-bugs->freebsd-net 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Mon Feb 11 14:11:01 UTC 2013 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=176027 
>Unformatted:
